Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3494

Change JideTable: Replace Jidesoft

    Details

    • Type: Task
    • Status: To-Do (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      IGB uses JideTable which can be replaced by JTable.

        Attachments

          Issue Links

            Activity

            Show
            karthik Karthik Raveendran added a comment - See Commit: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/7d6592eeb7a9f161a2bca53f0acca8982392af54
            Hide
            karthik Karthik Raveendran added a comment -

            StyledJTable which used to extends JideTable and now, after IGBF-3486, it extends JTable instead. Instances of this class is created in:
            DataProviderManagementGIU (table 98)
            DataProviderTableModel (infoDsTable 357)
            TrackDefaultview (table 103)
            TrackPreference (table 82)
            WebLinksView (serverTable 94, localTable 95)
            BookmarkManagerViewGUI (infoTable 94, dataTable 97)
            BookmarkPropertiesGUI (table 119)
            BundleRepositoryPrefsView (table 100)

            Show
            karthik Karthik Raveendran added a comment - StyledJTable which used to extends JideTable and now, after IGBF-3486 , it extends JTable instead. Instances of this class is created in: DataProviderManagementGIU (table 98) DataProviderTableModel (infoDsTable 357) TrackDefaultview (table 103) TrackPreference (table 82) WebLinksView (serverTable 94, localTable 95) BookmarkManagerViewGUI (infoTable 94, dataTable 97) BookmarkPropertiesGUI (table 119) BundleRepositoryPrefsView (table 100)
            Hide
            nfreese Nowlan Freese added a comment - - edited

            I think we can delete the following two lines in StyledJTable.java
            private static final int AUTO_RESIZE_LAST_COLUMN_FILL = 259;
            setAutoResizeMode(AUTO_RESIZE_LAST_COLUMN_FILL);

            AUTO_RESIZE_LAST_COLUMN_FILL was part of JideTable but was deprecated, I'm not sure it was even being used in IGB with Jidesoft.
            The setAutoResizeMode only accepts 5 legal values (javadocs). My hunch is that the AUTO_RESIZE_LAST_COLUMN_FILL value of 259 being passed to setAutoResizeMode isn't doing anything as it is not a valid value for a JTable. I can't see any difference in how the tables in IGB behave if I get rid of setAutoResizeMode and AUTO_RESIZE_LAST_COLUMN_FILL.

            Show
            nfreese Nowlan Freese added a comment - - edited I think we can delete the following two lines in StyledJTable.java private static final int AUTO_RESIZE_LAST_COLUMN_FILL = 259; setAutoResizeMode(AUTO_RESIZE_LAST_COLUMN_FILL); AUTO_RESIZE_LAST_COLUMN_FILL was part of JideTable but was deprecated, I'm not sure it was even being used in IGB with Jidesoft. The setAutoResizeMode only accepts 5 legal values ( javadocs ). My hunch is that the AUTO_RESIZE_LAST_COLUMN_FILL value of 259 being passed to setAutoResizeMode isn't doing anything as it is not a valid value for a JTable. I can't see any difference in how the tables in IGB behave if I get rid of setAutoResizeMode and AUTO_RESIZE_LAST_COLUMN_FILL.
            Show
            karthik Karthik Raveendran added a comment - Changes implemented. See Commit: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/1e68c06adcf88127702e9c1e49c5f15e89d894a0
            Hide
            ann.loraine Ann Loraine added a comment -

            Rationale seems good to me. Please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - Rationale seems good to me. Please submit PR.
            Show
            karthik Karthik Raveendran added a comment - PR Submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/958
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged. Main branch installers built and ready for testing.
            see: https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged. Main branch installers built and ready for testing. see: https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/
            Hide
            nfreese Nowlan Freese added a comment -

            Ann Loraine - The pull request contained other various commits that affect features such as LAF and colorComboBox that are affecting the UI in IGB.

            The only commits we need in order to remove JideTable are:
            7d6592e
            1e68c06

            Commits 8909781 and 1c24fc5 can be removed.

            Show
            nfreese Nowlan Freese added a comment - Ann Loraine - The pull request contained other various commits that affect features such as LAF and colorComboBox that are affecting the UI in IGB. The only commits we need in order to remove JideTable are: 7d6592e 1e68c06 Commits 8909781 and 1c24fc5 can be removed.
            Hide
            nfreese Nowlan Freese added a comment -

            I have created a pull request that reverts all of the current Jidesoft commits that were merged into main-JDK8.

            Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/960

            Show
            nfreese Nowlan Freese added a comment - I have created a pull request that reverts all of the current Jidesoft commits that were merged into main-JDK8. Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/960
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged branch that reverted commits.

            Show
            ann.loraine Ann Loraine added a comment - Merged branch that reverted commits.
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Tested main-JDK8 installer. Changes to Jidesoft were successfully reverted.

            Show
            nfreese Nowlan Freese added a comment - - edited Tested main-JDK8 installer. Changes to Jidesoft were successfully reverted.

              People

              • Assignee:
                Unassigned
                Reporter:
                karthik Karthik Raveendran
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: