Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 8
Description
After fixing all the errors that appeared during the JDK21 migration, IGB works well in Mac and Linux (both development and installers). However, with Windows, there exists an issue with the LookandFeel classes. It was later identified by David Norris that the issue was caused because these classes are being called in IGB.java and migrated the specific block of code to OSGIHandler.java and IGB was able to open up. Unfortunately, this code change broke the Linux workflow. So David thought the best course of action would be to do Linux specific changes in IGB.java and the Windows specific changes in OSGIHandler.java. This worked in Linux but not in Windows.
Turns importing UIManager and LookandFeel classes in IGB is causing an issue. Both classes have static methods, so they are loaded too early and it is unable to identify the Java native classes it needs to work the look and feel.
Initial changes in Windows: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415
Changes in Linux by David: https://bitbucket.org/hillrunner2008/integrated-genome-browser/commits/2271bb786bf72aae278f53422a6ba3b8cc5429e7
Attachments
Issue Links
- relates to
-
IGBF-3533 Update LoraineLab JDK 21 branches
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Description |
After fixing all the errors that appeared during the JDK21 migration, IGB works well in Mac and Linux (both development and installers). However, with Windows, there exists an issue with the LookandFeel classes. It was later identified by David Norris that the issue was caused because these classes are being called in IGB.java and migrated the specific block of code to OSGIHandler.java and IGB was able to open up. Unfortunately, this code change broke the Linux workflow. So David thought the best course of action would be to do Linux specific changes in IGB.java and the Windows specific changes in OSGIHandler.java. This worked in Linux but not in Windows.
Turns importing UIManager and LookandFeel classes in IGB is causing an issue. Both classes have static methods, so they are loaded too early and it is unable to identify the Java native classes it needs to work the look and feel. Initial changes in Windows: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415 Changes in Linux by David: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415 |
| Description |
After fixing all the errors that appeared during the JDK21 migration, IGB works well in Mac and Linux (both development and installers). However, with Windows, there exists an issue with the LookandFeel classes. It was later identified by David Norris that the issue was caused because these classes are being called in IGB.java and migrated the specific block of code to OSGIHandler.java and IGB was able to open up. Unfortunately, this code change broke the Linux workflow. So David thought the best course of action would be to do Linux specific changes in IGB.java and the Windows specific changes in OSGIHandler.java. This worked in Linux but not in Windows.
Turns importing UIManager and LookandFeel classes in IGB is causing an issue. Both classes have static methods, so they are loaded too early and it is unable to identify the Java native classes it needs to work the look and feel. Initial changes in Windows: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415 Changes in Linux by David: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415 |
After fixing all the errors that appeared during the JDK21 migration, IGB works well in Mac and Linux (both development and installers). However, with Windows, there exists an issue with the LookandFeel classes. It was later identified by David Norris that the issue was caused because these classes are being called in IGB.java and migrated the specific block of code to OSGIHandler.java and IGB was able to open up. Unfortunately, this code change broke the Linux workflow. So David thought the best course of action would be to do Linux specific changes in IGB.java and the Windows specific changes in OSGIHandler.java. This worked in Linux but not in Windows.
Turns importing UIManager and LookandFeel classes in IGB is causing an issue. Both classes have static methods, so they are loaded too early and it is unable to identify the Java native classes it needs to work the look and feel. Initial changes in Windows: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/dae47e819ce174d40c675bf4a402e78d51265415 Changes in Linux by David: https://bitbucket.org/hillrunner2008/integrated-genome-browser/commits/2271bb786bf72aae278f53422a6ba3b8cc5429e7 |
| Attachment | Metal_LNF.png [ 18163 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Karthik Raveendran [ karthik ] | David Norris [ david.norris ] |