Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 2, Summer 3, Summer 4, Summer 5, Summer 6
Description
Currently, the IGB Track Hub Web sites show a tiny popup window at the bottom right corner of the page. The popup appears if IGB is not running and the user clicks an "open in IGB" link.
The current popup is very unobtrusive and is easy to miss. Also, it lacks a link leading to the IGB download page. For new users, this could be a blocker, as they might not know what to do next.
To address this, I would like to change this popup so that it looks like the popup message appearing on the Genome Dashboard site.
The popup that appears on the Genome Dashboard site works better for this purpose because:
- It appears on the upper middle of the page and is also very large - impossible to miss
- It has a link to the IGB download page
Relevant links:
Code with the "popup" message I want to use:
- IGB Genome Dashboard interface - https://bioviz.org/genome-dashboard
- IGB Genome Dashboard codebase - https://bitbucket.org/lorainelab/genome-dashboard/src/master/
IGB Track Hub Facade interfaces (there are two):
- Big table with UCSC trackhubs - https://bioviz.org/public-trackhubs.html
- IGB Track Facade simple converter interface - https://translate.bioviz.org/
- Code base for the converter and the simple converter interface - https://bitbucket.org/lorainelab/hub-facade/src/main/
- Code base for the big table with UCSC trackhubs - https://bitbucket.org/lorainelab/bioviz/src/main/htdocs/trackhub-converter.html
- Code for deploying bioviz web site (with big table) - https://bitbucket.org/lorainelab/bioviz-playbooks
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Description |
Currently, the IGB Track Hub Web sites show a tiny popup window at the bottom right corner of the page. The popup appears if IGB is not running and the user clicks an "open in IGB" link.
The current popup is very unobtrusive and is easy to miss. Also, it lacks a link leading to the IGB download page. For new users, this could be a blocker, as they might not know what to do next. To address this, I would like to change this popup so that it looks like the popup message appearing on the Genome Dashboard site. The popup that appears on the Genome Dashboard site works better for this purpose because: * It appears on the upper middle of the page and is also very large - impossible to miss * It has a link to the IGB download page |
Currently, the IGB Track Hub Web sites show a tiny popup window at the bottom right corner of the page. The popup appears if IGB is not running and the user clicks an "open in IGB" link.
The current popup is very unobtrusive and is easy to miss. Also, it lacks a link leading to the IGB download page. For new users, this could be a blocker, as they might not know what to do next. To address this, I would like to change this popup so that it looks like the popup message appearing on the Genome Dashboard site. The popup that appears on the Genome Dashboard site works better for this purpose because: * It appears on the upper middle of the page and is also very large - impossible to miss * It has a link to the IGB download page Relevant links: Code with the "popup" message I want to use: * IGB Genome Dashboard interface - https://bioviz.org/genome-dashboard * IGB Genome Dashboard codebase - https://bitbucket.org/lorainelab/genome-dashboard/src/master/ IGB Track Hub Facade interfaces (there are two): * Big table with UCSC trackhubs - https://bioviz.org/public-trackhubs.html * IGB Track Facade simple converter interface - https://translate.bioviz.org/ * Code base for the converter and the simple converter interface - https://bitbucket.org/lorainelab/hub-facade/src/main/ * Code base for the big table with UCSC trackhubs - https://bitbucket.org/lorainelab/bioviz/src/main/htdocs/trackhub-converter.html * Code for deploying bioviz web site (with big table) - https://bitbucket.org/lorainelab/bioviz-playbooks |
| Sprint | Spring 9 [ 193 ] | Summer 1 [ 195 ] |
| Sprint | Summer 1 [ 195 ] | Summer 2 [ 196 ] |
| Rank | Ranked higher |
| Sprint | Summer 2 [ 196 ] | Summer 2, Summer 3 [ 196, 197 ] |
| Rank | Ranked higher |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Testing Karthik's bioviz branch:
- trackhub-converter.html and public-trackhubs.html - We need to change the text "To view a genome, start IGB" to something more general like "Please start IGB". The "To view a genome" text is confusing as clicking on the "Add Hub to IGB" also uses the same "To view a genome, start IGB" text, which may be confusing to the user.
- trackhub-converter.html and public-trackhubs.html - Clicking the "Install IGB" button in the modal doesn't seem to work in test mode, please double-check that this is wired correctly.
- trackhub-converter.html and public-trackhubs.html - Change the toast text "Connecting...", "Trying to find IGB open in the system" to "Connecting to IGB".
- public-trackhubs.html - When IGB is open, clicking "Add Hub to IGB" causes the modal to appear. If IGB is open the modal should not appear.
Same changes will most likely need to be made to the hub-facade.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Above changes implemented
hub-facade commit:https://bitbucket.org/KarthikRavee91/hub-facade/commits/89544c1f52f6062e3859a1fc15bcfdd8e3f8ab88
bioviz: https://bitbucket.org/KarthikRavee91/bioviz/commits/f9c75c77c1427b63ed63234ca2965d21a979cb80
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Two requests in regards to the changes to bioviz:
- Adding the window.igb_url_download to renderDownloadButton.js somehow seems odd to me. I know this is similar to how the genome dashboard is doing it. I'm also unsure if using a full URL versus a partial path is the best way to do it, in the event that we were trying to test something on a test server (bioviztest.bioviz.org).
- Can you please rebase your branch on main, it is 36 commits behind main and there are a couple changes that may have an effect.
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Sprint | Summer 2, Summer 3 [ 196, 197 ] | Summer 2, Summer 3, Summer 4 [ 196, 197, 198 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Changes above applied
hub-facade: https://bitbucket.org/KarthikRavee91/hub-facade/commits/branch/IGBF-3700
bioviz: https://bitbucket.org/KarthikRavee91/bioviz/branch/IGBF-3700
I am unable to submit a pull request on this issue yet. I have a login credentials issue with Atlassian, probably due to the domain change from uncc.edu to charlotte.edu. I have contacted their customer service to resolve this, they will get back to me in a day or two.
Note: This is resolved after sending Atlassian an email
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Sprint | Summer 2, Summer 3, Summer 4 [ 196, 197, 198 ] | Summer 2, Summer 3, Summer 4, Summer 5 [ 196, 197, 198, 199 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Ann Loraine [ aloraine ] |
Request for Karthik Raveendran: Please add PR for your new BioViz repository branch, as well, unless I do not need to merge anything there?
cc: Nowlan Freese
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Karthik Raveendran [ karthik ] |
PR for Bioviz Submitted: https://bitbucket.org/lorainelab/bioviz/pull-requests/149
Track hub and bioviz branches are both merged.
I installed the new code to bioviz.org and translate.bioviz.org.
There seems to be a problem, however.
When I visited the page "https://bioviz.org/public-trackhubs.html" with IGB not running, the site immediately showed a non-dismissable dialog forcing me to download IGB or leave the page. See attached image file.
Atten Karthik Raveendran and Nowlan Freese.
| Attachment | forced-download.png [ 18460 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Sprint | Summer 2, Summer 3, Summer 4, Summer 5 [ 196, 197, 198, 199 ] | Summer 2, Summer 3, Summer 4, Summer 5, Summer 6 [ 196, 197, 198, 199, 200 ] |
| Rank | Ranked higher |
This was caused due to a rogue alert message I added during testing. I have removed it and pushed the changes.
Commits:
BioViz: https://bitbucket.org/KarthikRavee91/bioviz/commits/9d0d6a63bb749acf024260d20b84f155416b2832
hub-facade: https://bitbucket.org/KarthikRavee91/hub-facade/commits/f209029a9cb44ab9ee2c8312c6ca2fc0ba661042
PR Submitted
BioViz: https://bitbucket.org/lorainelab/bioviz/pull-requests/152
hub-facade: https://bitbucket.org/lorainelab/hub-facade/pull-requests/35
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Karthik Raveendran [ karthik ] |
PRs are merged and deployed to bioviz.org and translate.bioviz.org.
Ready for final testing.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Paige Kulzer [ pkulzer ] |
I've finished testing trackhub-converter.html and public-trackhubs.html with IGB version's 10.0.1 and 10.1.0 and found no issues.
The new popup on these pages shows a much clearer message than before, and I've confirmed that track hubs are still being added to IGB properly.
There are no non-dismissable dialogs forcing me to download IGB or leave the page.
The popup only appears when IGB is not running.
Moving this ticket to Done.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Karthik Raveendran [ karthik ] |
Changes made from toast to modal
hub-facade commit: https://bitbucket.org/KarthikRavee91/hub-facade/branch/IGBF-3700
bioviz: https://bitbucket.org/KarthikRavee91/bioviz/branch/IGBF-3700