Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3752

Improve Filter Mark on IGB tracks when filter is applied to only a single track

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: 10.1.0
        • Labels:
          None

          Description

          Situation: The Filter... operation can be applied to a track's positive, negative, or both strands combined. Currently, when a filter is applied to just one strand of a track, the filter mark appears for both strands. This can be confusing to the user.

          Task: Fix it so that the filter mark only shows on a track (positive or negative) with an active filter.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-3698 Fix right-click Filter... in IGB when track is separated into (+) and (-) strands

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                nfreese Nowlan Freese created issue -
                nfreese Nowlan Freese made changes -
                Field Original Value New Value
                Epic Link IGBF-1765 [ 17855 ]
                nfreese Nowlan Freese made changes -
                Link This issue relates to IGBF-3698 [ IGBF-3698 ]
                Hide
                Permalink
                nfreese Nowlan Freese added a comment - - edited

                Some hints on where to look for the filter mark code:

                • core/igb/src/main/resources/igb.properties > showFilterMark=Show Filter Mark
                • core/igb/src/main/java/com/affymetrix/igb/tiers/TrackConstants.java > static final String PREF_SHOW_FILTER_MARK = "Show Filter Mark";//TK
                • core/igb/src/main/java/com/affymetrix/igb/action/ShowFilterMarkAction.java
                Show
                nfreese Nowlan Freese added a comment - - edited Some hints on where to look for the filter mark code: core/igb/src/main/resources/igb.properties > showFilterMark=Show Filter Mark core/igb/src/main/java/com/affymetrix/igb/tiers/TrackConstants.java > static final String PREF_SHOW_FILTER_MARK = "Show Filter Mark";//TK core/igb/src/main/java/com/affymetrix/igb/action/ShowFilterMarkAction.java
                jsirigin Jaya Sravani Sirigineedi made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                jsirigin Jaya Sravani Sirigineedi made changes -
                Sprint Summer 1 [ 195 ] Spring 10 [ 194 ]
                ann.loraine Ann Loraine made changes -
                Sprint Spring 10 [ 194 ] Spring 10, Summer 1 [ 194, 195 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                Fixed the issue, and testing is done working as expected. Updated code is available at branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3752. Please review and let me know if there any issues.

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - Fixed the issue, and testing is done working as expected. Updated code is available at branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3752 . Please review and let me know if there any issues.
                jsirigin Jaya Sravani Sirigineedi made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                jsirigin Jaya Sravani Sirigineedi made changes -
                Assignee Jaya Sravani Sirigineedi [ jsirigin ]
                jsirigin Jaya Sravani Sirigineedi made changes -
                Assignee Nowlan Freese [ nfreese ]
                nfreese Nowlan Freese made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Tested using Sravani's branch on Mac.

                Filter mark appears on appropriate strand.
                If filter is applied + track then the filter mark only appears on the + track (and not the - track).
                If filter applied to +/- combined track, filter mark appears on combined track. When combined track is split into + and - each of the tracks has the filter mark.
                If filter is applied to + track then combined with - track then split only the + track has the filter mark.

                Ready for pull request.

                Show
                nfreese Nowlan Freese added a comment - Tested using Sravani's branch on Mac. Filter mark appears on appropriate strand. If filter is applied + track then the filter mark only appears on the + track (and not the - track). If filter applied to +/- combined track, filter mark appears on combined track. When combined track is split into + and - each of the tracks has the filter mark. If filter is applied to + track then combined with - track then split only the + track has the filter mark. Ready for pull request.
                nfreese Nowlan Freese made changes -
                Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
                nfreese Nowlan Freese made changes -
                Assignee Nowlan Freese [ nfreese ] Jaya Sravani Sirigineedi [ jsirigin ]
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                Raised the pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1017. Please review and let me know if there are any issues

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - Raised the pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1017 . Please review and let me know if there are any issues
                jsirigin Jaya Sravani Sirigineedi made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                jsirigin Jaya Sravani Sirigineedi made changes -
                Assignee Jaya Sravani Sirigineedi [ jsirigin ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                PR is merged and "early access" installers deployed to bioviz.org.
                Ready for integration testing.

                Show
                ann.loraine Ann Loraine added a comment - - edited PR is merged and "early access" installers deployed to bioviz.org. Ready for integration testing.
                ann.loraine Ann Loraine made changes -
                Assignee Ann Loraine [ aloraine ]
                ann.loraine Ann Loraine made changes -
                Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
                ann.loraine Ann Loraine made changes -
                Assignee Ann Loraine [ aloraine ]
                nfreese Nowlan Freese made changes -
                Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Tested using early-access installer on Mac.

                The filter mark appears for each track independently now, correctly indicating which strand has the filter applied.

                Closing ticket.

                Show
                nfreese Nowlan Freese added a comment - Tested using early-access installer on Mac. The filter mark appears for each track independently now, correctly indicating which strand has the filter applied. Closing ticket.
                nfreese Nowlan Freese made changes -
                Assignee Jaya Sravani Sirigineedi [ jsirigin ]
                nfreese Nowlan Freese made changes -
                Resolution Done [ 10000 ]
                Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
                nfreese Nowlan Freese made changes -
                Fix Version/s 10.1.0 [ 11000 ]

                  People

                  • Assignee:
                    jsirigin Jaya Sravani Sirigineedi
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: