Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3850

Add SNP File Converter icon to IGB

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Minor
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          The SNP File Converter icon that is currently being used in the IGB App Manager should be added to the Tools menu in IGB. The icon can be found on Bitbucket: https://bitbucket.org/lorainelab/snp-file-converter/src/master/src/main/resources/images/23andMe-snp-converter-logo.png

            Attachments

              Issue Links

              blocks

              Task - A task that needs to be done. IGBF-3858 Release SNP file converter 10.0.1 to IGB app store

              • Major - Major loss of function.
              • Closed
              relates to

              Task - A task that needs to be done. IGBF-3661 Add ProtAnnot icon to context menu that appears right-click gene models

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-3551 Add ProtAnnot icon to IGB

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Tested using bitbucket download page for SNP converter.

                App's icon now appears in the tools menu.

                Closing ticket.

                Show
                nfreese Nowlan Freese added a comment - Tested using bitbucket download page for SNP converter. App's icon now appears in the tools menu. Closing ticket.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                PR is merged and new jar file for the new version (23andMe-snp-converter-10.0.1.jar) is deployed to the Downloads section and ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - PR is merged and new jar file for the new version (23andMe-snp-converter-10.0.1.jar) is deployed to the Downloads section and ready for testing.
                Hide
                Permalink
                pkulzer Paige Kulzer added a comment -

                Done!

                PR: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/15

                Show
                pkulzer Paige Kulzer added a comment - Done! PR: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/15
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Tested Paige's branch on Mac.

                App's icon now appears in the tools menu.

                Request for Paige Kulzer - before you create a pull request, please pull the latest changes to master and rebase your IGBF-3850 branch on top (your 3850 branch is missing your changes, including version change, from IGBF-3852).

                Show
                nfreese Nowlan Freese added a comment - Tested Paige's branch on Mac. App's icon now appears in the tools menu. Request for Paige Kulzer - before you create a pull request, please pull the latest changes to master and rebase your IGBF-3850 branch on top (your 3850 branch is missing your changes, including version change, from IGBF-3852 ).
                Hide
                Permalink
                pkulzer Paige Kulzer added a comment -

                The app's icon has been added to the tools menu. As for Ann's comment, maybe we can create a separate "investigate" ticket regarding the app's name since this ticket's scope only includes the addition of that icon.

                Branch: https://bitbucket.org/pkulzer-lorainelab/snp-file-converter/branch/IGBF-3850?dest=lorainelab%2Fsnp-file-converter%3Amaster

                Show
                pkulzer Paige Kulzer added a comment - The app's icon has been added to the tools menu. As for Ann's comment, maybe we can create a separate "investigate" ticket regarding the app's name since this ticket's scope only includes the addition of that icon. Branch: https://bitbucket.org/pkulzer-lorainelab/snp-file-converter/branch/IGBF-3850?dest=lorainelab%2Fsnp-file-converter%3Amaster
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                I don't think we need to add a right-click option for the converter option, so please look at IGBF-3551 for the details of how to add the icon to the Tools menu.

                Show
                nfreese Nowlan Freese added a comment - I don't think we need to add a right-click option for the converter option, so please look at IGBF-3551 for the details of how to add the icon to the Tools menu.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Doing this will likely require editing the SNP Converter code itself, not IGB.
                We did this for ProtAnnot at some point, so we can look through the commits in the ProtAnnot repository for ideas on how to make this happen for the SNP Converter App.

                Question: Why is it called "SNP Converter" ?

                It sounds like it transforms SNPs into something else. I don't think this is what it does, though. It converts a file format into some other file format - is that right? If yes, I think we should try to think of a name that is more specific about what the App does.

                How about: "23-and-Me file type converter"

                Possible cool use case:

                • Open a 23-and-Me data file for a person
                • Open a genome sequence data file for the same person
                • Compare the genotype calls - do they agree ?

                This could be a really cool demonstration of IGB capabilities!

                Show
                ann.loraine Ann Loraine added a comment - Doing this will likely require editing the SNP Converter code itself, not IGB. We did this for ProtAnnot at some point, so we can look through the commits in the ProtAnnot repository for ideas on how to make this happen for the SNP Converter App. Question: Why is it called "SNP Converter" ? It sounds like it transforms SNPs into something else. I don't think this is what it does, though. It converts a file format into some other file format - is that right? If yes, I think we should try to think of a name that is more specific about what the App does. How about: "23-and-Me file type converter" Possible cool use case: Open a 23-and-Me data file for a person Open a genome sequence data file for the same person Compare the genotype calls - do they agree ? This could be a really cool demonstration of IGB capabilities!

                  People

                  • Assignee:
                    pkulzer Paige Kulzer
                    Reporter:
                    pkulzer Paige Kulzer
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: