Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 6, Fall 1
Description
Situation: The description of the SNP File Converter in the IGB App Manager currently refers to the app by its old name, "23andMe SNP Converter". Also, the app appears by its old name in the Tools menu after being installed in IGB.
Task: For continuity, the app's description needs to be updated in the IGB App Manager. Its name will also need to be updated in the Tools menu.
Attachments
Issue Links
- blocks
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Sprint | Summer 7 [ 201 ] | Summer 6 [ 200 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Two suggested changes:
- In SnpConverterFrame.java there is a line setTitle("23&Me Converter"); that sets the title of the window that opens when the user starts the app. Should this be changed to something like "SNP Converter"?
- I think it would be good to pull the change to the .gitignore into its own commit, as it is not directly related to the changes to the updated description of the SNP converter. This stackoverflow talks about how to make the change.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Good catch!
I've updated that line in SnpConverterFrame.java to set the title as "SNP File Converter" instead. I also broke up my commits like you suggested, so you should now see two commits – one for the change to my .gitignore file and another with all of the app-related changes.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Changes and commit look good.
Ready for pull request.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Assignee | Nowlan Freese [ nfreese ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
PR is now merged, the build pipeline on bitbucket has completed, and there is a new jar file available for testing in the Downloads section of the main repository.
Ready for testing.
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested using the lorainelab Downloads section of the SNP file converter repository on Mac.
Description looks good, app installed correctly, app title was updated.
Closing ticket.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I'm re-opening this ticket because we missed a line of code in the pom.xml which still referred to the app by its old name.
EDIT: This line of code (i.e., the artifact ID) should not be changed in the future. This ID is what the IGB App Store uses to recognize apps, so when I went to update the SNP File Converter to a new version in the App Store with this artifact ID changed, it detected the SNP-File-Converter-10.0.1.jar file as a completely new app.
Closing this ticket once again!
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Sprint | Summer 6 [ 200 ] | Summer 6, Fall 1 [ 200, 202 ] |
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
I've updated the SNP File Converter's description in the IGB App Manager to remove all mention of its old name. I then also incremented the version number from 10.0.0 to 10.0.1 to ensure this new version of the description is loaded as default. Finally, I updated the app's name in the Tools menu.
Branch: https://bitbucket.org/pkulzer-lorainelab/snp-file-converter/branch/IGBF-3852?dest=lorainelab%2Fsnp-file-converter%3Amaster