Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.25
-
Epic Link:
-
Sprint:Sprint 18
Description
While testing graph track operations from the track context menu I noticed that many of the mathematical operations give the user two options: "Default" or "Configure...".
Selecting the "Default" option seemed to only copy the graph for the "Add" and "Subtract" operations and it reduced the values to "0" for the "Divide" and "Multiply" operations. This led me to suspect that the default value that was being applied to these operations was "0" and after checking with David it turns out that this is, in fact, the case.
I believe that the default values for track operations should be discussed or whether or not the default option should even be selectable.
When a user wants to apply a mathematical function to a graph track I don't think they would want to perform the function using a "hidden" default value, and certainly not by a value of "0".
I think the best option would be to remove the "Default" AND "Configure" option from the track operations context menus and upon selecting a mathematical operation the "Configure" box would automatically appear.
This is basically how the graph track operations work from the "Annotations tab" (forces the user to input a value) so it would be nice to be able to follow our own convention and remove user confusion with this story.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
While testing graph track operations I noticed that many of the mathematical operations give the user two options: "Default" or "Configure...".
Selecting the "Default" option seemed to only copy the graph for the "Add" and "Subtract" operations and it reduced the values to "0" for the "Divide" and "Multiply" operations. This led me to suspect that the default value that was being applied to these operations was "0" and after checking with David it turns out that this is, in fact, the case. I believe that the default values for track operations should be discussed or whether or not the default option should even be selectable. When a user wants to apply a mathematical function to a graph track I don't think they would want to perform the function using a "hidden" default value, and certainly not by a value of "0". I think the best option would be to remove the "Default" AND "Configure" option from the track operations context menus and upon selecting a mathematical operation the "Configure" box would automatically appear. This is basically how the graph track operations work from the "Annotations tab" (forces the user to input a value) so it would be nice to be able to follow our own convention and remove user confusion with this story. |
While testing graph track operations from the track context menu I noticed that many of the mathematical operations give the user two options: "Default" or "Configure...".
Selecting the "Default" option seemed to only copy the graph for the "Add" and "Subtract" operations and it reduced the values to "0" for the "Divide" and "Multiply" operations. This led me to suspect that the default value that was being applied to these operations was "0" and after checking with David it turns out that this is, in fact, the case. I believe that the default values for track operations should be discussed or whether or not the default option should even be selectable. When a user wants to apply a mathematical function to a graph track I don't think they would want to perform the function using a "hidden" default value, and certainly not by a value of "0". I think the best option would be to remove the "Default" AND "Configure" option from the track operations context menus and upon selecting a mathematical operation the "Configure" box would automatically appear. This is basically how the graph track operations work from the "Annotations tab" (forces the user to input a value) so it would be nice to be able to follow our own convention and remove user confusion with this story. |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Epic Link | IGBF-440 [ 15498 ] |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Sprint | Sprint 17 [ 22 ] |
| Epic Link | IGBF-439 [ 15497 ] | IGBF-526 [ 15589 ] |
| Assignee | David Norris [ dcnorris ] |
| Assignee | David Norris [ dcnorris ] | Tarun Mall [ tmall ] |
| Sprint | Sprint 17 [ 22 ] | Sprint 16 [ 21 ] |
| Rank | Ranked lower |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Sprint | Sprint 16 [ 21 ] |
| Sprint | Sprint 17 [ 22 ] |
| Rank | Ranked higher |
| Story Points | 0.25 |
| Assignee | Tarun Mall [ tmall ] | Mason Meyer [ mason ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
It seems that there is a problem relating to mismatch and mismatch pileup graphs...the track operations section of the context menu is enabled but I can't make the drop-down menu appear. This is not happening in the Live Version so it must be related to recent changes.
Ask Mason if clarification is needed. I am reassigning to Tarun and moving back into To-Do for changes.
| Assignee | Mason Meyer [ mason ] | Tarun Mall [ tmall ] |
| Status | Testing In Progress [ 10003 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Epic Link | IGBF-526 [ 15589 ] | IGBF-539 [ 15605 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Sprint | Sprint 17 [ 22 ] |
| Sprint | Sprint 18 [ 23 ] |
| Rank | Ranked higher |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Pull Request Submitted [ 10101 ] |
| Epic Link | IGBF-539 [ 15605 ] | IGBF-600 [ 15673 ] |
| Epic Link | IGBF-600 [ 15673 ] | IGBF-539 [ 15605 ] |
We should also make sure the math operator menu items are followed by "..." to indicate that more input is required.
| Epic Link | IGBF-539 [ 15605 ] | IGBF-600 [ 15673 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Assignee | Tarun Mall [ tmall ] | Mason Meyer [ mason ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
I am closing this issue because this whole issue is now irrelevant due to the changes requested to the new Graph Track operations user interface in IGBF-617.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Loraine Lab Workflow [ 15647 ] | Fall 2019 Workflow Update [ 19344 ] |
| Workflow | Fall 2019 Workflow Update [ 19344 ] | Revised Fall 2019 Workflow Update [ 21461 ] |
commit fe97313da4ed31814b8dff499e14a4eacdf4493c
Author: Tarun K. Mall <c2tarun@hotmail.com>
Date: Fri Apr 3 17:07:42 2015 -0400
Remove default option from track operations.