Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3922

Add softclip and paired menu right-click menu options for CRAM

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.1.0
    • Labels:
      None

      Description

      Situation: BAM/SAM files have additional right-click menu options "Show as Paired" and "Configure soft-clip" that should also be available for CRAM files, but are missing.

      Task: Enable the right-click menu options listed above for CRAM files.

      To reproduce the issue:

      1. Start IGB
      2. Add the smoke testing quickload as a new data provider.
      3. Select the human genome version H_Sapien_Dec_2013
      4. Add the cram and bam files (I don't think you need to load data, but see the file formats testing page for the location of where to load data in IGB if needed)
      5. Right-click on the track names and look for "Show as Paired" and "Configure soft-clip"

        Attachments

        1. bam.png
          bam.png
          36 kB
        2. CRAM_menu_options.png
          CRAM_menu_options.png
          216 kB
        3. cram.png
          cram.png
          25 kB

          Activity

          nfreese Nowlan Freese created issue -
          nfreese Nowlan Freese made changes -
          Field Original Value New Value
          Epic Link IGBF-1765 [ 17855 ]
          nfreese Nowlan Freese made changes -
          Attachment cram.png [ 18521 ]
          Attachment bam.png [ 18522 ]
          nfreese Nowlan Freese made changes -
          Description Situation: BAM/SAM files have additional right-click menu options "Show as Paired" and "Configure soft-clip" that should also be available for CRAM files, but are missing.

          Task: Enable the right-click menu options listed above for CRAM files.

          To reproduce the issue:
          Start IGB
          Add the [smoke testing quickload|https://quickload-testing.s3.amazonaws.com/smokeTestingQuickload/] as a new data provider.
          Select the human genome version H_Sapien_Dec_2013
          Add the cram and bam files (I don't think you need to load data, but see the [file formats testing page|https://wiki.bioviz.org/confluence/display/ITD/File+Formats] for the location of where to load data in IGB if needed)
          Right-click on the track names and look for "Show as Paired" and "Configure soft-clip"
          Situation: BAM/SAM files have additional right-click menu options "Show as Paired" and "Configure soft-clip" that should also be available for CRAM files, but are missing.

          Task: Enable the right-click menu options listed above for CRAM files.

          To reproduce the issue:
          # Start IGB
          # Add the [smoke testing quickload|https://quickload-testing.s3.amazonaws.com/smokeTestingQuickload/] as a new data provider.
          # Select the human genome version H_Sapien_Dec_2013
          # Add the cram and bam files (I don't think you need to load data, but see the [file formats testing page|https://wiki.bioviz.org/confluence/display/ITD/File+Formats] for the location of where to load data in IGB if needed)
          # Right-click on the track names and look for "Show as Paired" and "Configure soft-clip"
          nfreese Nowlan Freese made changes -
          Assignee Jaya Sravani Sirigineedi [ jsirigin ]
          jsirigin Jaya Sravani Sirigineedi made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          jsirigin Jaya Sravani Sirigineedi made changes -
          Attachment CRAM_menu_options.png [ 18524 ]
          Hide
          jsirigin Jaya Sravani Sirigineedi added a comment -

          Added both the menu options for CRAM files as well by adding the file type to the if condition, working as expected. Here is the updated code: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3922. Please review and let me know if there are any issues.

          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Added both the menu options for CRAM files as well by adding the file type to the if condition, working as expected. Here is the updated code: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3922 . Please review and let me know if there are any issues.
          jsirigin Jaya Sravani Sirigineedi made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          jsirigin Jaya Sravani Sirigineedi made changes -
          Assignee Jaya Sravani Sirigineedi [ jsirigin ] Nowlan Freese [ nfreese ]
          nfreese Nowlan Freese made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          Hide
          nfreese Nowlan Freese added a comment -

          Tested Sravani's branch on mac.

          Code change looks good and I can see the softclip and paired options in the right-click menu for a CRAM file.

          Ready for pull request.

          Show
          nfreese Nowlan Freese added a comment - Tested Sravani's branch on mac. Code change looks good and I can see the softclip and paired options in the right-click menu for a CRAM file. Ready for pull request.
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ] Jaya Sravani Sirigineedi [ jsirigin ]
          nfreese Nowlan Freese made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Raised the pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1042
          jsirigin Jaya Sravani Sirigineedi made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          jsirigin Jaya Sravani Sirigineedi made changes -
          Assignee Jaya Sravani Sirigineedi [ jsirigin ]
          nfreese Nowlan Freese made changes -
          Assignee Ann Loraine [ aloraine ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          PR is merged.

          Show
          ann.loraine Ann Loraine added a comment - PR is merged.
          nfreese Nowlan Freese made changes -
          Story Points 2 0.25
          nfreese Nowlan Freese made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          nfreese Nowlan Freese made changes -
          Assignee Ann Loraine [ aloraine ]
          nfreese Nowlan Freese made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          nfreese Nowlan Freese made changes -
          Fix Version/s 10.1.0 [ 11000 ]
          nfreese Nowlan Freese made changes -
          Epic Link IGBF-1765 [ 17855 ] IGBF-3467 [ 22628 ]
          Hide
          nfreese Nowlan Freese added a comment -

          Tested main branch installer on Mac.

          I can see the softclip and paired options in the right-click menu for a CRAM file.

          Closing ticket.

          Show
          nfreese Nowlan Freese added a comment - Tested main branch installer on Mac. I can see the softclip and paired options in the right-click menu for a CRAM file. Closing ticket.
          nfreese Nowlan Freese made changes -
          Assignee Jaya Sravani Sirigineedi [ jsirigin ]
          nfreese Nowlan Freese made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

            People

            • Assignee:
              jsirigin Jaya Sravani Sirigineedi
              Reporter:
              nfreese Nowlan Freese
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: