Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4050

Improve "Get latest IGB" button on the App Store

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Minor
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Situation: When someone navigates to an app on the IGB App Store (apps.bioviz.org) without IGB open, a button is present on the right side of the screen which reads "Get latest IGB". Clicking on this button does something unexpected: it reroutes the current tab to bioviz.org and it also opens a new tab to bioviz.org at the same time, resulting in two bioviz.org tabs opening from one button click.

          Task: Look into why the button is opening bioviz.org twice and then implement a fix.

          Expected behavior: Clicking the "Get latest IGB" button reroutes the page to the downloads page, not bioviz.org, such that someone can download IGB then click the back arrow and navigate back to apps.bioviz.org.

            Attachments

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Thank you! I have added the new branch to the Loraine Lab App Store repository.

              Moving to DONE.

              Show
              ann.loraine Ann Loraine added a comment - Thank you! I have added the new branch to the Loraine Lab App Store repository. Moving to DONE.
              Hide
              Permalink
              pkulzer Paige Kulzer (Inactive) added a comment -

              I've declined the original PR and have made a new one which copies the branch over to the Loraine Lab appstore repo: https://bitbucket.org/lorainelab/appstore/pull-requests/291

              Show
              pkulzer Paige Kulzer (Inactive) added a comment - I've declined the original PR and have made a new one which copies the branch over to the Loraine Lab appstore repo: https://bitbucket.org/lorainelab/appstore/pull-requests/291
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Since we can't test this in a production-like environment with the diversity of Apps that are available on the main site, I don't want to merge this yet.
              So, I have a request for Paige Kulzer:

              Could you please submit the PR to the appstore code repository as a new branch so that we can keep your work on hand and merge it later once I get the app store playbooks updated?

              Show
              ann.loraine Ann Loraine added a comment - Since we can't test this in a production-like environment with the diversity of Apps that are available on the main site, I don't want to merge this yet. So, I have a request for Paige Kulzer : Could you please submit the PR to the appstore code repository as a new branch so that we can keep your work on hand and merge it later once I get the app store playbooks updated?
              Hide
              Permalink
              pkulzer Paige Kulzer (Inactive) added a comment -

              PR: https://bitbucket.org/lorainelab/appstore/pull-requests/290/overview

              Show
              pkulzer Paige Kulzer (Inactive) added a comment - PR: https://bitbucket.org/lorainelab/appstore/pull-requests/290/overview
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Tested locally on Mac using the instructions above.

              Get latest IGB button working as expected.

              Ready for PR.

              Show
              nfreese Nowlan Freese added a comment - Tested locally on Mac using the instructions above. Get latest IGB button working as expected. Ready for PR.
              Hide
              Permalink
              pkulzer Paige Kulzer (Inactive) added a comment -

              During testing, Dr. Freese observed that the button was not responsive when on an app page other than that of GenArk Genomes which is what I tested with. By removing one of the calls to the downloads page and preventing duplicate windows opening, I had to then also change the behavior of the button to trigger the other call to the downloads page.

              Ready for another round of review.

              Show
              pkulzer Paige Kulzer (Inactive) added a comment - During testing, Dr. Freese observed that the button was not responsive when on an app page other than that of GenArk Genomes which is what I tested with. By removing one of the calls to the downloads page and preventing duplicate windows opening, I had to then also change the behavior of the button to trigger the other call to the downloads page. Ready for another round of review.
              Hide
              Permalink
              pkulzer Paige Kulzer (Inactive) added a comment -

              I recreated this issue on my machine using IGB 9.1.10 and the GenArk Genomes App which requires IGB 10+. I was able to find the function that handles the logic for this and made a small change to fix the button. This has been merged into my previous commit since it's such a small change.

              Ready for review!

              Show
              pkulzer Paige Kulzer (Inactive) added a comment - I recreated this issue on my machine using IGB 9.1.10 and the GenArk Genomes App which requires IGB 10+. I was able to find the function that handles the logic for this and made a small change to fix the button. This has been merged into my previous commit since it's such a small change. Ready for review!
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Testing App Store on Mac by clicking the Get latest IGB button:

              Branch Version:

              • No IGB - New tab opens with bioviz.org/download.html. Original tab remains on App Store.
              • IGB 9.0.2 - New tab opens with bioviz.org/download.html. Original tab remains on App Store.
                • A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store.
              • IGB 9.1.10 - Nothing happens
              • IGB 10.1.0 - Button changes to installing the app

              Release Version:

              • No IGB - New tab opens with bioviz.org. Original tab changes to bioviz.org.
              • IGB 9.0.2 - New tab opens with bioviz.org. Original tab changes to bioviz.org.
                • A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store.
              • IGB 9.1.10 - Same tab navigates to BioViz.org
              • IGB 10.1.0 - Button changes to installing the app

              The only issue that I could find is when the version of IGB is high enough that the App Store recognizes IGB as being compatible with the app store, but the app itself requires a higher version of IGB. On the branch version the Get latest IGB button fails to respond.

              Show
              nfreese Nowlan Freese added a comment - Testing App Store on Mac by clicking the Get latest IGB button: Branch Version: No IGB - New tab opens with bioviz.org/download.html. Original tab remains on App Store. IGB 9.0.2 - New tab opens with bioviz.org/download.html. Original tab remains on App Store. A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store. IGB 9.1.10 - Nothing happens IGB 10.1.0 - Button changes to installing the app Release Version: No IGB - New tab opens with bioviz.org. Original tab changes to bioviz.org. IGB 9.0.2 - New tab opens with bioviz.org. Original tab changes to bioviz.org. A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store. IGB 9.1.10 - Same tab navigates to BioViz.org IGB 10.1.0 - Button changes to installing the app The only issue that I could find is when the version of IGB is high enough that the App Store recognizes IGB as being compatible with the app store, but the app itself requires a higher version of IGB. On the branch version the Get latest IGB button fails to respond.
              Hide
              Permalink
              pkulzer Paige Kulzer (Inactive) added a comment - - edited

              Branch: https://bitbucket.org/pkulzer-lorainelab/appstore/branch/IGBF-4050

              The "Get latest IGB" button should no longer open two different windows when clicked. Instead, it should open a new tab to bioviz.org/download.html and leave the app store window open.

              Ready for review! Testing might be difficult since it requires the setup of a local app store instance, instructions for which can be found in IGBF-4275 or here: https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA

              Show
              pkulzer Paige Kulzer (Inactive) added a comment - - edited Branch: https://bitbucket.org/pkulzer-lorainelab/appstore/branch/IGBF-4050 The "Get latest IGB" button should no longer open two different windows when clicked. Instead, it should open a new tab to bioviz.org/download.html and leave the app store window open. Ready for review! Testing might be difficult since it requires the setup of a local app store instance, instructions for which can be found in IGBF-4275 or here: https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA

                People

                • Assignee:
                  pkulzer Paige Kulzer (Inactive)
                  Reporter:
                  pkulzer Paige Kulzer (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: