Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4098

Fix Color by for Samtools to have persistent user input

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: 10.2.0
        • Labels:
          None

          Description

          Currently, the Samtools tags option for Color by has a table that needs to be filled by the user. However, the table data disappears after the user clicks OK.

          Fix: The table data needs to be persistent through out an IGB session.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-4100 Add Delete button functionality in Color by Samtools tags table

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-4195 Add a Clear all button to Edit Tag and Color window

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-3942 Add the ability to add multiple values for Color by

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                6 older comments
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                Issues mention above are fixed. See commit

                Show
                karthik Karthik Raveendran added a comment - Issues mention above are fixed. See commit
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                I forked Karthik's branch and tested the Color by feature. Issues #1, 3, and 4 all appear to be fixed with this new commit. The Color by table is now retaining user input after each closing and reopening of the table, and no errors are being thrown when the Color by window or table are closed.

                I found one other small feature that I wanted to mention of this ticket (again, this is likely out of scope): The values in the Color by table are persisting even after switching genomes. A Clear All or Delete All button might be a good compromise for this if there's no way to detect when a genome's been changed. That would provide user's with a quick way to reset the table.

                Recommending PR!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - I forked Karthik's branch and tested the Color by feature. Issues #1, 3, and 4 all appear to be fixed with this new commit. The Color by table is now retaining user input after each closing and reopening of the table, and no errors are being thrown when the Color by window or table are closed. I found one other small feature that I wanted to mention of this ticket (again, this is likely out of scope): The values in the Color by table are persisting even after switching genomes. A Clear All or Delete All button might be a good compromise for this if there's no way to detect when a genome's been changed. That would provide user's with a quick way to reset the table. Recommending PR!
                Hide
                Permalink
                karthik Karthik Raveendran added a comment - - edited

                PR Submitted https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1073

                Note: The clear all button issue mentioned by Paige Kulzer above will be addressed in IGBF-4195

                Show
                karthik Karthik Raveendran added a comment - - edited PR Submitted https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1073 Note: The clear all button issue mentioned by Paige Kulzer above will be addressed in IGBF-4195
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                PR is merged. Installers are built and deployed to Bioviz.org Early Access section.

                Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - - edited PR is merged. Installers are built and deployed to Bioviz.org Early Access section. Ready for testing.
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Tested on Mac, entries in the Color by table are now persisting between the closing and re-opening of the table. This is true whether a user presses enter/clicks away after entering a Tag Value or not. No errors are appearing in the log.

                Closing this ticket.

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Tested on Mac, entries in the Color by table are now persisting between the closing and re-opening of the table. This is true whether a user presses enter/clicks away after entering a Tag Value or not. No errors are appearing in the log. Closing this ticket.

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    karthik Karthik Raveendran
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: