Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4118

Change Samtools Tags to SAMtags

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Minor
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Samtools Tags may be a mouthful for the user. Change the name to SAMtags so that users and future developers can easily refer to the features.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-3942 Add the ability to add multiple values for Color by

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-4100 Add Delete button functionality in Color by Samtools tags table

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Tested using main branch installer on Mac. Filter and Color by are now using "SAMtags" consistently. I also looked through the commit and visually confirmed that all instances of "SAMTags" has been switched to "SAMtags". Closing this ticket!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Tested using main branch installer on Mac. Filter and Color by are now using "SAMtags" consistently. I also looked through the commit and visually confirmed that all instances of "SAMTags" has been switched to "SAMtags". Closing this ticket!
                Hide
                Permalink
                karthik Karthik Raveendran added a comment - - edited

                Changed all references of SamTags to SAMtags including classnames to avoid confusion with samtools references in the rest of the codebase. Rebased the branch to IGBF-4098. See commit (Edited)

                Show
                karthik Karthik Raveendran added a comment - - edited Changed all references of SamTags to SAMtags including classnames to avoid confusion with samtools references in the rest of the codebase. Rebased the branch to IGBF-4098 . See commit (Edited)
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Changes included in this PR.

                Tested using main branch installer on Mac.

                Filter and Color are showing SAMTags instead of SAMtags. If we are going by the samtools documentation it should be SAMtags. I'm also confused because the commit for this ticket shows SAMtags.

                Show
                nfreese Nowlan Freese added a comment - Changes included in this PR . Tested using main branch installer on Mac. Filter and Color are showing SAMTags instead of SAMtags. If we are going by the samtools documentation it should be SAMtags. I'm also confused because the commit for this ticket shows SAMtags.
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                Changes implemented. See commit

                Show
                karthik Karthik Raveendran added a comment - Changes implemented. See commit

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    karthik Karthik Raveendran
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: