Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.2.0
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:Spring 4, Spring 5, Spring 6
Description
Investigate how to do the below improvements and implement them in the Genome Dynamic Search UI:
- Enable sorting of the column names, for example alphabetically sorting by "Scientific Name".
- Move the "Clear Search" button to the top of the app to the right of the search bar.
- Increase the default number of rows visible to 100 (Make the rows of the table scrollable).
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-4086 [ 23382 ] |
| Description |
Investigate how to do the below UI improvements and implement them in the Genome Dynamic Search so it can be extensible:
* Enable sorting of the column names, for example alphabetically sorting by "Scientific Name". * Move the "Clear Search" button to the top of the app to the right of the search bar. * Make columns extensible so that an app can add additional columns as needed. For example, right now the columns are Common Name, Scientific Name, Assembly Version. For UCSC GenArk we would also like to include Accession, taxonId, and GenArk Clade. * Increase the default number of rows visible to 100. * Make the rows of the table scrollable. |
Investigate how to do the below UI improvements and implement them in the Genome Dynamic Search so it can be extensible:
* Enable sorting of the column names, for example alphabetically sorting by "Scientific Name". * Move the "Clear Search" button to the top of the app to the right of the search bar. * Make columns extensible so that an app can add additional columns as needed. For example, right now the columns are Common Name, Scientific Name, Assembly Version. For UCSC GenArk we would also like to include Accession, taxonId, and GenArk Clade. * Increase the default number of rows visible to 100. * Make the rows of the table scrollable. |
| Description |
Investigate how to do the below UI improvements and implement them in the Genome Dynamic Search so it can be extensible:
* Enable sorting of the column names, for example alphabetically sorting by "Scientific Name". * Move the "Clear Search" button to the top of the app to the right of the search bar. * Make columns extensible so that an app can add additional columns as needed. For example, right now the columns are Common Name, Scientific Name, Assembly Version. For UCSC GenArk we would also like to include Accession, taxonId, and GenArk Clade. * Increase the default number of rows visible to 100. * Make the rows of the table scrollable. |
Investigate how to do the below improvements and implement them in the Genome Dynamic Search UI:
* Enable sorting of the column names, for example alphabetically sorting by "Scientific Name". * Move the "Clear Search" button to the top of the app to the right of the search bar. * Increase the default number of rows visible to 100 (Make the rows of the table scrollable). |
| Story Points | 4 | 2 |
| Sprint | Spring 3 [ 212 ] | Spring 4 [ 213 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Story Points | 2 | 3 |
After investigating, found that changing this to a new menu item might take a couple of weeks, so we will focus on the actual loading functionality first and then consider this again. Closing this ticket, will do the other UI changes in a new ticket after the loading functionality is implemented. Also, the changes that are part of this ticket are reviewed.
Notes from our discussion:
- Consider adding a new menu called "Genome Search" in the top menu bar.
- In this, we might add a menu item for Search to add searching functionality for our existing genomes.
- When users install the external data provider apps (like ucsc-genark), a new menu item will be added, eg, "GenArk Genomes"
- Upon clicking that menu item, a new window will be opened that loads the dynamic search UI for the external data provider similar to ProtAnnot.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Spring 4 [ 213 ] | Spring 4, Spring 5 [ 213, 214 ] |
Raised PR for the changes in IGB dynamic search code: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1067. For the changes in ucsc-genark app, as we aren't pushing to loraine lab yet, I have pushed it to my workspace.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
PR is merged. New installers are built and deployed to BioViz.org early access section.
Ready for final testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Spring 4, Spring 5 [ 213, 214 ] | Spring 4, Spring 5, Spring 6 [ 213, 214, 215 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Testing main branch on Mac.
- Clear Search button works, located next to search bar.
- Default number of rows set to 100.
- Sorting by column names alphabetically working, but I have one suggestion.
- The sorting is splitting the results into upper case and lower case such that all of the results that are uppercase are shown alphabetically, then all of the lowercase results are shown alphabetically. Would be better to ignore case when sorting alphabetically.
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Nowlan Freese Thanks for pointing that out, changed the sorting to case-insensitive sorting now. Please review and let me know if there are any other issues.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
Sorting is now case-insensitive.
Closing ticket.
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 10.2.0 [ 11100 ] |
add the total no.of genomes and the page number out of the total pages, change the Previous and next buttons to arrows. Remove load button and have single load.
Investigate adding this as a new menu item and opening it as a window.