Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4135

Fix few small issues related to Filter

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.2.0
    • Labels:
      None

      Description

      Fix a few small issues related to Filter:

      • Change the order of the operators in the Filter option so that the default is not "<=" as it gives an unsupported operation error for strings, which is the current expected behavior.
      • The name of the filter when a property filter is selected is a default long string which is a bit technical, so change the name to an understandable format.

        Attachments

          Activity

          Hide
          nfreese Nowlan Freese added a comment -

          Tested main branch on Mac.

          I followed Sravani's testing instructions and for both scenarios the filter is now working as expected.

          Closing ticket.

          Show
          nfreese Nowlan Freese added a comment - Tested main branch on Mac. I followed Sravani's testing instructions and for both scenarios the filter is now working as expected. Closing ticket.
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          PR is merged. New installers are built and deployed to Early Access section of bioviz.org web site.

          Show
          ann.loraine Ann Loraine added a comment - - edited PR is merged. New installers are built and deployed to Early Access section of bioviz.org web site.
          Show
          jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - Raised the PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1071
          Hide
          karthik Karthik Raveendran added a comment - - edited

          When a value is added to any Property filter property, the string is converted to lower case. When the user opens the property filter again the lowercase value is seen instead of what the user had added. This may not be part of the scope of this issue. Discussed with Nowlan Freese and agreed that this may need fixing possibly in a future ticket.

          Apart from that the changes seem fine. Recommending Pull Request

          Show
          karthik Karthik Raveendran added a comment - - edited When a value is added to any Property filter property, the string is converted to lower case. When the user opens the property filter again the lowercase value is seen instead of what the user had added. This may not be part of the scope of this issue. Discussed with Nowlan Freese and agreed that this may need fixing possibly in a future ticket. Apart from that the changes seem fine. Recommending Pull Request
          Hide
          jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment -

          The issue that was found while testing is: When a user tries to add the same filter twice (this filter should be the first filter in the dropdown and can take different values for the filter like Property filter, Average Quality Score filter), the first one is getting overridden as it was using the same instance. There are two sub-issues for this:

          Issue-1: (this issue exists in the older versions of IGB too)

          1. Load any genome track in IGB.
          2. Right click on the track name and click on Filter...
          3. In the Add/Remove/Edit Filters window click on Add.
          4. You might either get Property filter or Average Quality Score filter as the default one.
          5. Enter any values for the Filter and click on OK in the Add Filter pop up.
          6. Now click on Add again and add the same filter with different values.
          7. Observe the filter list in the Add/Remove/Edit Filters,
            Expected: both filters with the given values should be there.
            Actual: there are two filters but both with the values of the second filter.

          Issue-2: (this issue exists only from 10.1.0)

          1. Load any genome track in IGB.
          2. Right click on the track name and click on Filter...
          3. In the Add/Remove/Edit Filters window click on Add.
          4. You might either get Property filter or Average Quality Score filter as the default one.
          5. Enter any values for the Filter and click on OK in the Add Filter pop up.
          6. Click OK in the Add/Remove/Edit Filters window as well to apply the filter.
          7. Now do the same process again to add the same filter with different values.
          8. Observe the filter list in the Add/Remove/Edit Filters,
            Expected: both filters with the given values should be there.
            Actual: there are two filters but both with the values of the second filter.

          Fixed both the issues and the did the UI changes described in the ticket. Also, found some complex code that can be removed/simplified, did that as well. Here is the updated branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4135. As these changes impact the behavior of adding and removing filters for separate strands or combined strands, please test that as well when reviewing that ticket, here is a reference ticket (https://jira.bioviz.org/browse/IGBF-3698).

          I have tested the scenarios that might get effected and everything works as expected. Please review and let me know if there's any issue.

          Show
          jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - The issue that was found while testing is: When a user tries to add the same filter twice (this filter should be the first filter in the dropdown and can take different values for the filter like Property filter, Average Quality Score filter), the first one is getting overridden as it was using the same instance. There are two sub-issues for this: Issue-1: (this issue exists in the older versions of IGB too) Load any genome track in IGB. Right click on the track name and click on Filter... In the Add/Remove/Edit Filters window click on Add. You might either get Property filter or Average Quality Score filter as the default one. Enter any values for the Filter and click on OK in the Add Filter pop up. Now click on Add again and add the same filter with different values. Observe the filter list in the Add/Remove/Edit Filters, Expected: both filters with the given values should be there. Actual: there are two filters but both with the values of the second filter. Issue-2: (this issue exists only from 10.1.0) Load any genome track in IGB. Right click on the track name and click on Filter... In the Add/Remove/Edit Filters window click on Add. You might either get Property filter or Average Quality Score filter as the default one. Enter any values for the Filter and click on OK in the Add Filter pop up. Click OK in the Add/Remove/Edit Filters window as well to apply the filter. Now do the same process again to add the same filter with different values. Observe the filter list in the Add/Remove/Edit Filters, Expected: both filters with the given values should be there. Actual: there are two filters but both with the values of the second filter. Fixed both the issues and the did the UI changes described in the ticket. Also, found some complex code that can be removed/simplified, did that as well. Here is the updated branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4135 . As these changes impact the behavior of adding and removing filters for separate strands or combined strands, please test that as well when reviewing that ticket, here is a reference ticket ( https://jira.bioviz.org/browse/IGBF-3698 ). I have tested the scenarios that might get effected and everything works as expected. Please review and let me know if there's any issue.
          Hide
          jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment -

          When testing found an issue which is not present in Karthik Raveendran branch, so will check my code against his branch once and test everything once again to figure out what's happening.

          Show
          jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - When testing found an issue which is not present in Karthik Raveendran branch, so will check my code against his branch once and test everything once again to figure out what's happening.

            People

            • Assignee:
              jsirigin Jaya Sravani Sirigineedi (Inactive)
              Reporter:
              jsirigin Jaya Sravani Sirigineedi (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: