The issue that was found while testing is: When a user tries to add the same filter twice (this filter should be the first filter in the dropdown and can take different values for the filter like Property filter, Average Quality Score filter), the first one is getting overridden as it was using the same instance. There are two sub-issues for this:
Issue-1: (this issue exists in the older versions of IGB too)
- Load any genome track in IGB.
- Right click on the track name and click on Filter...
- In the Add/Remove/Edit Filters window click on Add.
- You might either get Property filter or Average Quality Score filter as the default one.
- Enter any values for the Filter and click on OK in the Add Filter pop up.
- Now click on Add again and add the same filter with different values.
- Observe the filter list in the Add/Remove/Edit Filters,
Expected: both filters with the given values should be there.
Actual: there are two filters but both with the values of the second filter.
Issue-2: (this issue exists only from 10.1.0)
- Load any genome track in IGB.
- Right click on the track name and click on Filter...
- In the Add/Remove/Edit Filters window click on Add.
- You might either get Property filter or Average Quality Score filter as the default one.
- Enter any values for the Filter and click on OK in the Add Filter pop up.
- Click OK in the Add/Remove/Edit Filters window as well to apply the filter.
- Now do the same process again to add the same filter with different values.
- Observe the filter list in the Add/Remove/Edit Filters,
Expected: both filters with the given values should be there.
Actual: there are two filters but both with the values of the second filter.
Fixed both the issues and the did the UI changes described in the ticket. Also, found some complex code that can be removed/simplified, did that as well. Here is the updated branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4135. As these changes impact the behavior of adding and removing filters for separate strands or combined strands, please test that as well when reviewing that ticket, here is a reference ticket (https://jira.bioviz.org/browse/IGBF-3698).
I have tested the scenarios that might get effected and everything works as expected. Please review and let me know if there's any issue.
Tested main branch on Mac.
I followed Sravani's testing instructions and for both scenarios the filter is now working as expected.
Closing ticket.