Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4193

Fix SAMtag selection change error

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.2.0
    • Labels:
      None

      Description

      When the user wants to Color the reads based on SAMtags, the user must first select the SAMtag key that IGB should use as the parameter to compare (such as "CR" or "CB") and then add SAMtags values to the Edit Tag and Color window. If the user follows that order and presses the Save and Apply button in the table window and then click OK in the Color by window, things work as expected.
      However, if the user forgets to choose the SAMtag key before saving the values then its too late. The only recourse then is to open Color by window, change the key and then open the Edit Tag and Color window, click on Save and Apply to register the change in SAMTags key.

      Example Scenario:
      1) User opens the Color by window
      2) Does not notice the SAMtag key is default "CR" (and the user wants to compare "CB" values)
      3) Opens Edit Tag and Color window
      4) Adds values and clicks Save and Apply button
      5) Clicks OK in Color by window
      6) Waits for IGB to color the reads and it colors everything light grey
      7) Realizes the mistake, goes back to Color by window, changes key to "CB", clicks OK
      8) Nothing changes but user waits for a while expecting things to change.

      This ticket is created to address this issue. In other Color by options such as Property, the value is not retained after the window is closed so this functionality is not needed for any other Color by options .This issue might require making changes to Color by methods that is used by other options but the changes should only apply to SAMtags.

        Attachments

          Issue Links

            Activity

            Hide
            karthik Karthik Raveendran added a comment -

            Fix implemented. See commit

            Show
            karthik Karthik Raveendran added a comment - Fix implemented. See commit
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            The SAMtags dropdown menu is now working fine for both Color by and Filter by. Recommending PR!

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - The SAMtags dropdown menu is now working fine for both Color by and Filter by. Recommending PR!
            Show
            karthik Karthik Raveendran added a comment - PR Submitted. https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1076
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            PR is merged. New installers are built and deployed to early access section of bioviz.org.

            Show
            ann.loraine Ann Loraine added a comment - - edited PR is merged. New installers are built and deployed to early access section of bioviz.org.
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            Tested early access version of IGB on Mac. A SAMtags dropdown menu is appearing in both the Color by and Filter by menus. Tag values are being retained in the Color by menu after closing the window. Also, a user must enter a SAMtag value in the Color by window before closing it which prevents the issue that this ticket was created to fix.

            Closing this ticket!

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - Tested early access version of IGB on Mac. A SAMtags dropdown menu is appearing in both the Color by and Filter by menus. Tag values are being retained in the Color by menu after closing the window. Also, a user must enter a SAMtag value in the Color by window before closing it which prevents the issue that this ticket was created to fix. Closing this ticket!

              People

              • Assignee:
                karthik Karthik Raveendran
                Reporter:
                karthik Karthik Raveendran
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: