Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4273

Fix downloads page install button in bioviz.org

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          The install button in the bioviz downloads page does not seem to appear. The console logd shows an error saying that "UAParser is undefined". Initial inspection revealed that the distribution link for ua-parser-js library is broken. Fortunately, there is a npm distribution link that provides the same functionality. For this task , replacing the following link:
          https://cdn.jsdelivr.net/gh/faisalman/ua-parser-js/src/ua-parser.js
          with
          https://cdn.jsdelivr.net/npm/ua-parser-js/dist/ua-parser.min.js
          seems to solve the issue.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              karthik Karthik Raveendran added a comment -

              Changes implemented. See commit

              Show
              karthik Karthik Raveendran added a comment - Changes implemented. See commit
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please submit PR.

              attn: Karthik Raveendran

              Show
              ann.loraine Ann Loraine added a comment - Please submit PR. attn: Karthik Raveendran
              Hide
              Permalink
              karthik Karthik Raveendran added a comment -

              PR Submitted: https://bitbucket.org/lorainelab/bioviz/pull-requests/178

              Show
              karthik Karthik Raveendran added a comment - PR Submitted: https://bitbucket.org/lorainelab/bioviz/pull-requests/178
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              PR is merged and the new code is deployed to bioviz.org. Ready for testing.

              Show
              ann.loraine Ann Loraine added a comment - PR is merged and the new code is deployed to bioviz.org. Ready for testing.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              The button is still not showing up.

              Karthik Raveendran can you check into it?

              Show
              ann.loraine Ann Loraine added a comment - The button is still not showing up. Karthik Raveendran can you check into it?
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Update:

              Show
              ann.loraine Ann Loraine added a comment - Update: Works fine on Karthik Raveendran windows machine Doesn't work on our Apple machines
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              I think this change will fix it - for my machine, at least!

              if (os == "Mac OS X" || os == "Mac OS" || os == "macOS") {

              Adding add "os == "macOS" made it work for me.

              attn: Karthik Raveendran

              Show
              ann.loraine Ann Loraine added a comment - I think this change will fix it - for my machine, at least! if (os == "Mac OS X" || os == "Mac OS" || os == "macOS" ) { Adding add "os == "macOS" made it work for me. attn: Karthik Raveendran
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Karthik Raveendran found the same fix. We figured out the edit needed, and I am pushing it to main.

              Show
              ann.loraine Ann Loraine added a comment - Karthik Raveendran found the same fix. We figured out the edit needed, and I am pushing it to main.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              I merged the edit and re-ran the playbooks. After clearing the cached files in my browser, I was able to see the button again - for both the early access and the released version download pages.

              Show
              ann.loraine Ann Loraine added a comment - I merged the edit and re-ran the playbooks. After clearing the cached files in my browser, I was able to see the button again - for both the early access and the released version download pages.

                People

                • Assignee:
                  karthik Karthik Raveendran
                  Reporter:
                  karthik Karthik Raveendran
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: