Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Summer 5
Description
The install button in the bioviz downloads page does not seem to appear. The console logd shows an error saying that "UAParser is undefined". Initial inspection revealed that the distribution link for ua-parser-js library is broken. Fortunately, there is a npm distribution link that provides the same functionality. For this task , replacing the following link:
https://cdn.jsdelivr.net/gh/faisalman/ua-parser-js/src/ua-parser.js
with
https://cdn.jsdelivr.net/npm/ua-parser-js/dist/ua-parser.min.js
seems to solve the issue.
Attachments
Activity
Karthik Raveendran found the same fix. We figured out the edit needed, and I am pushing it to main.
I think this change will fix it - for my machine, at least!
if (os == "Mac OS X" || os == "Mac OS" || os == "macOS") {
Adding add "os == "macOS" made it work for me.
attn: Karthik Raveendran
Update:
- Works fine on Karthik Raveendran windows machine
- Doesn't work on our Apple machines
The button is still not showing up.
Karthik Raveendran can you check into it?
PR is merged and the new code is deployed to bioviz.org. Ready for testing.
Please submit PR.
attn: Karthik Raveendran
Changes implemented. See commit
I merged the edit and re-ran the playbooks. After clearing the cached files in my browser, I was able to see the button again - for both the early access and the released version download pages.