Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4275

Upgrade App Store python version and dependencies

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      In previous issues (see linked tickets) saideepthi jagarapu re-discovered that the current configuration of App Store development environment can't run as-is and needs to be updated.

      To start, let's identity the latest, most robust version of python 3 that can run App Store, with whatever updated dependencies may be required.

      To complete this ticket:

      • Update the Developer's Guide to show all new development environment configurations that developers need to know about in order to start working on App Store.
      • Update code as needed to achieve same
      • Focus on the development environment only (we will address the production environment in another ticket)
      • Demonstrate that with the required changes, all functionality works as expected (except for the pending apps endpoint, which is fixed as part of a linked ticket)

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-3014 [ 21526 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-4254 [ IGBF-4254 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-2665 [ IGBF-2665 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] saideepthi jagarapu [ sjagarap ]
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 5 [ 222 ] Summer 5, Summer 6 [ 222, 223 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            sjagarap saideepthi jagarapu (Inactive) added a comment - - edited

            Python version upgraded from 3.6 to 3.13
            Django version upgraded from 2.2 to 4.2 and other dependency upgrades can be found here

            Branch changes: https://bitbucket.org/lorainelab-deepthi/appstore/branch/python-upgrade

            Updated the development guide document
            https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA

            Show
            sjagarap saideepthi jagarapu (Inactive) added a comment - - edited Python version upgraded from 3.6 to 3.13 Django version upgraded from 2.2 to 4.2 and other dependency upgrades can be found here Branch changes: https://bitbucket.org/lorainelab-deepthi/appstore/branch/python-upgrade Updated the development guide document https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA
            Hide
            sjagarap saideepthi jagarapu (Inactive) added a comment -

            Someone testing this,
            Go through the steps mentioned in the document to setup the local environment, Please mention if any steps are missing in the documentation.

            Moving this to review

            Show
            sjagarap saideepthi jagarapu (Inactive) added a comment - Someone testing this, Go through the steps mentioned in the document to setup the local environment, Please mention if any steps are missing in the documentation. Moving this to review
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            nfreese Nowlan Freese made changes -
            Assignee saideepthi jagarapu [ sjagarap ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 5, Summer 6 [ 222, 223 ] Testing 3 : 19 Nov - 29 Nov 2, Summer 5, Summer 6 [ 83, 222, 223 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ] Paige Kulzer [ pkulzer ]
            pkulzer Paige Kulzer (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            I walked through the testing steps with Deepthi to set up a local environment for testing her changes. I ran into a blocker while testing which ended up being caused by a line in the code that sends mail to a user after submitting an app. This has since been fixed. I then ran into another issue where a NameError was being thrown with each search in the App Store. This has also been fixed. In addition to these issues being resolved, all filters appear to be working correctly within the App Store. App submissions and approvals are also working as expected.

            Recommending PR!

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - I walked through the testing steps with Deepthi to set up a local environment for testing her changes. I ran into a blocker while testing which ended up being caused by a line in the code that sends mail to a user after submitting an app. This has since been fixed. I then ran into another issue where a NameError was being thrown with each search in the App Store. This has also been fixed. In addition to these issues being resolved, all filters appear to be working correctly within the App Store. App submissions and approvals are also working as expected. Recommending PR!
            pkulzer Paige Kulzer (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            pkulzer Paige Kulzer (Inactive) made changes -
            Assignee Paige Kulzer [ pkulzer ] saideepthi jagarapu [ sjagarap ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            A question for Paige Kulzer:

            You mentioned in your previous comment that there was:

            a blocker while testing which ended up being caused by a line in the code that sends mail to a user after submitting an app. This has since been fixed

            Please describe what was done to fix the blocker.

            My understanding of the development environment setup is that the tester needs to set up email capability for their local development / testing environment using a Google account. Is that what you did to fix the blocker? Please explain what was done to fix the blocker.

            cc:

            saideepthi jagarapu
            Paige Kulzer

            Show
            ann.loraine Ann Loraine added a comment - - edited A question for Paige Kulzer : You mentioned in your previous comment that there was: a blocker while testing which ended up being caused by a line in the code that sends mail to a user after submitting an app. This has since been fixed Please describe what was done to fix the blocker. My understanding of the development environment setup is that the tester needs to set up email capability for their local development / testing environment using a Google account. Is that what you did to fix the blocker? Please explain what was done to fix the blocker. cc: saideepthi jagarapu Paige Kulzer
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            I'll let Deepthi explain what she did to fix the blocker. I believe the line of code I mentioned needed to be commented out in order for me to move forward with testing, but I'm not sure what changes were made beyond that. We did set up email capability for the testing environment per step 11 of the document linked in Deepthi's first comment (App Store Set-up - Development environment).

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - I'll let Deepthi explain what she did to fix the blocker. I believe the line of code I mentioned needed to be commented out in order for me to move forward with testing, but I'm not sure what changes were made beyond that. We did set up email capability for the testing environment per step 11 of the document linked in Deepthi's first comment (App Store Set-up - Development environment).
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Hide
            sjagarap saideepthi jagarapu (Inactive) added a comment - - edited

            Once the setup for email is properly configured locally, the blocker for the mail is resolved. It's been tested. Please review the screenshot attached Ann Loraine

            Show
            sjagarap saideepthi jagarapu (Inactive) added a comment - - edited Once the setup for email is properly configured locally, the blocker for the mail is resolved. It's been tested. Please review the screenshot attached Ann Loraine
            Hide
            ann.loraine Ann Loraine added a comment -

            It sounds like saideepthi jagarapu is able to run the testing environment but Paige Kulzer could not. That is, developer saideepthi jagarapu was able to trouble-shoot the problem and fix it on her system, but tester / verifier Paige Kulzer could not.

            Is the documentation misleading, wrong, or unclear?

            Ideally, the documentation explaining how to set up the email functionality would be clear and correct enough to enable a tester (e.g., Paige Kulzer) to set up the testing environment without having to delete (comment out) code.

            Could you guys work together to ensure that the documentation is correct?

            I'm worried that when I try to test the App Store code on my system, or deploy it into production, this same step will fail.

            Show
            ann.loraine Ann Loraine added a comment - It sounds like saideepthi jagarapu is able to run the testing environment but Paige Kulzer could not. That is, developer saideepthi jagarapu was able to trouble-shoot the problem and fix it on her system, but tester / verifier Paige Kulzer could not. Is the documentation misleading, wrong, or unclear? Ideally, the documentation explaining how to set up the email functionality would be clear and correct enough to enable a tester (e.g., Paige Kulzer ) to set up the testing environment without having to delete (comment out) code. Could you guys work together to ensure that the documentation is correct? I'm worried that when I try to test the App Store code on my system, or deploy it into production, this same step will fail.
            Hide
            sjagarap saideepthi jagarapu (Inactive) added a comment -

            Just a correction, Paige used my google email as she doesn't have one. Because of which we were facing little discrepancies in email part. Also, I want someone to check the mail part who have active google account.

            Also, I was able to test end to end including mails, but sometimes I'm also not getting mails. This seems to be a local issue nothing to do with the python upgradation as this particular send_mail() django function acts similarly and is not deprecated or changed for newer django version 4.2.

            For example, when i pushed my code and tested a couple of weeks back, I was able to test end to end including mails.
            But when I tried to test with paige, even I faced issue with mail in my personal space.

            I feel there are some gaps in development documention which needs to be reviewed.

            attn: Ann Loraine

            Show
            sjagarap saideepthi jagarapu (Inactive) added a comment - Just a correction, Paige used my google email as she doesn't have one. Because of which we were facing little discrepancies in email part. Also, I want someone to check the mail part who have active google account. Also, I was able to test end to end including mails, but sometimes I'm also not getting mails. This seems to be a local issue nothing to do with the python upgradation as this particular send_mail() django function acts similarly and is not deprecated or changed for newer django version 4.2. For example, when i pushed my code and tested a couple of weeks back, I was able to test end to end including mails. But when I tried to test with paige, even I faced issue with mail in my personal space. I feel there are some gaps in development documention which needs to be reviewed. attn: Ann Loraine
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Thank you for the clarification saideepthi jagarapu.

            I think we should merge these changes into the main branch, and capture tasks "review clarity of development documentation" or "review development documentation changes" in new ticket(s).

            Regarding the second option:

            Reviewing changes (recent edits in the Google Doc) seems easiest and best.

            Next, we could do: "Set up a development / testing environment by following development documentation instructions and report any problems."

            Show
            ann.loraine Ann Loraine added a comment - - edited Thank you for the clarification saideepthi jagarapu . I think we should merge these changes into the main branch, and capture tasks "review clarity of development documentation" or "review development documentation changes" in new ticket(s). Regarding the second option: Reviewing changes (recent edits in the Google Doc) seems easiest and best. Next, we could do: "Set up a development / testing environment by following development documentation instructions and report any problems."
            Hide
            sjagarap saideepthi jagarapu (Inactive) added a comment -

            Sure Ann Loraine, I will create ticket for the same and link to this ticket.

            PR for the changes : https://bitbucket.org/lorainelab/appstore/pull-requests/285

            Show
            sjagarap saideepthi jagarapu (Inactive) added a comment - Sure Ann Loraine , I will create ticket for the same and link to this ticket. PR for the changes : https://bitbucket.org/lorainelab/appstore/pull-requests/285
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Assignee saideepthi jagarapu [ sjagarap ] Ann Loraine [ aloraine ]
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Link This issue is cloned by IGBF-4296 [ IGBF-4296 ]
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Link This issue relates to IGBF-4296 [ IGBF-4296 ]
            sjagarap saideepthi jagarapu (Inactive) made changes -
            Link This issue is cloned by IGBF-4296 [ IGBF-4296 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            pkulzer Paige Kulzer (Inactive) made changes -
            Assignee Paige Kulzer [ pkulzer ]
            pkulzer Paige Kulzer (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            I've successfully run through the documentation again with a new gmail account. I was able to log in and submit an app with no issues. I was also able to log in as admin, accept the pending app, and use all filters present in the app store as expected. Since a new ticket has been created for finalizing the documentation, I'm going to go ahead and close this ticket now.

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - I've successfully run through the documentation again with a new gmail account. I was able to log in and submit an app with no issues. I was also able to log in as admin, accept the pending app, and use all filters present in the app store as expected. Since a new ticket has been created for finalizing the documentation, I'm going to go ahead and close this ticket now.
            pkulzer Paige Kulzer (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            pkulzer Paige Kulzer (Inactive) made changes -
            Assignee Paige Kulzer [ pkulzer ] saideepthi jagarapu [ sjagarap ]

              People

              • Assignee:
                sjagarap saideepthi jagarapu (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: