Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4322

Make improvements to GenArk Genomes

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.2.0
    • Labels:
      None

      Description

      Situation: I've noticed that the columns in the GenArk Genomes table are not able to be resized. I think this would be a nice improvement to make, especially because the information in the Common Name column is often quite lengthy.

      Task: Investigate the ability to resize columns in the GenArk Genomes table.

        Attachments

          Activity

          Hide
          nfreese Nowlan Freese added a comment -

          Tested early access installer on Mac.

          Columns can be resized, working as expected.

          Closing ticket.

          Show
          nfreese Nowlan Freese added a comment - Tested early access installer on Mac. Columns can be resized, working as expected. Closing ticket.
          Hide
          ann.loraine Ann Loraine added a comment -

          PR is merged and new installers are built and deployed to bioviz.org early access section. Ready for final testing.

          Show
          ann.loraine Ann Loraine added a comment - PR is merged and new installers are built and deployed to bioviz.org early access section. Ready for final testing.
          Hide
          pkulzer Paige Kulzer (Inactive) added a comment -

          Thank you for letting me know! It was an automatic change by my IDE. I think I've fixed that setting so it shouldn't be an issue in the future.

          My commit has been updated, so I will now raise a PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1085

          Show
          pkulzer Paige Kulzer (Inactive) added a comment - Thank you for letting me know! It was an automatic change by my IDE. I think I've fixed that setting so it shouldn't be an issue in the future. My commit has been updated, so I will now raise a PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1085
          Hide
          nfreese Nowlan Freese added a comment -

          Tested on Paige's branch. Columns can be resized. Default behavior and column width are good. Everything else appears to be working.

          Paige Kulzer - Please make one change to your commit. On line 7 there is the following import:
          javax.swing.*;
          Please revert to the old import and avoid the use of "*" imports. This is most likely something your IDE did without asking, I think there is a setting you have to change in IntelliJ.

          Show
          nfreese Nowlan Freese added a comment - Tested on Paige's branch. Columns can be resized. Default behavior and column width are good. Everything else appears to be working. Paige Kulzer - Please make one change to your commit. On line 7 there is the following import: javax.swing.*; Please revert to the old import and avoid the use of "*" imports. This is most likely something your IDE did without asking, I think there is a setting you have to change in IntelliJ.
          Hide
          pkulzer Paige Kulzer (Inactive) added a comment -

          Branch: https://bitbucket.org/pkulzer-lorainelab/integrated-genome-browser/branch/IGBF-4322

          Sravani created a file in the IGB code base called GenomeDynamicSearchTableGUI.java which contains the code for initializing and resizing column widths in the GenArk Genomes table. I've added the following line of code which allows the columns to be resizable while still maintaining the overall size/look of the GenArk Genomes table:

          genomeDynamicSearchTable.setAutoResizeMode(JTable.AUTO_RESIZE_SUBSEQUENT_COLUMNS);
          

          Ready for review!

          Show
          pkulzer Paige Kulzer (Inactive) added a comment - Branch: https://bitbucket.org/pkulzer-lorainelab/integrated-genome-browser/branch/IGBF-4322 Sravani created a file in the IGB code base called GenomeDynamicSearchTableGUI.java which contains the code for initializing and resizing column widths in the GenArk Genomes table. I've added the following line of code which allows the columns to be resizable while still maintaining the overall size/look of the GenArk Genomes table: genomeDynamicSearchTable.setAutoResizeMode(JTable.AUTO_RESIZE_SUBSEQUENT_COLUMNS); Ready for review!

            People

            • Assignee:
              pkulzer Paige Kulzer (Inactive)
              Reporter:
              pkulzer Paige Kulzer (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: