Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4378

Fix manually entered clusters filling entire table

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Situation: When entering manual cluster values the clusters can populate the entire Color By SAMtags table.

          Task: Fix it so that the table is not filled with the user-defined cluster.

          To reproduce: Enter a manual tag and cluster value. Click View by Cluster. Enter a manual cluster and give it a color. Click View by Tags.
          Result: The new cluster populates the rest of the table. Would be good to prevent user from manually adding a cluster in the View by Cluster.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-4295 Add the ability to include cluster information to SAMtools tags Color by feature

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                Issue fixed in commit 89b2b7f

                Show
                karthik Karthik Raveendran added a comment - Issue fixed in commit 89b2b7f
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Tested this commit locally. I manually added a few entries to the tag view in the Color By table, then switched over to cluster view.

                There is no longer an extra editable column in the cluster view which is good because this extra row was contributing to the original issue. Editing cluster names in the cluster view then switching back to the tag view does not result in the entire table being populated. I tested with all sorts of cluster names including special characters and spaces, and I also ensured that all other functionality of the table has been retained as expected. No error in the Log.

                Recommending PR!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Tested this commit locally. I manually added a few entries to the tag view in the Color By table, then switched over to cluster view. There is no longer an extra editable column in the cluster view which is good because this extra row was contributing to the original issue. Editing cluster names in the cluster view then switching back to the tag view does not result in the entire table being populated. I tested with all sorts of cluster names including special characters and spaces, and I also ensured that all other functionality of the table has been retained as expected. No error in the Log. Recommending PR!
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                PR submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1094

                Show
                karthik Karthik Raveendran added a comment - PR submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1094
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                PR is merged.

                Show
                ann.loraine Ann Loraine added a comment - PR is merged.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Installers are built and deployed to bioviz.org early access section. Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - Installers are built and deployed to bioviz.org early access section. Ready for testing.
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Downloaded the Early Access installer to my Mac for testing. I followed the testing instructions outlined in IGBF-4344 as a guide. Manual edits to the cluster view are no longer propagating those changes throughout the table in tag view. The Color by functionality has been retained and there are no errors in the Log.

                Closing ticket!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Downloaded the Early Access installer to my Mac for testing. I followed the testing instructions outlined in IGBF-4344 as a guide. Manual edits to the cluster view are no longer propagating those changes throughout the table in tag view. The Color by functionality has been retained and there are no errors in the Log. Closing ticket!

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: