Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4379

User entered values in the Color By SAMtags should be auto-checked

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Situation: When a user enters a manual tag value in the Color By > SAMtags window, the row remains unchecked. This could confuse users.

      Task: Fix it so that when a user enters a value the row is automatically checked.

        Attachments

          Issue Links

            Activity

            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            Downloaded the Early Access installer to my Mac for testing. All rows with a tag value are being automatically checked. This holds true for manual entries as well as imported entries. Deleting an entry still unchecks the box and adding only a cluster and/or color does not check the box. Color by functionality is still working as expected. No errors in the Log.

            Closing ticket!

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - Downloaded the Early Access installer to my Mac for testing. All rows with a tag value are being automatically checked. This holds true for manual entries as well as imported entries. Deleting an entry still unchecks the box and adding only a cluster and/or color does not check the box. Color by functionality is still working as expected. No errors in the Log. Closing ticket!
            Hide
            ann.loraine Ann Loraine added a comment -

            Installers are built and deployed to bioviz.org early access section. Ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - Installers are built and deployed to bioviz.org early access section. Ready for testing.
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged.
            Show
            karthik Karthik Raveendran added a comment - PR submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1095
            Hide
            pkulzer Paige Kulzer (Inactive) added a comment -

            Tested locally, this change seems to be working well! Adding a Tag Value automatically checks the checkbox, and deleting a tag unchecks the checkbox. User input is still maintained between closing and reopening of the Color By window. No errors in the Log.

            Recommending PR!

            Show
            pkulzer Paige Kulzer (Inactive) added a comment - Tested locally, this change seems to be working well! Adding a Tag Value automatically checks the checkbox, and deleting a tag unchecks the checkbox. User input is still maintained between closing and reopening of the Color By window. No errors in the Log. Recommending PR!
            Hide
            karthik Karthik Raveendran added a comment -

            Issue fixed in c953b12

            Show
            karthik Karthik Raveendran added a comment - Issue fixed in c953b12

              People

              • Assignee:
                karthik Karthik Raveendran
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: