Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 9
Description
Situation: When a user attempts to import a file that is improperly formatted (e.g., space-separated text file), an error appears in the Color by table. This error being displayed is incorrectly formatted. It reads, "Error: Please make sure if the file format is right.java.lang.NullPointerException: Cannot invoke "String.length()" because "regex" is null". The message itself also extends past the boundary of the window size, forcing a user to expand the Color by window to read it.
Task: Update the error message and ensure that it does not change the formatting of the Color by window when it's thrown.
To reproduce: In the Color by window, click Import..., then open the file attached to this ticket. See the error at the bottom of the window.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-3765 [ 22984 ] |
| Attachment | pbmc_3col_space.txt [ 19051 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] | Paige Kulzer [ pkulzer ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
The error message has been updated and now reads "Error: Data is not formatted correctly. See IGB User's Guide". It is not being clipped/cut off by the edge of the Color By window anymore. Changes look good!
My only question for Karthik Raveendran is whether this error should disappear when a user clicks the Clear All button. Implementing this behavior would match that of the missing SAMtag warning.
If that is not the desired behavior, then I would recommend a PR.
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Karthik Raveendran [ karthik ] |
| Assignee | Karthik Raveendran [ karthik ] | Paige Kulzer [ pkulzer ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Karthik Raveendran [ karthik ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Unlike the other error messages in this module, this message requires the user to familiarize themselves with the data format of the file and re-edit their file to the correct format for all of which they might need the User's Guide. They can just google IGB User's Guide and find it. For the entire process I would like the error message to be there for the user's reference.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
PR is merged, installers are built and deployed to BioViz.org Early Access section.
Ready for testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Paige Kulzer [ pkulzer ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Downloaded the Early Access release and tested on my Mac. The error is formatted correctly and is human-readable. No errors in the Log. No odd behavior in the Color by table.
Closing ticket!
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Karthik Raveendran [ karthik ] |
Issues fixed in 7a5cbc5