Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-598

Fix select and selectfeature commands, and update loadmode documentation to reflect actual options available

    Details

      Description

      It seems there are a few non-functioning scripts that should be removed from the IGB Scripting language, such as the "Select" script.

      These non-functioning scripts should be removed from the IGB command language as it may add confusion to users.

        Attachments

          Issue Links

            Activity

            mason Mason Meyer (Inactive) created issue -
            mason Mason Meyer (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-568 [ 15637 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue relates to IGBF-525 [ IGBF-525 ]
            mason Mason Meyer (Inactive) made changes -
            Sprint Sprint 19 [ 24 ]
            Hide
            dcnorris David Norris (Inactive) added a comment -

            Add specifics to the description on what should be removed.

            Show
            dcnorris David Norris (Inactive) added a comment - Add specifics to the description on what should be removed.
            dcnorris David Norris (Inactive) made changes -
            Assignee Mason Meyer [ mason ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Fix Version/s 8.3.3 Minor Release [ 10000 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            mason Mason Meyer (Inactive) made changes -
            Sprint Sprint 19 [ 24 ] Sprint 18 [ 23 ]
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked lower
            mason Mason Meyer (Inactive) made changes -
            Status Open [ 1 ] Testing In Progress [ 10003 ]
            Hide
            mason Mason Meyer (Inactive) added a comment - - edited

            After testing I can confirm that all of the scripts listed on this page (https://wiki.transvar.org/display/igbman/IGB+Script+List) are working except for:

            1) select
            2) selectfeature
            3) the loadmode command parameters "REGION_IN_VIEW" and "CHROMOSOME" (the command works as expected with the other parameters)

            Reassigning to David for fixes.

            Show
            mason Mason Meyer (Inactive) added a comment - - edited After testing I can confirm that all of the scripts listed on this page ( https://wiki.transvar.org/display/igbman/IGB+Script+List ) are working except for: 1) select 2) selectfeature 3) the loadmode command parameters "REGION_IN_VIEW" and "CHROMOSOME" (the command works as expected with the other parameters) Reassigning to David for fixes.
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ] David Norris [ dcnorris ]
            mason Mason Meyer (Inactive) made changes -
            Status Testing In Progress [ 10003 ] Open [ 1 ]
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 18 [ 23 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 19 [ 24 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            dcnorris David Norris (Inactive) made changes -
            Story Points 0.1
            dcnorris David Norris (Inactive) made changes -
            Summary Remove non-functioning scripts from the IGB Scripting Language Updated Documentation on how to use commands which were misclassified as non-functioning in testing review
            dcnorris David Norris (Inactive) made changes -
            Assignee David Norris [ dcnorris ] Mason Meyer [ mason ]
            dcnorris David Norris (Inactive) made changes -
            Summary Updated Documentation on how to use commands which were misclassified as non-functioning in testing review Fix select and selectfeature commands, and update loadmode documentation to reflect actual options available
            Hide
            dcnorris David Norris (Inactive) added a comment -

            loadmode only accepts the following options

            1. no_load
            2. region_in_view / visible (they are synonyms in the scripting engine)
            3. genome

            region_in_view/visible doesn't really load the region in view, but results in the load mode of "Manual". This is actually not a bug, but a case of very poor naming by the original developers.

            There is not chromosome load mode, it was removed a few years ago.

            Show
            dcnorris David Norris (Inactive) added a comment - loadmode only accepts the following options 1. no_load 2. region_in_view / visible (they are synonyms in the scripting engine) 3. genome region_in_view/visible doesn't really load the region in view, but results in the load mode of "Manual". This is actually not a bug, but a case of very poor naming by the original developers. There is not chromosome load mode, it was removed a few years ago.
            Hide
            dcnorris David Norris (Inactive) added a comment -

            select and selectfeature work as expected on the development branch, but required a fix related to case sensitivity to work as expected.

            e.g. to test go to the latest Arabidopsis Genome Version and run the following script

            select AT1G36940.1

            note the selection occurs and the viewer is "jump zoomed" to the position.

            Now, load another script with this command instead.

            selectfeature AT1G36940.1

            The main viewer is not jump zoomed, but is now centered on this selection. To confirm this, simply operate the zoom slider and zoom into a level where you can see the selection of the gene model.

            Show
            dcnorris David Norris (Inactive) added a comment - select and selectfeature work as expected on the development branch, but required a fix related to case sensitivity to work as expected. e.g. to test go to the latest Arabidopsis Genome Version and run the following script select AT1G36940.1 note the selection occurs and the viewer is "jump zoomed" to the position. Now, load another script with this command instead. selectfeature AT1G36940.1 The main viewer is not jump zoomed, but is now centered on this selection. To confirm this, simply operate the zoom slider and zoom into a level where you can see the selection of the gene model.
            dcnorris David Norris (Inactive) made changes -
            Status In Progress [ 3 ] Needs Testing [ 10002 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked lower
            dcnorris David Norris (Inactive) made changes -
            Assignee Mason Meyer [ mason ] David Norris [ dcnorris ]
            dcnorris David Norris (Inactive) made changes -
            Status Needs Testing [ 10002 ] Open [ 1 ]
            dcnorris David Norris (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked lower
            Hide
            dcnorris David Norris (Inactive) added a comment -

            merged fix to master branch for minor release 8.3.4

            Show
            dcnorris David Norris (Inactive) added a comment - merged fix to master branch for minor release 8.3.4
            dcnorris David Norris (Inactive) made changes -
            Status In Progress [ 3 ] Needs Testing [ 10002 ]
            Hide
            tmall Tarun Mall (Inactive) added a comment -

            My testing verified that these commands are functioning and we updated the document based on the functioning.
            Since the story is resolved, I'll close it.

            Show
            tmall Tarun Mall (Inactive) added a comment - My testing verified that these commands are functioning and we updated the document based on the functioning. Since the story is resolved, I'll close it.
            tmall Tarun Mall (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Needs Testing [ 10002 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 15876 ] Fall 2019 Workflow Update [ 19461 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 19461 ] Revised Fall 2019 Workflow Update [ 21578 ]

              People

              • Assignee:
                dcnorris David Norris (Inactive)
                Reporter:
                mason Mason Meyer (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: