Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-885

Change Insertion glyph color and shape

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Currently, insertions are displayed using a red color with black text in the insertion.

      Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?

      Please read comments below before working on this story.

        Attachments

          Issue Links

            Activity

            mason Mason Meyer (Inactive) created issue -
            mason Mason Meyer (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-594 [ 15667 ]
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked higher
            mason Mason Meyer (Inactive) made changes -
            Summary Change Insertion glyph color to light orange and change the shape Change Insertion glyph color and change the shape
            mason Mason Meyer (Inactive) made changes -
            Summary Change Insertion glyph color and change the shape Change Insertion glyph color and shape
            Hide
            mason Mason Meyer (Inactive) added a comment -

            Please discuss with Nowlan before working on this issue. I believe he may have some valuable input for this story.

            Show
            mason Mason Meyer (Inactive) added a comment - Please discuss with Nowlan before working on this issue. I believe he may have some valuable input for this story.
            mason Mason Meyer (Inactive) made changes -
            Description Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. Can we change insertion glyph color to light orange and maybe even use a different shape so that it is more obviously different from simple mismatches?
            Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?
            Hide
            mason Mason Meyer (Inactive) added a comment -

            From Ann:

            Let's do this:

            Let's draw in the insertion Glyph as a semi-transparent, pale triangle glyph, consistent with biology iconography for "insertion"
            Color should be automatically chosen to contrast with the read color. You can find example code illustrating how to pick good contrasting colors somewhere in the code that draws the amino acid translation on top of Glyphs created from reading BED files.

            The insertion Glyph needs to be semi-transarent so that the bases underneath can be read.
            The triangle should point to the boundary between the two bases. Minus strand read triangles should point UP. Plus strand read triangles should point DOWN. (This will help people stay oriented.)
            When users click on the triangle, the Selection Info should show information about the insertion, NOT the read.
            Information should include:
            insertion site (genomic coordinate)
            sequence of the insertion (it should be something users can copy and paste)
            Note that the inserted sequence will be always be less than the total length of the read

            Show
            mason Mason Meyer (Inactive) added a comment - From Ann: Let's do this: Let's draw in the insertion Glyph as a semi-transparent, pale triangle glyph, consistent with biology iconography for "insertion" Color should be automatically chosen to contrast with the read color. You can find example code illustrating how to pick good contrasting colors somewhere in the code that draws the amino acid translation on top of Glyphs created from reading BED files. The insertion Glyph needs to be semi-transarent so that the bases underneath can be read. The triangle should point to the boundary between the two bases. Minus strand read triangles should point UP. Plus strand read triangles should point DOWN. (This will help people stay oriented.) When users click on the triangle, the Selection Info should show information about the insertion, NOT the read. Information should include: insertion site (genomic coordinate) sequence of the insertion (it should be something users can copy and paste) Note that the inserted sequence will be always be less than the total length of the read
            mason Mason Meyer (Inactive) made changes -
            Description Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?
            Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?

            Please red comments below before working on this story.
            dcnorris David Norris (Inactive) made changes -
            Assignee Tarun Mall [ tmall ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Backlog Grooming Meeting [ 34 ] Sprint 25 [ 32 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked lower
            tmall Tarun Mall (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            tmall Tarun Mall (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            tmall Tarun Mall (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            tmall Tarun Mall (Inactive) made changes -
            Description Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?

            Please red comments below before working on this story.
            Currently, insertions are displayed using a red color with black text in the insertion.

            Black text on red is very hard to read. We need to change this and maybe even use a different shape so that it is more obviously different from simple mismatches?

            Please read comments below before working on this story.
            tmall Tarun Mall (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            Hide
            tmall Tarun Mall (Inactive) added a comment -

            Right now we don't any glyph available for this and we might have to create a new glyph.

            Show
            tmall Tarun Mall (Inactive) added a comment - Right now we don't any glyph available for this and we might have to create a new glyph.
            tmall Tarun Mall (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 25 [ 32 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 26 [ 34 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            tmall Tarun Mall (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 26 [ 34 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 27 [ 35 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 27 [ 35 ] Backlog Grooming [ 37 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Backlog Grooming [ 37 ] Backlog Grooming 2 [ 38 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Backlog Grooming [ 38 ] Sprint 29 [ 37 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            tmall Tarun Mall (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            tmall Tarun Mall (Inactive) added a comment - - edited

            We need to change some things about how insertions (from BAM files) are shown, as follows:

            1) When users select an insertion Glyph, Selection info should be listed as follows, from top to bottom:

            feature type insertion
            length [length of the inserted bases, e.g., number of residues inserted]
            residues [whatever the inserted bases are]
            strand [strand of the read]
            start [start of the insertion]
            end [end of the insertion]
            id id

            nothing else should be shown

            3) Insertion Glyph should be black with white letters, not red with black letters

            I need this for a class I'm teaching so it would be great to get it done soon

            Show
            tmall Tarun Mall (Inactive) added a comment - - edited We need to change some things about how insertions (from BAM files) are shown, as follows: 1) When users select an insertion Glyph, Selection info should be listed as follows, from top to bottom: feature type insertion length [length of the inserted bases, e.g., number of residues inserted] residues [whatever the inserted bases are] strand [strand of the read] start [start of the insertion] end [end of the insertion] id id nothing else should be shown 3) Insertion Glyph should be black with white letters, not red with black letters I need this for a class I'm teaching so it would be great to get it done soon
            Hide
            mason Mason Meyer (Inactive) added a comment -

            From Ann on 11/10/15:

            You do not need to turn off edge matching for insertion glyphs. There is a perfectly good workaround - users can turn off edge matching if they like. And sometimes edge matching may actually be useful, even for insertion Glyphs.

            Show
            mason Mason Meyer (Inactive) added a comment - From Ann on 11/10/15: You do not need to turn off edge matching for insertion glyphs. There is a perfectly good workaround - users can turn off edge matching if they like. And sometimes edge matching may actually be useful, even for insertion Glyphs.
            tmall Tarun Mall (Inactive) made changes -
            Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
            tmall Tarun Mall (Inactive) made changes -
            Assignee Tarun Mall [ tmall ] John Eckstein [ jeckstein ]
            tmall Tarun Mall (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Testing Blocked [ 10201 ]
            tmall Tarun Mall (Inactive) made changes -
            Status Testing Blocked [ 10201 ] Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Insertion Glyph bases are not being shown. The Glyph is black, but the bases are either also black or not being drawn.

            Bases neighboring the site of an insertion are not shown.

            To repeat:

            1) Visit S. lycopersicum (tomato) genome
            2) Select chromosome chrC-NC_007898.3
            3) Select a dataset from Plastid Resequencing folder (not Primers or Amplicon - choose one of the others)
            4) Zoom in, load data
            5) Zoom in further, look for black insertion Glyphs
            6) Observe that bases are not being shown.

            What should happen is that bases should be displayed on top of the black glyph.

            Show
            ann.loraine Ann Loraine added a comment - - edited Insertion Glyph bases are not being shown. The Glyph is black, but the bases are either also black or not being drawn. Bases neighboring the site of an insertion are not shown. To repeat: 1) Visit S. lycopersicum (tomato) genome 2) Select chromosome chrC-NC_007898.3 3) Select a dataset from Plastid Resequencing folder (not Primers or Amplicon - choose one of the others) 4) Zoom in, load data 5) Zoom in further, look for black insertion Glyphs 6) Observe that bases are not being shown. What should happen is that bases should be displayed on top of the black glyph.
            ann.loraine Ann Loraine made changes -
            Status Needs Testing [ 10002 ] Open [ 1 ]
            ann.loraine Ann Loraine made changes -
            Assignee John Eckstein [ jeckstein ] Tarun Mall [ tmall ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            mason Mason Meyer (Inactive) made changes -
            Attachment Insertion.png [ 13234 ]
            tmall Tarun Mall (Inactive) made changes -
            Status Open [ 1 ] Needs Testing [ 10002 ]
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            mason Mason Meyer (Inactive) made changes -
            Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
            mason Mason Meyer (Inactive) made changes -
            Status Testing In Progress [ 10003 ] Needs Testing [ 10002 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 29 [ 37 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint For next sprint [ 38 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-1057 [ IGBF-1057 ]
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            mason Mason Meyer (Inactive) made changes -
            Attachment InsertionBasesOffset.png [ 13252 ]
            Hide
            mason Mason Meyer (Inactive) added a comment -

            While testing this issue I noticed that the Insertion bases are not being displayed on the black boxes, but I don't think they look as good as they could. The bases are slightly offset so that the left base is kind of bleeding into the nucleotide beside it. Because of this, I am moving it back to the To-Do column and assigning it to David.

            Show
            mason Mason Meyer (Inactive) added a comment - While testing this issue I noticed that the Insertion bases are not being displayed on the black boxes, but I don't think they look as good as they could. The bases are slightly offset so that the left base is kind of bleeding into the nucleotide beside it. Because of this, I am moving it back to the To-Do column and assigning it to David.
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ] David Norris [ dcnorris ]
            mason Mason Meyer (Inactive) made changes -
            Status Testing In Progress [ 10003 ] Open [ 1 ]
            mason Mason Meyer (Inactive) made changes -
            Status Open [ 1 ] Open [ 1 ]
            mason Mason Meyer (Inactive) made changes -
            Assignee David Norris [ dcnorris ] Mason Meyer [ mason ]
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ] David Norris [ dcnorris ]
            dcnorris David Norris (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            dcnorris David Norris (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue duplicates IGBF-1057 [ IGBF-1057 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue relates to IGBF-1057 [ IGBF-1057 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue is duplicated by IGBF-1057 [ IGBF-1057 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue is duplicated by IGBF-1057 [ IGBF-1057 ]
            Hide
            mason Mason Meyer (Inactive) added a comment -

            This story is duplicated by IGBF-1057. Since IGBF-1057 is more recent and contains the information that is currently pertinent to the issue, I will close this story now since it is no longer needed.

            Show
            mason Mason Meyer (Inactive) added a comment - This story is duplicated by IGBF-1057 . Since IGBF-1057 is more recent and contains the information that is currently pertinent to the issue, I will close this story now since it is no longer needed.
            mason Mason Meyer (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Open [ 1 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 16295 ] Fall 2019 Workflow Update [ 19623 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 19623 ] Revised Fall 2019 Workflow Update [ 21742 ]
            nfreese Nowlan Freese made changes -
            Link This issue relates to IGBF-529 [ IGBF-529 ]

              People

              • Assignee:
                dcnorris David Norris (Inactive)
                Reporter:
                mason Mason Meyer (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: