Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-888

Race conditions prevent some actions from coming to the toolbar

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Some actions are sometimes missing from the toolbar such as the Home action and the Save Image action.

      This should be fixed on the 8.5.0 branch.

        Attachments

          Activity

          mason Mason Meyer (Inactive) created issue -
          mason Mason Meyer (Inactive) made changes -
          Field Original Value New Value
          Epic Link IGBF-439 [ 15497 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tmall Tarun Mall (Inactive) made changes -
          Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          mason Mason Meyer (Inactive) made changes -
          Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
          Hide
          mason Mason Meyer (Inactive) added a comment -

          Now the missing actions like the Home action and the Save Image action have been restored but there are not in their correct places. The Home action should be on the far right and the camera should be on the right of the DNA sequence icon.

          Take a look at the attached screenshot of IGB 8.4.2 to see the proper order of icons in the toolbar. Reassigning to Tarun for fixes.

          Show
          mason Mason Meyer (Inactive) added a comment - Now the missing actions like the Home action and the Save Image action have been restored but there are not in their correct places. The Home action should be on the far right and the camera should be on the right of the DNA sequence icon. Take a look at the attached screenshot of IGB 8.4.2 to see the proper order of icons in the toolbar. Reassigning to Tarun for fixes.
          mason Mason Meyer (Inactive) made changes -
          Attachment 8.4.2 toolbar.PNG [ 13165 ]
          mason Mason Meyer (Inactive) made changes -
          Assignee Mason Meyer [ mason ] Tarun Mall [ tmall ]
          mason Mason Meyer (Inactive) made changes -
          Status Testing In Progress [ 10003 ] Open [ 1 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Open [ 1 ] Pull Request Submitted [ 10101 ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 25 [ 32 ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 26 [ 34 ]
          dcnorris David Norris (Inactive) made changes -
          Rank Ranked higher
          tmall Tarun Mall (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          mason Mason Meyer (Inactive) made changes -
          Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
          Hide
          mason Mason Meyer (Inactive) added a comment -

          After discussing Tarun's fix with David it was decided that Tarun should fix this issue using more robust code.

          While fixing we should make sure that the order of the toolbar icons appear as they are seen in the screenshot attached to this story.

          Show
          mason Mason Meyer (Inactive) added a comment - After discussing Tarun's fix with David it was decided that Tarun should fix this issue using more robust code. While fixing we should make sure that the order of the toolbar icons appear as they are seen in the screenshot attached to this story.
          mason Mason Meyer (Inactive) made changes -
          Assignee Mason Meyer [ mason ] Tarun Mall [ tmall ]
          mason Mason Meyer (Inactive) made changes -
          Status Testing In Progress [ 10003 ] Open [ 1 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tmall Tarun Mall (Inactive) made changes -
          Status In Progress [ 3 ] Needs Testing [ 10002 ]
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          Hide
          mason Mason Meyer (Inactive) added a comment -

          Testing for this issue included:

          -Verifying that toolbar action are coming in the appropriate place (see screenshot).
          -Verifying that toolbars maintain user chosen location after moving an icon and then restarting IGB.
          -Verifying that toolbar icons are coming to their default location after resetting IGB preferences to default.
          -Verifying that toolbar actions are functioning as expected.

          Since this issue is resolved it will now be closed.

          Show
          mason Mason Meyer (Inactive) added a comment - Testing for this issue included: -Verifying that toolbar action are coming in the appropriate place (see screenshot). -Verifying that toolbars maintain user chosen location after moving an icon and then restarting IGB. -Verifying that toolbar icons are coming to their default location after resetting IGB preferences to default. -Verifying that toolbar actions are functioning as expected. Since this issue is resolved it will now be closed.
          mason Mason Meyer (Inactive) made changes -
          Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
          mason Mason Meyer (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Testing In Progress [ 10003 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Workflow Loraine Lab Workflow [ 16298 ] Fall 2019 Workflow Update [ 19626 ]
          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 19626 ] Revised Fall 2019 Workflow Update [ 21745 ]

            People

            • Assignee:
              mason Mason Meyer (Inactive)
              Reporter:
              mason Mason Meyer (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: