I have raised a pull request.
Below is the link:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/691/igbf-937-changed-interproscan-as-default/diff
Could you please check it.

Code review is complete - it's fine!

Next steps:

• recruit another developer to assist
• request they perform functional review

I would recommend recruiting another new joiner to do the functional review so that they can get familiar with optionalPlugin projects and also the IGB app development workflows works.

I have done the functional testing and the changes are working fine. InterProScan tab is on top when we open a new ProtAnnot window. Moving the ticket to Reviewing Pull Request and assigning back to the developer.

Functional testing is done for the change and its working fine.
Dr. Loraine could you please merge the pull request?

Merged to master.
I think it is safe to close this thanks to the testing that was already done.

There may be a bug. It looks like the old behavior in which clicking on items in the display activates the Properties tab is no longer working.

It was likely introduced with:

https://bitbucket.org/aloraine/protannot/commits/abcd9ee0fe04d4760cfb07c1305050021be31ea4

Please watch this video:

• https://drive.google.com/file/d/1eV6B4S1QvbADXxJulsc_DBXe0hS9ahKi/view?usp=sharing

Suggestions on how to fix:

• Make a branch in which the change is reverted.
• Build ProtAnnot from that branch and check to see if the buggy behavior persists.
• If the buggy behavior is gone, submit PR.

Then:

Investigate code further to find out if you can make it possible for the InterProScan tab to be the active tab when the application first starts without changing what happens when users click on an item in the display. If it is not possible to do without a lot of refactoring, we can stick with the current behavior and mark this ticket as closed.

Created new branch that reverted commit abcd9ee: https://bitbucket.org/aloraine/protannot/src/IGBF-937-fix/
Also incremented version to 9.1.2.
Reverting the change restores the old behavior.

Merged branch into master.

Built new version 9.1.2 of ProtAnnot and uploaded to App Store.

For next steps:

Investigate code further to find out if you can make it possible for the InterProScan tab to be the active tab when the application first starts without changing what happens when users click on an item in the display. If it is not possible to do without a lot of refactoring, we can stick with the current behavior and mark this ticket as closed.

Sorry, I forgot to assign it to myself.
I just added one line to set the InterproScan as a default tab. The change was in Activator function.
Submitting it for the first level review.
Changes are present at:
https://bitbucket.org/pkulka10/prutha_protannot/src/IGBF-937/
You can also go to the downloads section of the repo to add it as a plugin in IGB and you can test it from there.

Prutha Kulkarni - did you check what happens when users click a gene model or other item in the ProtAnnot display?

(Please see video above for details.)

[~aloraine], I saw the video and understood what the expected behavior is. I will work on it on Tuesday. For now, moving the ticket back to In Progress.

As suspected, the app was not able to select properties tab on selection of gene model because we changed the order in which the tab were added to the tabbed pane in the last commit. Previously the properties tab was the default tab whenever we used to open protannot window because it was added first in the tabbed pane. For IGBF-937 I changed the order of the tabs in the tabbed pane to make InterproScan tab as a default tab. But, the mouse press event has a code which selects the first tab in the tabbed pane whenever the gene model is selected which was properties tab initially and after the change the first tab was InterproScan tab. Now that Prof. [~aloraine] has reverted the changes, I just made one change in the activate event handler to select the second tab which will be the default tab on protannot window open event. Rest everything is kept as it as and it is now switching to properties tab whenever we are selecting gene model in the window. Please review the changes which are present at:
https://bitbucket.org/pkulka10/prutha_protannot/commits/95a33f978067c454d1430aecaa060a5b2274913f

Interesting!
The code had a booby-trap

Reviewed this ticket. Yes it was really interesting how the working changed. Now it is working fine as expected - The default tab is InterProScan when the window opens but changes to Properties tab when a gene model is clicked on. Prutha Kulkarni kindly submit a PR for the same.

PR submitted for the same.
https://bitbucket.org/lorainelab/protannot/pull-requests/12/igbf-937-fix-interproscan-and-properties/diff
Prof. [~aloraine], could you please merge it into the master?

Merged and ready for testing.

Tested this ticket. Working as expected. Moving to closed.