Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-963

Use native file chooser in ProtAnnot

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Sprint:
      Sprint 29

      Description

      Test on Ubuntu

        Attachments

          Activity

          jeckstein John Eckstein (Inactive) created issue -
          jeckstein John Eckstein (Inactive) made changes -
          Field Original Value New Value
          Assignee John Eckstein [ jeckstein ] Tarun Mall [ tmall ]
          tmall Tarun Mall (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tmall Tarun Mall (Inactive) made changes -
          Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
          jeckstein John Eckstein (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          jeckstein John Eckstein (Inactive) made changes -
          Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          Hide
          mason Mason Meyer (Inactive) added a comment - - edited

          Testing for this issue included:

          -Verifying that PA was using the native file chooser (tested on Windows, Mac, and Ubuntu).
          -Verifying that opening a file using the native file chooser was functioning as expected.
          -Verifying that the native file chooser was being used for saving a paxml file.

          Show
          mason Mason Meyer (Inactive) added a comment - - edited Testing for this issue included: -Verifying that PA was using the native file chooser (tested on Windows, Mac, and Ubuntu). -Verifying that opening a file using the native file chooser was functioning as expected. -Verifying that the native file chooser was being used for saving a paxml file.
          mason Mason Meyer (Inactive) made changes -
          Rank Ranked higher
          Hide
          mason Mason Meyer (Inactive) added a comment -

          I am reassigning this to Tarun because it seems that ProtAnnot is still not using the native file chooser in two places:

          1) Save Image...
          2) Save PAXML...

          Show
          mason Mason Meyer (Inactive) added a comment - I am reassigning this to Tarun because it seems that ProtAnnot is still not using the native file chooser in two places: 1) Save Image... 2) Save PAXML...
          mason Mason Meyer (Inactive) made changes -
          Assignee Mason Meyer [ mason ] Tarun Mall [ tmall ]
          mason Mason Meyer (Inactive) made changes -
          Status Testing In Progress [ 10003 ] Open [ 1 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tmall Tarun Mall (Inactive) made changes -
          Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
          tmall Tarun Mall (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 27 [ 35 ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 28 [ 36 ]
          dcnorris David Norris (Inactive) made changes -
          Rank Ranked higher
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          mason Mason Meyer (Inactive) made changes -
          Assignee Tarun Mall [ tmall ] Mason Meyer [ mason ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 28 [ 36 ]
          dcnorris David Norris (Inactive) made changes -
          Sprint Sprint 29 [ 37 ]
          dcnorris David Norris (Inactive) made changes -
          Rank Ranked higher
          mason Mason Meyer (Inactive) made changes -
          Status Testing In Progress [ 10003 ] Needs Testing [ 10002 ]
          mason Mason Meyer (Inactive) made changes -
          Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
          Hide
          mason Mason Meyer (Inactive) added a comment - - edited

          Re-testing for this issue included:

          -Verifying that PA was using the native file chooser (tested on Windows, Mac, and Ubuntu).
          -Verifying that opening a file using the native file chooser was functioning as expected (defaulting to user's home folder and remembering last saved location and name).
          -Verifying that the native file chooser was being used for saving a paxml file.
          -Verifying that the native file chooser was being used for ProtAnnot's Save PAXML feature.
          -Verifying that the native file chooser was being used for ProtAnnot's Save Image feature.

          Show
          mason Mason Meyer (Inactive) added a comment - - edited Re-testing for this issue included: -Verifying that PA was using the native file chooser (tested on Windows, Mac, and Ubuntu). -Verifying that opening a file using the native file chooser was functioning as expected (defaulting to user's home folder and remembering last saved location and name). -Verifying that the native file chooser was being used for saving a paxml file. -Verifying that the native file chooser was being used for ProtAnnot's Save PAXML feature. -Verifying that the native file chooser was being used for ProtAnnot's Save Image feature.
          Hide
          mason Mason Meyer (Inactive) added a comment -

          The above testing was performed and all checks passed except for one:

          ProtAnnot is not remembering the last saved filename when saving a PAXML file.

          Also, there is no default name set when saving PAXML files, instead the default filename is just ".paxml".

          I say we make the default filename "ProtAnnot.paxml" and then make sure that the file chooser remembers whatever name the user chooses to enter instead.

          I am reassigning this issue to John so that changes can be made.

          Show
          mason Mason Meyer (Inactive) added a comment - The above testing was performed and all checks passed except for one: ProtAnnot is not remembering the last saved filename when saving a PAXML file. Also, there is no default name set when saving PAXML files, instead the default filename is just ".paxml". I say we make the default filename "ProtAnnot.paxml" and then make sure that the file chooser remembers whatever name the user chooses to enter instead. I am reassigning this issue to John so that changes can be made.
          mason Mason Meyer (Inactive) made changes -
          Assignee Mason Meyer [ mason ] John Eckstein [ jeckstein ]
          mason Mason Meyer (Inactive) made changes -
          Status Testing In Progress [ 10003 ] Open [ 1 ]
          mason Mason Meyer (Inactive) made changes -
          Rank Ranked higher
          mason Mason Meyer (Inactive) made changes -
          Status Open [ 1 ] Testing In Progress [ 10003 ]
          Hide
          mason Mason Meyer (Inactive) added a comment -

          I just noticed that the issue in the above comment preventing me from closing this story has already been tracked in IGBF-1001. Everything else except for that issue passed testing, so this story will now be closed.

          Show
          mason Mason Meyer (Inactive) added a comment - I just noticed that the issue in the above comment preventing me from closing this story has already been tracked in IGBF-1001 . Everything else except for that issue passed testing, so this story will now be closed.
          mason Mason Meyer (Inactive) made changes -
          Assignee John Eckstein [ jeckstein ] Mason Meyer [ mason ]
          mason Mason Meyer (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Testing In Progress [ 10003 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Workflow Loraine Lab Workflow [ 16529 ] Fall 2019 Workflow Update [ 19680 ]
          ann.loraine Ann Loraine made changes -
          Workflow Fall 2019 Workflow Update [ 19680 ] Revised Fall 2019 Workflow Update [ 21799 ]

            People

            • Assignee:
              mason Mason Meyer (Inactive)
              Reporter:
              jeckstein John Eckstein (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: