Uploaded image for project: 'IGB Manual'
  1. IGB Manual
  2. MANUAL-34

fix deleting bookmark inconveniences

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Won't Fix
    • Labels:
      None
    • Environment:

      IGB 6.7 branch

      Description

      Two things:

      • When I try to delete a bookmark, a window appears asking me if I am sure I want to delete the bookmark. The window should have a checkbox that says: "Don't ask again" similar to what happens when a user tries to quit IGB. If the user clicks that option, then next time she tries to delete a bookmark, it should just happen without the window appearing.
      • If I select bookmark(s) or bookmark folder(s) and press the "Delete" key, then the selected bookmark(s) or folder(s) should be deleted.

        Attachments

          Activity

          ann.loraine Ann Loraine created issue -
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Description Two things:

          - When I try to delete a bookmark, a window appears asking me if I am sure I want to delete the bookmark. The window should have a checkbox that says: "Don't ask again" similar to what happens when a user tries to quit IGB. If the user clicks that option, then next time she tries to delete a bookmark, it should just happen without the window appearing.

          - If I select a bookmark or bookmark folders and click "Delete," the bookmark or folder should be deleted.
          Two things:

          - When I try to delete a bookmark, a window appears asking me if I am sure I want to delete the bookmark. The window should have a checkbox that says: "Don't ask again" similar to what happens when a user tries to quit IGB. If the user clicks that option, then next time she tries to delete a bookmark, it should just happen without the window appearing.

          - If I select bookmark(s) or bookmark folder(s) and press the "Delete" key, then the selected bookmark(s) or folder(s) should be deleted.
          david David Norris (Inactive) made changes -
          Assignee Nick Ren [ imnick ] David Norris [ david ]
          Hide
          david David Norris (Inactive) added a comment -

          Both features implemented in r9988

          Show
          david David Norris (Inactive) added a comment - Both features implemented in r9988
          david David Norris (Inactive) made changes -
          Assignee David Norris [ david ] Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Alyssa Gulledge [ alyssa ]
          Resolution Fixed [ 1 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Project IGB 6.7 [ 10040 ] Bug Repository [ 10030 ]
          Key IGBB-261 BUG-258
          darius darius made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Darius Bost [ darius ]
          Hide
          darius darius added a comment -

          Passed 7.0 (11840)

          Show
          darius darius added a comment - Passed 7.0 (11840)
          darius darius made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Darius Bost [ darius ]
          Resolution Fixed [ 1 ]
          richard Richard Linchangco (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Link This issue is blocked by BUG-641 [ BUG-641 ]
          Hide
          richard Richard Linchangco (Inactive) added a comment -

          V.13751, Mac, Java 1.7.0_09

          The confirmation window and checkbox function work fine.

          I am unclear as to what the "Delete" key phrase pertains to. The "Delete" button in the 'Bookmarks' section will remove any number of selected bookmarks. Selecting bookmarks and pressing the "delete" key on the computer keyboard will not delete the bookmarks. I tried using command+delete to delete as well but this did not work.

          Please verify which is the "delete" key functionality in question here.

          Show
          richard Richard Linchangco (Inactive) added a comment - V.13751, Mac, Java 1.7.0_09 The confirmation window and checkbox function work fine. I am unclear as to what the "Delete" key phrase pertains to. The "Delete" button in the 'Bookmarks' section will remove any number of selected bookmarks. Selecting bookmarks and pressing the "delete" key on the computer keyboard will not delete the bookmarks. I tried using command+delete to delete as well but this did not work. Please verify which is the "delete" key functionality in question here.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Alyssa Gulledge [ alyssa ]
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment -

          The actual "delete" key on the keyboard... and it is working fine for me - but I am still in "old" java. Please recheck on a fresh IGB and see if the delete key works. Then try deleting a bookmark with the broom symbol, and leave the pop-up window withOUT the check mark, then re-try using the delete key on the keyboard. The again, with broom and set pop-up to 'do not ask" and try the key again.

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - The actual "delete" key on the keyboard... and it is working fine for me - but I am still in "old" java. Please recheck on a fresh IGB and see if the delete key works. Then try deleting a bookmark with the broom symbol, and leave the pop-up window withOUT the check mark, then re-try using the delete key on the keyboard. The again, with broom and set pop-up to 'do not ask" and try the key again.
          alyssa Alyssa Gulledge (Inactive) made changes -
          Assignee Alyssa Gulledge [ alyssa ] Richard Linchangco [ richard ]
          Hide
          richard Richard Linchangco (Inactive) added a comment - - edited

          V.13758, Mac, Java 1.7.0_09

          Using the 'Delete' key that is not part of the QWERTY keyboard WILL NOT delete bookmarks.

          Using the 'Delete' key that is grouped with the 'fn', 'home', 'page up', etc. keys WILL delete the bookmarks.

          It would be expected that BOTH 'Delete' keys would serve the same function, especially for users using a keyboard that DO NOT have the second 'Delete' key, like most laptop users.

          I DID test this on my laptop keyboard, with the external USB keyboard disconnected, and the 'Delete' key does not work, even in combination with the command key.

          Perhaps linking the QWERTY 'Delete' key with command (command+delete) as a keystroke would work as well.

          Show
          richard Richard Linchangco (Inactive) added a comment - - edited V.13758, Mac, Java 1.7.0_09 Using the 'Delete' key that is not part of the QWERTY keyboard WILL NOT delete bookmarks. Using the 'Delete' key that is grouped with the 'fn', 'home', 'page up', etc. keys WILL delete the bookmarks. It would be expected that BOTH 'Delete' keys would serve the same function, especially for users using a keyboard that DO NOT have the second 'Delete' key, like most laptop users . I DID test this on my laptop keyboard, with the external USB keyboard disconnected, and the 'Delete' key does not work, even in combination with the command key. Perhaps linking the QWERTY 'Delete' key with command (command+delete) as a keystroke would work as well.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Richard Linchangco [ richard ] Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Assignee Alyssa Gulledge [ alyssa ] Hiral Vora [ hiralv ]
          hiralv Hiral Vora (Inactive) made changes -
          Assignee Hiral Vora [ hiralv ] Fuquan Wang [ fwang4 ]
          Hide
          fwang4 Fuquan Wang (Inactive) added a comment -

          The 'DELETE' key already works for bookmark deletion, nothing changed

          Fixed in 13775:

          1. Any combinations for 'DELETE' will not delete bookmark
          2. This change also applies to 'ENTER' for loading a bookmark

          Be sure the bookmark item is selected & focused when testing 'DELETE' and 'ENTER'

          Show
          fwang4 Fuquan Wang (Inactive) added a comment - The 'DELETE' key already works for bookmark deletion, nothing changed Fixed in 13775: 1. Any combinations for 'DELETE' will not delete bookmark 2. This change also applies to 'ENTER' for loading a bookmark Be sure the bookmark item is selected & focused when testing 'DELETE' and 'ENTER'
          fwang4 Fuquan Wang (Inactive) made changes -
          Assignee Fuquan Wang [ fwang4 ] Richard Linchangco [ richard ]
          Hide
          richard Richard Linchangco (Inactive) added a comment -

          V.13780, Mac, Java 1.7.0_10

          When testing, removed computer from any external screen, mouse, and keyboard.
          Care was taken to ensure a bookmark item as selected & focused when testing.

          1. 'ENTER' works in the bookmark section without issue

          • When'ENTER' is hit, the selected bookmark is loaded

          2. 'DELETE' still does not work on my MacBook Pro with Java 1.7.0_10. I'm not sure as to why this is happening. My delete key works in all other functions I've tested it with.

          Show
          richard Richard Linchangco (Inactive) added a comment - V.13780, Mac, Java 1.7.0_10 When testing, removed computer from any external screen, mouse, and keyboard. Care was taken to ensure a bookmark item as selected & focused when testing. 1. 'ENTER' works in the bookmark section without issue When'ENTER' is hit, the selected bookmark is loaded 2. 'DELETE' still does not work on my MacBook Pro with Java 1.7.0_10. I'm not sure as to why this is happening. My delete key works in all other functions I've tested it with.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Richard Linchangco [ richard ] Fuquan Wang [ fwang4 ]
          Hide
          fwang4 Fuquan Wang (Inactive) added a comment -

          I made a special revision 13782 to debug this issue.

          Please start IGB make sure the revision number is after 13782, then go to bookmark tab
          Select on bookmark and press 'Delete'
          Open the console and post the line looks like "Current keyset size: 0 key pressed char:  code: 12"

          Show
          fwang4 Fuquan Wang (Inactive) added a comment - I made a special revision 13782 to debug this issue. Please start IGB make sure the revision number is after 13782, then go to bookmark tab Select on bookmark and press 'Delete' Open the console and post the line looks like "Current keyset size: 0 key pressed char:  code: 12"
          fwang4 Fuquan Wang (Inactive) made changes -
          Assignee Fuquan Wang [ fwang4 ] Richard Linchangco [ richard ]
          Hide
          richard Richard Linchangco (Inactive) added a comment -

          Tested with laptop without keyboard attached and with. Both produced the line:

          Current keyset size: 0 key pressed char:  code: 8

          when pressing the 'Delete' key on the keyboard.

          Show
          richard Richard Linchangco (Inactive) added a comment - Tested with laptop without keyboard attached and with. Both produced the line: Current keyset size: 0 key pressed char:  code: 8 when pressing the 'Delete' key on the keyboard.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Richard Linchangco [ richard ] Fuquan Wang [ fwang4 ]
          Hide
          fwang4 Fuquan Wang (Inactive) added a comment -

          The key code 8 indicates you pressed 'BACKSPACE', however the key 'DELETE' is assigned to be the shortcut for this action.

          I am thinking that is a Mac keyboard trick when both 'BACKSPACE' and 'DELETE' are marked as 'delete' in an Apple keyboard, but the 'DELETE' is with an additional icon looks like 'x'.

          Show
          fwang4 Fuquan Wang (Inactive) added a comment - The key code 8 indicates you pressed 'BACKSPACE', however the key 'DELETE' is assigned to be the shortcut for this action. I am thinking that is a Mac keyboard trick when both 'BACKSPACE' and 'DELETE' are marked as 'delete' in an Apple keyboard, but the 'DELETE' is with an additional icon looks like 'x'.
          fwang4 Fuquan Wang (Inactive) made changes -
          Assignee Fuquan Wang [ fwang4 ] Richard Linchangco [ richard ]
          Hide
          richard Richard Linchangco (Inactive) added a comment -

          On a Mac keyboard (not a MacBook laptop) there are two deletes, as you've stated.
          On a MacBook laptop, only one 'Delete' exists which is the 'Backspace' key. Does this mean that the 'Delete' key option is not available to users operating IGB from laptops?

          That is fine if that is the case but it should be noted in the manual.

          Show
          richard Richard Linchangco (Inactive) added a comment - On a Mac keyboard (not a MacBook laptop) there are two deletes, as you've stated. On a MacBook laptop, only one 'Delete' exists which is the 'Backspace' key. Does this mean that the 'Delete' key option is not available to users operating IGB from laptops? That is fine if that is the case but it should be noted in the manual.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Richard Linchangco [ richard ] Fuquan Wang [ fwang4 ]
          Hide
          fwang4 Fuquan Wang (Inactive) added a comment -

          I think that only happens on Macbook as it is actually a 'backspace' rather than 'delete'

          Show
          fwang4 Fuquan Wang (Inactive) added a comment - I think that only happens on Macbook as it is actually a 'backspace' rather than 'delete'
          fwang4 Fuquan Wang (Inactive) made changes -
          Assignee Fuquan Wang [ fwang4 ] Richard Linchangco [ richard ]
          Hide
          richard Richard Linchangco (Inactive) added a comment -

          Please make a note of this in the MANUAL for IGB.

          Otherwise, this bug Passed V.13785, Mac, Java 1.7.0_10

          "Do not show this message again." function works, disabling deletion confirmation pop-ups for later deletions in the bookmarks section.

          'Delete' key and 'Enter' key on keyboards delete selected item(s) and load selected item(s), respectively. Apple laptops are an exception to the 'Delete' key functionality.

          Show
          richard Richard Linchangco (Inactive) added a comment - Please make a note of this in the MANUAL for IGB. Otherwise, this bug Passed V.13785, Mac, Java 1.7.0_10 "Do not show this message again." function works, disabling deletion confirmation pop-ups for later deletions in the bookmarks section. 'Delete' key and 'Enter' key on keyboards delete selected item(s) and load selected item(s), respectively. Apple laptops are an exception to the 'Delete' key functionality.
          richard Richard Linchangco (Inactive) made changes -
          Assignee Richard Linchangco [ richard ] Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Project Bug Repository [ 10030 ] IGB Manual [ 10031 ]
          Key BUG-258 MANUAL-34
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Link This issue is blocked by BUG-641 [ BUG-641 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Alyssa Gulledge [ alyssa ]
          Resolution Won't Fix [ 2 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: