Details
-
Type:
Task
-
Status: Testing To-Do (View Workflow)
-
Priority:
Major
-
Resolution: Unresolved
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 7 : 11 Nov to 22 Nov
Description
IGB App's must have Bundle-Version string that conforms to the following pattern:
MAJOR.MINOR.MICRO
where major is either 0 or a positive integer containing digits through 9, but not starting with 0.
Legal values include (for example):
- 100.1.0
- 0.1.10
- 0.0.1
- 0.0.0
- 10.1.900
Illegal values include (for example):
- 001.0.0
- 1.1.1-SNAPSHOT
- 1.1.1.SNAPSHOT
- 1.1.1.1
For this task, create and test bundles that use the above examples as Bundle-Version strings. Try uploading these to an App Store instance and make note of the behavior.
Background: When an user uploads an App, App Store extracts the MANIFEST.MF file from the App and determines the Bundle-Version from that. It uses a regular expression to extract the necessary version information.
Regexes are notoriously tricky and require deep understanding of their weird and complex syntax. We need to double-check that our understanding of the regex being used and how it is working.
See linked tickets.
This would be a super good place to introduce some unit tests into the project. I'm just sayin.
Attachments
Issue Links
- is blocked by
-
IGBF-2146 Fix: Can not submit any App
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
We are not allowing it for Apps mainly because there's no way we can identify the highest version if people include these.
Can you edit the regex to only accept M.N.O where M, N, O are non-negative integers.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
I did not try out the regex, but it looks fine. I think it is OK to submit a PR.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Noor Zahara [ noor91zahara ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Merged but not yet deployed to dev-appstore-2
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed to dev-appstore-2
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested the ticket. Working as expected. Moving to closed.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Shamika Gajanan Kulkarni can you describe briefly what you did to test the functionality?
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Prof. [~aloraine] Yes. I tried updating the pom.xml file to change the version names to different formats, for example, M.N.O.P, M.N.O.-snapshot, M.N.O-SNAPSHOT, 01.0.2, 100.0.1, etc. and I was allowed to release only those apps for which the versions were proper legal values. In the rest of the cases, I got an error message saying 'Bundle version is incorrect. Please use semantic versioning'.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
| Epic Link | IGBF-1388 [ 17463 ] |
| Epic Link | REL-5 [ 18178 ] |
1.1.1-SNAPSHOT is a valid version as per https://semver.org/.