Uploaded image for project: 'IGB 7.0'
  1. IGB 7.0
  2. IGBC-1003

CONTROL-SHIFT-click to deselect doesn't work unless you can click the parent (parent must be visible)

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      In IGB, if you select multiple items and then CONTROL-SHIFT-CLICK one of the selected items, the item you clicked is supposed to be de-selected and the other items currently selected remain selected.
      However, this feature appears to be broken. Now, if you want to deselect an item, you have to click on its parent, which is possible only if the item's parent glyph is visible.
      In other words, if the item is a single span feature (covering the "parent") then it is impossible to de-select it w/o also deselecting everything else.
      In IGB 6.7, it was possible to deselect any item using SHIFT-CONTROL-click. Can we revert back to the IGB 6.7 behavior?

      I propose that:
      If user clicks an item while pressing SHIFT-CONTROL, the item and its parent should be deselected. If the item is not currently selected, nothing should happen.

        Attachments

          Activity

          ann.loraine Ann Loraine created issue -
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment -

          Actually - here is the bug I see. Load up a bam file. Select by dragging over a few reads which do NOT have gaps. Us SHIFT + click to add a few more reads. Now use CONTROL + SHIFT + click to deselect the added reads - they deselect fine. Try deselecting reads from the original 'drag' and these will NOT deselect. This is NOT a problem for reads which contain a gap, if you deselect on the gap. So it is the 'drag selected, ungapped' reads that are at issue.

          On a reference gene track, EST, etc. the select and deselct works fine. This seems to affect only the .bam reads

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - Actually - here is the bug I see. Load up a bam file. Select by dragging over a few reads which do NOT have gaps. Us SHIFT + click to add a few more reads. Now use CONTROL + SHIFT + click to deselect the added reads - they deselect fine. Try deselecting reads from the original 'drag' and these will NOT deselect. This is NOT a problem for reads which contain a gap, if you deselect on the gap. So it is the 'drag selected, ungapped' reads that are at issue. On a reference gene track, EST, etc. the select and deselct works fine. This seems to affect only the .bam reads
          alyssa Alyssa Gulledge (Inactive) made changes -
          Field Original Value New Value
          Comment [ Please provide a specific USE CASE please. Currently, I have tried this feature on a .bam file, and can select and deselect individual reads while a group was selected. I cannot reproduce the error you see. Could this be a Java update issue? ]
          Hide
          hiralv Hiral Vora (Inactive) added a comment -

          Fixed in r14269.

          Show
          hiralv Hiral Vora (Inactive) added a comment - Fixed in r14269.
          hiralv Hiral Vora (Inactive) made changes -
          Assignee Hiral Vora [ hiralv ] Alyssa Gulledge [ alyssa ]
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment -

          Tested drag selected as well as shift+click selected - they deselect fine. Tested "solid" reads as well as gapped reads, also work fine.

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - Tested drag selected as well as shift+click selected - they deselect fine. Tested "solid" reads as well as gapped reads, also work fine.
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Alyssa Gulledge [ alyssa ]
          Resolution Fixed [ 1 ]
          Hide
          hiralv Hiral Vora (Inactive) added a comment -

          Fixed for v7.0 on r14334.

          Show
          hiralv Hiral Vora (Inactive) added a comment - Fixed for v7.0 on r14334.
          hiralv Hiral Vora (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Alyssa Gulledge [ alyssa ]
          Resolution Fixed [ 1 ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment -

          The bug is back it seems. If you DRAG select reads, you can NOT deselect them by SHIFT + CONTROL + click.

          Also, If you use SHIFT + CONTROL + click on a read not already selected, it will select... so it is toggling selected and deselected.

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - The bug is back it seems. If you DRAG select reads, you can NOT deselect them by SHIFT + CONTROL + click. Also, If you use SHIFT + CONTROL + click on a read not already selected, it will select... so it is toggling selected and deselected.
          alyssa Alyssa Gulledge (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Hiral Vora [ hiralv ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Comment [ tested on branch and passes ]
          Hide
          hiralv Hiral Vora (Inactive) added a comment -

          Fixed in r14359.

          Please test all possible way of selection. Also test that edge matching is working.

          Show
          hiralv Hiral Vora (Inactive) added a comment - Fixed in r14359. Please test all possible way of selection. Also test that edge matching is working.
          hiralv Hiral Vora (Inactive) made changes -
          Assignee Hiral Vora [ hiralv ] Alyssa Gulledge [ alyssa ]
          alyssa Alyssa Gulledge (Inactive) made changes -
          Priority Blocker [ 1 ] Major [ 3 ]
          Hide
          alyssa Alyssa Gulledge (Inactive) added a comment -

          -dragging works from all directions
          -SHIFT-click adds items
          -SHIFT+CONTROL+click will deselect items from either selection method

          -SHIFT+CONTROL+click will ALSO select unselected items!

          -edge-match works appropriately; color change works; show/hide works

          Show
          alyssa Alyssa Gulledge (Inactive) added a comment - -dragging works from all directions -SHIFT-click adds items -SHIFT+CONTROL+click will deselect items from either selection method -SHIFT+CONTROL+click will ALSO select unselected items! -edge-match works appropriately; color change works; show/hide works
          alyssa Alyssa Gulledge (Inactive) made changes -
          Assignee Alyssa Gulledge [ alyssa ] Hiral Vora [ hiralv ]
          hiralv Hiral Vora (Inactive) made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Hiral Vora [ hiralv ]
          Resolution Fixed [ 1 ]
          hiralv Hiral Vora (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: