Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1080

Convert IGB File Choosers to native via the JavaFX widgets

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      We should convert the file choosers in IGB to native file choosers via the JavaFX widgets.

      Below is a list of places where the file chooser appears in IGB. All of the following places should be converted to the native file chooser:

      1. Open File… (under File Menu)
      2. Open Genome from File…(under File Menu)
      3. Save Image…(under File Menu)
      ***4. Load/Save Session (under File Menu) – Currently not using Native File Chooser
      ***5. Configure Weblinks, Import/Export (under Tools Menu) – Currently not using Native File Chooser
      ***6. Import/Export Bookmarks…(under Bookmarks Menu) – Currently not using Native File Chooser
      7. Add/Edit Data Source, Choose local folder (in Data Sources tab of IGB Preferences)
      ***8. Personal Synonyms (in Data Sources tab of IGB Preferences) – Currently not using Native File Chooser
      ***9. Add... [App Repository] (in App Repositories tab of IGB Preferences) – Currently not using Native File Chooser
      10. Save PAXML File… (in ProtAnnot file menu)

      It may be helpful to refer to the release documentation for file choosers to make sure the file choosers are meeting their expected guidelines:
      https://wiki.transvar.org/display/ITD/FileChooser

        Attachments

          Activity

          Hide
          dfreese Daniella Freese (Inactive) added a comment - - edited

          We worked on converting the file/directory to javaFX file choosers.
          the list of places that were converted:
          4. Load/Save Session (under File Menu) (file)
          5. Configure Weblinks, Import/Export (under tools Menu) (file)
          6. Import/Export BookMarks (file)
          7. Add Data Sources (directory)
          8. Personal Synonyms (file)

          Show
          dfreese Daniella Freese (Inactive) added a comment - - edited We worked on converting the file/directory to javaFX file choosers. the list of places that were converted: 4. Load/Save Session (under File Menu) (file) 5. Configure Weblinks, Import/Export (under tools Menu) (file) 6. Import/Export BookMarks (file) 7. Add Data Sources (directory) 8. Personal Synonyms (file)
          Hide
          mason Mason Meyer (Inactive) added a comment - - edited

          Below are a list of things that still need to be fixed after a first round of testing:

          1) File Choosers with File Filters are not displaying files with the proper extension.

          2) I am not seeing the new JavaFX file chooser in a few places: Personal Synonyms, Add App Repoistory (Choose Local Folder...)

          3) The Add/Edit Data Sources feature still does not allow a directory to be selected, so right now I cannot add a Local Quickload folder. Change this so that it allows a user to choose a directory.

          4) The last used filename and directory need to be remembered by that file chooser (if IGB Preferences are Reset to Default under the Other Options tab in IGB Preferences then the File Choosers should open to the user's Home folder.

          5) No popup appears before replacing a file with the same name (in these locations: Save Session, Export Weblinks, Export Bookmark)

          6) The extension (that matches the file type being saved) should be appended to the end of the filename within the File Name textbox (For example, if you are saving an HTML file called "Bookmark", the file chooser should display "Bookmark.html" in the File Name textbox.) For areas where a file can be saved as different formats (like Exporting Bookmarks, where you can save as an HTML or TXT file), the extension that gets appended to the name should come from the format selected in the "Save as Type" drop-down menu. If a user changes the dropdown menu to select a different format, the filename should update to include the extension that matches the drop-down menu.

          I will now reassign the story to Dani and add it back to the top of the To-Do column of the Agile Board.

          Show
          mason Mason Meyer (Inactive) added a comment - - edited Below are a list of things that still need to be fixed after a first round of testing: 1) File Choosers with File Filters are not displaying files with the proper extension. 2) I am not seeing the new JavaFX file chooser in a few places: Personal Synonyms, Add App Repoistory (Choose Local Folder...) 3) The Add/Edit Data Sources feature still does not allow a directory to be selected, so right now I cannot add a Local Quickload folder. Change this so that it allows a user to choose a directory. 4) The last used filename and directory need to be remembered by that file chooser (if IGB Preferences are Reset to Default under the Other Options tab in IGB Preferences then the File Choosers should open to the user's Home folder. 5) No popup appears before replacing a file with the same name (in these locations: Save Session, Export Weblinks, Export Bookmark) 6) The extension (that matches the file type being saved) should be appended to the end of the filename within the File Name textbox (For example, if you are saving an HTML file called "Bookmark", the file chooser should display "Bookmark.html" in the File Name textbox.) For areas where a file can be saved as different formats (like Exporting Bookmarks, where you can save as an HTML or TXT file), the extension that gets appended to the name should come from the format selected in the "Save as Type" drop-down menu. If a user changes the dropdown menu to select a different format, the filename should update to include the extension that matches the drop-down menu. I will now reassign the story to Dani and add it back to the top of the To-Do column of the Agile Board.
          Hide
          dfreese Daniella Freese (Inactive) added a comment -

          We fixed some of the bugs reported by Mason, one major bug cannot be fixed but we have made a work around.

          The main problem with the fileChooser in Linux and Mac OS is the we cannot change the extension of the file name if the user selects a different extension. We can append on valid default extension when the filechooser window is first opened but cannot make changes to the extension afterwards. Currently, we have it set up so :

          1) if the user types in a valid extension, another extension will not be appended

          2) if the file name does not have an extension appended it, the extension selected in the filechooser menu will be appended to the filename when the file is saved. If this is the case, then we cannot detect if the file will override an existing file in the same directory.

          Show
          dfreese Daniella Freese (Inactive) added a comment - We fixed some of the bugs reported by Mason, one major bug cannot be fixed but we have made a work around. The main problem with the fileChooser in Linux and Mac OS is the we cannot change the extension of the file name if the user selects a different extension. We can append on valid default extension when the filechooser window is first opened but cannot make changes to the extension afterwards. Currently, we have it set up so : 1) if the user types in a valid extension, another extension will not be appended 2) if the file name does not have an extension appended it, the extension selected in the filechooser menu will be appended to the filename when the file is saved. If this is the case, then we cannot detect if the file will override an existing file in the same directory.
          Hide
          mason Mason Meyer (Inactive) added a comment -

          Re-tested this issue after additional changes were made. Followed the release testing guide for file choosers here:
          https://wiki.transvar.org/display/ITD/FileChooser

          I also tested these non-general functions:

          • Popups appears before overwriting files in all cases, even when user has not entered file extension when saving file.
          • If no file extension is entered, a file extension is used from the drop-down menu in the file chooser.
          • File choosers with filters are displaying proper files.

          The testing has been performed above for all file chooser locations in IGB (see attached screenshot).

          Since this issue is resolved it will now be closed.

          Show
          mason Mason Meyer (Inactive) added a comment - Re-tested this issue after additional changes were made. Followed the release testing guide for file choosers here: https://wiki.transvar.org/display/ITD/FileChooser I also tested these non-general functions: Popups appears before overwriting files in all cases, even when user has not entered file extension when saving file. If no file extension is entered, a file extension is used from the drop-down menu in the file chooser. File choosers with filters are displaying proper files. The testing has been performed above for all file chooser locations in IGB (see attached screenshot). Since this issue is resolved it will now be closed.
          Hide
          mason Mason Meyer (Inactive) added a comment - - edited

          I noticed that the button that opens the file choosers can be clicked multiple times and what happens is that the file chooser opens, but if the user clicks cancel in the file chooser, the file chooser will reopen the number of times that the user clicked the button to open the file chooser initially.

          I can confirm that this happens on Windows AND Mac.

          This should be fixed before this issue is closed.

          Show
          mason Mason Meyer (Inactive) added a comment - - edited I noticed that the button that opens the file choosers can be clicked multiple times and what happens is that the file chooser opens, but if the user clicks cancel in the file chooser, the file chooser will reopen the number of times that the user clicked the button to open the file chooser initially. I can confirm that this happens on Windows AND Mac. This should be fixed before this issue is closed.
          Hide
          mason Mason Meyer (Inactive) added a comment -

          Since it is unclear if these changes will make it into the IGB 9.0.0, I am marking this issue as closed for now.

          Show
          mason Mason Meyer (Inactive) added a comment - Since it is unclear if these changes will make it into the IGB 9.0.0, I am marking this issue as closed for now.

            People

            • Assignee:
              dfreese Daniella Freese (Inactive)
              Reporter:
              mason Mason Meyer (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: