Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1151

Save Session - Convert file chooser to the operating system's Native File Chooser

        Details

        • Story Points:
          1
        • Sprint:
          Fall 2017

          Description

          This issue is similar to IGBF-1140
          Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the IGB Save Sessions.
          IGB File->Save Sessions
          We want OS native file chooser to be displayed instead of Java Swing style window.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1140 Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                akadam3 Ashwini Kadam (Inactive) created issue -
                akadam3 Ashwini Kadam (Inactive) made changes -
                Field Original Value New Value
                Link This issue relates to IGBF-1140 [ IGBF-1140 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Description This issue is similar to IGBF-1140
                Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the Data Sources tab of IGB Save Sessions.
                IGB File->Save Sessions
                We want OS native file chooser to be displayed instead of Java Swing style window.                 		This issue is similar to IGBF-1140
                Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the IGB Save Sessions.
                IGB File->Save Sessions
                We want OS native file chooser to be displayed instead of Java Swing style window.
                akadam3 Ashwini Kadam (Inactive) made changes -
                Summary Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser Save Session - Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser
                akadam3 Ashwini Kadam (Inactive) made changes -
                Assignee Ashwini Kadam [ akadam3 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                Issue is related to IGBF-1140.
                Changed Save Session Dialog Style to OS Native File Chooser using FileChooser Utils.
                I have tested this on Windows machine. It saves session in valid format and user can open this saved session using Load Session option.

                This fix is not supposed to change Window style for Mac because we have different file dialog code for Mac machines.
                If we have to change that window as well, then different issue should be created for that.

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - Issue is related to IGBF-1140 . Changed Save Session Dialog Style to OS Native File Chooser using FileChooser Utils. I have tested this on Windows machine. It saves session in valid format and user can open this saved session using Load Session option. This fix is not supposed to change Window style for Mac because we have different file dialog code for Mac machines. If we have to change that window as well, then different issue should be created for that.
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Assignee Ashwini Kadam [ akadam3 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] Open [ 1 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Assignee Ashwini Kadam [ akadam3 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status In Progress [ 3 ] Open [ 1 ]
                mason Mason Meyer (Inactive) made changes -
                Summary Save Session - Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser Save Session - Convert file chooser to the operating system's Native File Chooser
                mason Mason Meyer (Inactive) made changes -
                Description This issue is similar to IGBF-1140
                Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the IGB Save Sessions.
                IGB File->Save Sessions
                We want OS native file chooser to be displayed instead of Java Swing style window.                 		This issue is similar to IGBF-1140
                Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the IGB Save Sessions.
                IGB File->Save Sessions
                We want OS native file chooser to be displayed instead of Java Swing style window.
                Hide
                Permalink
                mason Mason Meyer (Inactive) added a comment -

                I am changing the title of this story and some of the description because there is not a "Choose Local Folder" option for this feature, that only applies to stories IGBF-1140 and IGBF-1157. I am doing this to avoid confusion in the future.

                Show
                mason Mason Meyer (Inactive) added a comment - I am changing the title of this story and some of the description because there is not a "Choose Local Folder" option for this feature, that only applies to stories IGBF-1140 and IGBF-1157 . I am doing this to avoid confusion in the future.
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Assignee Ashwini Kadam [ akadam3 ]
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                Fix the error and tested in Windows.
                Need testing in Linux. Fix does not affect Mac Users as we already have Native OS file chooser for MacOS.
                Please find committed fix at:
                https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/2e9ea21b2dbd52288939cb406354e969e4e661f8?at=IGBF-1151

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - Fix the error and tested in Windows. Need testing in Linux. Fix does not affect Mac Users as we already have Native OS file chooser for MacOS. Please find committed fix at: https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/2e9ea21b2dbd52288939cb406354e969e4e661f8?at=IGBF-1151
                sneha Sneha Ramesh Watharkar (Inactive) made changes -
                Attachment igbf1151_linux.png [ 14009 ]
                Hide
                Permalink
                sneha Sneha Ramesh Watharkar (Inactive) added a comment -

                1st level review -1

                Fix works in Linux, fixed code is searchable and readable. Uploaded a screen shot.

                Show
                sneha Sneha Ramesh Watharkar (Inactive) added a comment - 1st level review -1 Fix works in Linux, fixed code is searchable and readable. Uploaded a screen shot.
                ieclabau Ivory Blakley (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
                ieclabau Ivory Blakley (Inactive) made changes -
                Assignee Ivory Clabaugh [ ieclabau ]
                Hide
                Permalink
                ieclabau Ivory Blakley (Inactive) added a comment -

                1st level review -2

                On mac, no noticeable change, as expected. IGB is able to save a load a session as it should.

                I'm reassigning to Ashwini to do a pull request.

                Show
                ieclabau Ivory Blakley (Inactive) added a comment - 1st level review -2 On mac, no noticeable change, as expected. IGB is able to save a load a session as it should. I'm reassigning to Ashwini to do a pull request.
                ieclabau Ivory Blakley (Inactive) made changes -
                Assignee Ivory Clabaugh [ ieclabau ] Ashwini Kadam [ akadam3 ]
                ieclabau Ivory Blakley (Inactive) made changes -
                Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                akadam3 Ashwini Kadam (Inactive) made changes -
                Assignee Ashwini Kadam [ akadam3 ]
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                ann.loraine Ann Loraine made changes -
                Status Reviewing Pull Request [ 10303 ] Needs Testing [ 10002 ]
                Hide
                Permalink
                mason Mason Meyer (Inactive) added a comment -

                After testing this story I can confirm that the Save Session file chooser within has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Saved Sessions are being opened properly in IGB and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.

                Show
                mason Mason Meyer (Inactive) added a comment - After testing this story I can confirm that the Save Session file chooser within has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Saved Sessions are being opened properly in IGB and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.
                mason Mason Meyer (Inactive) made changes -
                Resolution Done [ 10000 ]
                Status Needs Testing [ 10002 ] Closed [ 6 ]
                ieclabau Ivory Blakley (Inactive) made changes -
                Fix Version/s 9.0.1 Minor Release [ 10500 ]
                ann.loraine Ann Loraine made changes -
                Workflow Loraine Lab Workflow [ 17793 ] Fall 2019 Workflow Update [ 19798 ]
                ann.loraine Ann Loraine made changes -
                Workflow Fall 2019 Workflow Update [ 19798 ] Revised Fall 2019 Workflow Update [ 21917 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    akadam3 Ashwini Kadam (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: