Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1157

Plugin Repository - Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser

        Details

        • Story Points:
          1
        • Sprint:
          Fall 2017

          Description

          This issue is similar to IGBF-1140
          Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the Preferences tab of IGB.
          IGB File->Preferences(or click on gear icon on IGB toolbar)>App Repositories>Add.. ->Choose Local folder
          It opens up a window to add plugin repositories.
          We want OS native file chooser to be displayed instead of Java Swing style window.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1140 Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                Fixed the issue, But it should not be submitted before IGBF-1140 is in master branch. Fix is dependent on new file added as part of solution for IGBF-1140.
                Testing should be done only on updated repository after IGBF-1140 is merged in master.
                Testing on Linux and MacOS is required.
                Expected Output: Local folder chooser dialog style should be change to Native OS style. Functionality should be intact and should allow user to choose any folder needed. (No file selection is allowed)

                Fix can be found at:
                https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/0109c9b8982258b75e5dbbfe6bd7574a43e0a58f?at=IGBF-1157

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - Fixed the issue, But it should not be submitted before IGBF-1140 is in master branch. Fix is dependent on new file added as part of solution for IGBF-1140 . Testing should be done only on updated repository after IGBF-1140 is merged in master. Testing on Linux and MacOS is required. Expected Output: Local folder chooser dialog style should be change to Native OS style. Functionality should be intact and should allow user to choose any folder needed. (No file selection is allowed) Fix can be found at: https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/0109c9b8982258b75e5dbbfe6bd7574a43e0a58f?at=IGBF-1157
                Hide
                Permalink
                sneha Sneha Ramesh Watharkar (Inactive) added a comment -

                Ashwini, now that IGBF-1140 is merged into master can you do a git rebase on this branch to complete it? That should merge the two without creating additional commits.

                Show
                sneha Sneha Ramesh Watharkar (Inactive) added a comment - Ashwini, now that IGBF-1140 is merged into master can you do a git rebase on this branch to complete it? That should merge the two without creating additional commits.
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                IGBF-1140 has been merged and closed long ago now.
                This issue could be tested safely on Mac as well as Linux. Fix is working fine on Windows.

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - IGBF-1140 has been merged and closed long ago now. This issue could be tested safely on Mac as well as Linux. Fix is working fine on Windows.
                Hide
                Permalink
                spatil26 Sanket Patil (Inactive) added a comment -

                Code looks fine to me. Fix is working on Linux OS.
                Only one trivial thing, Text on button is " Choose local folder", but when i click on the button the windows has title as "Choose Local Folder". Refer attached image. You can change .setTitle("Choose Local Folder") to .setTitle("Choose local folder")

                Show
                spatil26 Sanket Patil (Inactive) added a comment - Code looks fine to me. Fix is working on Linux OS. Only one trivial thing, Text on button is " Choose local folder", but when i click on the button the windows has title as "Choose Local Folder". Refer attached image. You can change .setTitle("Choose Local Folder") to .setTitle("Choose local folder")
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                Changed file chooser window title to 'Choose local folder' as suggested by Sanket in code review.

                As code review has been done, I am moving this directly to 'Ready for pull request' lane.

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - Changed file chooser window title to 'Choose local folder' as suggested by Sanket in code review. As code review has been done, I am moving this directly to 'Ready for pull request' lane.
                Hide
                Permalink
                akadam3 Ashwini Kadam (Inactive) added a comment -

                Submitted pull request

                Show
                akadam3 Ashwini Kadam (Inactive) added a comment - Submitted pull request
                Hide
                Permalink
                mason Mason Meyer (Inactive) added a comment -

                After testing this story I can confirm that the Plugin Repository "Choose Local Folder" file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. There seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.

                Show
                mason Mason Meyer (Inactive) added a comment - After testing this story I can confirm that the Plugin Repository "Choose Local Folder" file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. There seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    akadam3 Ashwini Kadam (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: