Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.1 Minor Release
-
Labels:None
-
Story Points:1
-
Sprint:Fall 2017
Description
This issue is similar to IGBF-1140
Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the Bookmarks tab of IGB.
IGB Bookmarks->Import Bookmarks
We want OS native file chooser to be displayed instead of Java Swing style window.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Summary | Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser | Import Bookmark-Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Ashwini Kadam [ akadam3 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Rank | Ranked lower |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Summary | Import Bookmark-Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser | Import Bookmark-Convert file chooser to the operating system's Native File Chooser |
| Description |
This issue is similar to Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the Bookmarks tab of IGB. IGB Bookmarks->Import Bookmarks We want OS native file chooser to be displayed instead of Java Swing style window. |
This issue is similar to Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the Bookmarks tab of IGB. IGB Bookmarks->Import Bookmarks We want OS native file chooser to be displayed instead of Java Swing style window. |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Fixed the issue.
I have tested UI change on windows machine. Import bookmark functionality is working as expected with new file chooser dialog.
Needs testing in Linux and Mac environment.
Fix for review purpose can be found on my fork:
https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/26d8cf5fa0cfb0bdee6d85827bf2df86476826c3?at=IGBF-1152
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ashwini Kadam [ akadam3 ] |
1st review - 1
Tested on Linux, import bookmark uses proper filechooser and functions normally. Exported a bookmark then imported it to test. Uploaded screenshot.
Is there a ticket for the export file chooser? I didn't see one, but I also didn't look very hard. Export bookmark is using swing chooser.
| Attachment | igbf1152_linux.png [ 14010 ] |
There is ticket for export functionality IGBF-1153.
I am currently working on it. It is a little more complicated than I thought and taking quite a lot of time.
| Assignee | Ivory Clabaugh [ ieclabau ] |
| Status | Needs 1st Level Review [ 10005 ] | In Progress [ 3 ] |
Ashwini, I have some questions about how to test this issue and related file chooser issues. See email for details. For now, I'm going to put this back in needs 1st level review.
--Ivory
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ivory Clabaugh [ ieclabau ] |
I believe I had conversation with Ivory about this issue and we did verify its functionality on MacOS.
As per my recollection, everything worked fine functionally. It is possible that this issue got overlooked and didn't get moved to next lane.
Just to be sure, Dr. Loraine may test it on MacOS.
Jenny has tested issue on Linux and it worked fine. I have done testing on Windows OS as well.
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Ashwini Kadam [ akadam3 ] |
I tested it again on Mac OS and it import functionality is workings expected.
IGB is able to import bookmarks saved in the format of 'html/htm/xhtml'. Import bookmark window UI is changed as expected.
Moving this issue to 'Ready for Pull Request' lane.
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Submitted Pull request
| Assignee | Ashwini Kadam [ akadam3 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Assignee | Mason Meyer [ mason ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
After testing this story I can confirm that the Import Bookmark file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Bookmarks of file types html, htm, and xhtml are imported properly in IGB using the Import Bookmarks feature and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 9.0.1 Minor Release [ 10500 ] |
| Workflow | Loraine Lab Workflow [ 17794 ] | Fall 2019 Workflow Update [ 19799 ] |
| Workflow | Fall 2019 Workflow Update [ 19799 ] | Revised Fall 2019 Workflow Update [ 21918 ] |
I am changing the title of this story and some of the description because there is not a "Choose Local Folder" option for this feature, that only applies to stories
IGBF-1140andIGBF-1157. I am doing this to avoid confusion in the future.