Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1152

Import Bookmark-Convert file chooser to the operating system's Native File Chooser

    Details

    • Story Points:
      1
    • Sprint:
      Fall 2017

      Description

      This issue is similar to IGBF-1140
      Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the Bookmarks tab of IGB.
      IGB Bookmarks->Import Bookmarks
      We want OS native file chooser to be displayed instead of Java Swing style window.

        Attachments

          Issue Links

            Activity

            akadam3 Ashwini Kadam (Inactive) created issue -
            akadam3 Ashwini Kadam (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to IGBF-1140 [ IGBF-1140 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Summary Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser Import Bookmark-Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser
            akadam3 Ashwini Kadam (Inactive) made changes -
            Assignee Ann Loraine [ aloraine ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Assignee Ashwini Kadam [ akadam3 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Rank Ranked lower
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            mason Mason Meyer (Inactive) made changes -
            Summary Import Bookmark-Convert "Choose Local Folder" file chooser to the operating system's Native File Chooser Import Bookmark-Convert file chooser to the operating system's Native File Chooser
            mason Mason Meyer (Inactive) made changes -
            Description This issue is similar to IGBF-1140
            Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the Bookmarks tab of IGB.
            IGB Bookmarks->Import Bookmarks
            We want OS native file chooser to be displayed instead of Java Swing style window.
            This issue is similar to IGBF-1140
            Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is under the Bookmarks tab of IGB.
            IGB Bookmarks->Import Bookmarks
            We want OS native file chooser to be displayed instead of Java Swing style window.
            Hide
            mason Mason Meyer (Inactive) added a comment -

            I am changing the title of this story and some of the description because there is not a "Choose Local Folder" option for this feature, that only applies to stories IGBF-1140 and IGBF-1157. I am doing this to avoid confusion in the future.

            Show
            mason Mason Meyer (Inactive) added a comment - I am changing the title of this story and some of the description because there is not a "Choose Local Folder" option for this feature, that only applies to stories IGBF-1140 and IGBF-1157 . I am doing this to avoid confusion in the future.
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            akadam3 Ashwini Kadam (Inactive) added a comment -

            Fixed the issue.
            I have tested UI change on windows machine. Import bookmark functionality is working as expected with new file chooser dialog.
            Needs testing in Linux and Mac environment.

            Fix for review purpose can be found on my fork:
            https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/26d8cf5fa0cfb0bdee6d85827bf2df86476826c3?at=IGBF-1152

            Show
            akadam3 Ashwini Kadam (Inactive) added a comment - Fixed the issue. I have tested UI change on windows machine. Import bookmark functionality is working as expected with new file chooser dialog. Needs testing in Linux and Mac environment. Fix for review purpose can be found on my fork: https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/26d8cf5fa0cfb0bdee6d85827bf2df86476826c3?at=IGBF-1152
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Assignee Ashwini Kadam [ akadam3 ]
            Hide
            sneha Sneha Ramesh Watharkar (Inactive) added a comment -

            1st review - 1

            Tested on Linux, import bookmark uses proper filechooser and functions normally. Exported a bookmark then imported it to test. Uploaded screenshot.

            Is there a ticket for the export file chooser? I didn't see one, but I also didn't look very hard. Export bookmark is using swing chooser.

            Show
            sneha Sneha Ramesh Watharkar (Inactive) added a comment - 1st review - 1 Tested on Linux, import bookmark uses proper filechooser and functions normally. Exported a bookmark then imported it to test. Uploaded screenshot. Is there a ticket for the export file chooser? I didn't see one, but I also didn't look very hard. Export bookmark is using swing chooser.
            sneha Sneha Ramesh Watharkar (Inactive) made changes -
            Attachment igbf1152_linux.png [ 14010 ]
            Hide
            akadam3 Ashwini Kadam (Inactive) added a comment -

            There is ticket for export functionality IGBF-1153.
            I am currently working on it. It is a little more complicated than I thought and taking quite a lot of time.

            Show
            akadam3 Ashwini Kadam (Inactive) added a comment - There is ticket for export functionality IGBF-1153 . I am currently working on it. It is a little more complicated than I thought and taking quite a lot of time.
            ieclabau Ivory Blakley (Inactive) made changes -
            Assignee Ivory Clabaugh [ ieclabau ]
            ieclabau Ivory Blakley (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] In Progress [ 3 ]
            Hide
            ieclabau Ivory Blakley (Inactive) added a comment -

            Ashwini, I have some questions about how to test this issue and related file chooser issues. See email for details. For now, I'm going to put this back in needs 1st level review.
            --Ivory

            Show
            ieclabau Ivory Blakley (Inactive) added a comment - Ashwini, I have some questions about how to test this issue and related file chooser issues. See email for details. For now, I'm going to put this back in needs 1st level review. --Ivory
            ieclabau Ivory Blakley (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ieclabau Ivory Blakley (Inactive) made changes -
            Assignee Ivory Clabaugh [ ieclabau ]
            Hide
            akadam3 Ashwini Kadam (Inactive) added a comment -

            I believe I had conversation with Ivory about this issue and we did verify its functionality on MacOS.
            As per my recollection, everything worked fine functionally. It is possible that this issue got overlooked and didn't get moved to next lane.
            Just to be sure, Dr. Loraine may test it on MacOS.
            Jenny has tested issue on Linux and it worked fine. I have done testing on Windows OS as well.

            Show
            akadam3 Ashwini Kadam (Inactive) added a comment - I believe I had conversation with Ivory about this issue and we did verify its functionality on MacOS. As per my recollection, everything worked fine functionally. It is possible that this issue got overlooked and didn't get moved to next lane. Just to be sure, Dr. Loraine may test it on MacOS. Jenny has tested issue on Linux and it worked fine. I have done testing on Windows OS as well.
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Assignee Ashwini Kadam [ akadam3 ]
            Hide
            akadam3 Ashwini Kadam (Inactive) added a comment -

            I tested it again on Mac OS and it import functionality is workings expected.
            IGB is able to import bookmarks saved in the format of 'html/htm/xhtml'. Import bookmark window UI is changed as expected.
            Moving this issue to 'Ready for Pull Request' lane.

            Show
            akadam3 Ashwini Kadam (Inactive) added a comment - I tested it again on Mac OS and it import functionality is workings expected. IGB is able to import bookmarks saved in the format of 'html/htm/xhtml'. Import bookmark window UI is changed as expected. Moving this issue to 'Ready for Pull Request' lane.
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
            akadam3 Ashwini Kadam (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Hide
            akadam3 Ashwini Kadam (Inactive) added a comment -

            Submitted Pull request

            Show
            akadam3 Ashwini Kadam (Inactive) added a comment - Submitted Pull request
            akadam3 Ashwini Kadam (Inactive) made changes -
            Assignee Ashwini Kadam [ akadam3 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ]
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            Hide
            mason Mason Meyer (Inactive) added a comment -

            After testing this story I can confirm that the Import Bookmark file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Bookmarks of file types html, htm, and xhtml are imported properly in IGB using the Import Bookmarks feature and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.

            Show
            mason Mason Meyer (Inactive) added a comment - After testing this story I can confirm that the Import Bookmark file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. Bookmarks of file types html, htm, and xhtml are imported properly in IGB using the Import Bookmarks feature and there seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.
            mason Mason Meyer (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Testing In Progress [ 10003 ] Closed [ 6 ]
            ieclabau Ivory Blakley (Inactive) made changes -
            Fix Version/s 9.0.1 Minor Release [ 10500 ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 17794 ] Fall 2019 Workflow Update [ 19799 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 19799 ] Revised Fall 2019 Workflow Update [ 21918 ]

              People

              • Assignee:
                mason Mason Meyer (Inactive)
                Reporter:
                akadam3 Ashwini Kadam (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: