Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.1 Minor Release
-
Labels:None
-
Story Points:1
-
Sprint:Fall 2017
Description
This issue is similar to IGBF-1140
Certain places in IGB use the operating system's native file chooser and some do not. One place that does not is the "Choose Local Folder" option under the Preferences tab of IGB.
IGB File->Preferences(or click on gear icon on IGB toolbar)>App Repositories>Add.. ->Choose Local folder
It opens up a window to add plugin repositories.
We want OS native file chooser to be displayed instead of Java Swing style window.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Assignee | Ashwini Kadam [ akadam3 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ashwini Kadam [ akadam3 ] |
Ashwini, now that IGBF-1140 is merged into master can you do a git rebase on this branch to complete it? That should merge the two without creating additional commits.
IGBF-1140 has been merged and closed long ago now.
This issue could be tested safely on Mac as well as Linux. Fix is working fine on Windows.
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Status | Reviewing [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Sanket Patil [ spatil26 ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Attachment | IGBF1157.jpg [ 14040 ] |
Code looks fine to me. Fix is working on Linux OS.
Only one trivial thing, Text on button is " Choose local folder", but when i click on the button the windows has title as "Choose Local Folder". Refer attached image. You can change .setTitle("Choose Local Folder") to .setTitle("Choose local folder")
| Assignee | Sanket Patil [ spatil26 ] | Ashwini Kadam [ akadam3 ] |
| Status | Reviewing [ 10301 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Changed file chooser window title to 'Choose local folder' as suggested by Sanket in code review.
As code review has been done, I am moving this directly to 'Ready for pull request' lane.
| Status | In Progress [ 3 ] | Ready for Pull Request [ 10304 ] |
Submitted pull request
| Assignee | Ashwini Kadam [ akadam3 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
After testing this story I can confirm that the Plugin Repository "Choose Local Folder" file chooser has been changed to the operating system's native file chooser. This has been tested on Mac and Windows and is functioning as expected. There seem to be no side effects resulting from this change. Since this issue is resolved it will now be closed.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 9.0.1 Minor Release [ 10500 ] |
| Workflow | Loraine Lab Workflow [ 17799 ] | Fall 2019 Workflow Update [ 19803 ] |
| Workflow | Fall 2019 Workflow Update [ 19803 ] | Revised Fall 2019 Workflow Update [ 21922 ] |
Fixed the issue, But it should not be submitted before
IGBF-1140is in master branch. Fix is dependent on new file added as part of solution forIGBF-1140.Testing should be done only on updated repository after
IGBF-1140is merged in master.Testing on Linux and MacOS is required.
Expected Output: Local folder chooser dialog style should be change to Native OS style. Functionality should be intact and should allow user to choose any folder needed. (No file selection is allowed)
Fix can be found at:
https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/0109c9b8982258b75e5dbbfe6bd7574a43e0a58f?at=IGBF-1157