Convert Tools->Configure Web Links ->Import to use OS native File Chooser

Fixed the issue.
Please refer to branch on my fork for code review:

https://bitbucket.org/ashwiniK27/integrated-genome-browser/commits/97aba34f0b1dc3dfa22efb9383b00f82f2a3351f?at=IGBF-1183

Needs testing on Linux and MacOS.

First level review:
Functionality seems working fine on MacOS. UI is changed as expected.

Tested on Linux, import option uses native file chooser. Code is labeled, easy to find, clear.

IGBF-1183 passed functional and code review.
Please issue pull request to master branch, team repository.

After testing this story I can confirm that the Tools menu's "Configure Web Links ->Import" file chooser has been changed to the operating system's native file chooser, but it seems that I am not able to open .JSON files on Windows, as expected. The file chooser does not even show my .json files in the Windows file chooser. This is happening on Windows only, it seems.

In the non-native file chooser (seen in 9.0.0), you can see and select the .JSON files on Windows.

I am moving this back to the To-Do column and re-assigning it to Ashwini to take a look. Please let me know if you have any questions about the issue.

Fixed the issue.
Commit for fix:
https://bitbucket.org/spatil26/integrated-genome-browser-sanket-patil/commits/358611ed5f3d7f33cd1fecf473fac0681c2a4ddc

Tested on windows and linux. Working as expected.
Need to test on mac.

This issue seems to be resolved and passes the review. The issue was tested on Mac and Windows and the Configure Web Links -->Import file chooser is now using the operating system's native file chooser. JSON files are visible in the file chooser for all operating systems and JSON files are imported into IGB appropriately. Since this issue seems to be resolved, I am re-assigning it to Sanket and moving it to the Ready For Pull Request column.

Thank you Mason.
Pull request submitted.

After testing, I can confirm that this issue is resolved. The issue was tested on Mac and Windows and the Configure Web Links -->Import file chooser is now using the operating system's native file chooser. JSON files are visible in the file chooser for all operating systems and JSON files are imported into IGB appropriately. Since there are no side effcets realted to this change and it is resolvd, it will now be closed.

When testing for the 9.0.1 release, we noted:

On mac and Windows, the Configure Weblinks Import (under Tools Menu) uses the swing finder, but export looks like the native finder.

So I am moving this back to the to do column.

Find out where this belongs in the workflow. (Done?)

I think I see what happened here....

Ashwini changed the import file chooser window to the native file chooser.
Her changes were tested and, after a minor correction, merged into master.

Deepti did a parallel change for the export window. I think Deepti was recovering code that Ashwini had written, and I think it involved copy/pasting some or all of the file. For some reason, I own the branch but Deepti is the author of the commit.
https://bitbucket.org/IvoryBlak/integrated-genome-browser/branch/IGBF-1184
In any case, it looks the like commit that changes the export window to the native file chooser also (accidentally) reverts part of the code that was changed to make the import window use the native file chooser.

One option is to remove the bad commit from master and rebase the code correctly and submit it again.
But I think our workflow strives to not changes any commits once they make it to the master branch (I think it makes for a re-basing hassle, or its just the flow we stick too). So our best option is to make a new commit, where both sections of code are fully up-do-date (use the native OS file chooser).

Making that fix will be almost as fast as describing it. I'll make the fix on a new branch, and then send the issue along the standard pipeline for review, and so on.

Please see this branch for the fix:
https://bitbucket.org/IvoryBlak/integrated-genome-browser/branch/IGBF-1183_IGBF-1184_manually_merge_code_for_native_OS_filechooser

The functional test for this issue should include verifying that both the import an the export file chooser windows use the native OS file chooser style.

This change reverts import statements that were changed as part of the IGBF-1354 fix. I am practically positive that those lines were removed to groom out unused imports and that removing them was not related to the fix for that issue. Reviewers should look at IGBF-1354 do whatever testing you see fit to make sure you agree with me.

I am moving this issue to needs first level review.
The IGBF-1183_IGBF-1184 branch should go through the same pipeline that a new fix would.

I tested on Mac. In the review process please test on Windows. Linux too if possible.

Hey Ivory Blakley: What is the data in the json file to be imported?
Could you give me a sample file? Also how do we know if the import is working or not?
Native file chooser is being display in place of non native so that looks good on Windows!

Tested on Windows.
Import and export functionalities are working and the File chooser is native OS file chooser.

Also tested IGBF-1354 and that bug is no more seen.

Thanks!

At this point, the only review step left is to test on linux.

Assigning to Kiran to test on linux.

I tested this on the linux machine.
Using the master branch installer, the import window uses the older finder window.
Using the installer from this branch, both import and export use the native OS file chooser window.

This test completes the review stage.
I am moving this to ready for pull request.

I rebased on master, and updated my the remote branch.
Submitted pull request.
Assigning to Ann.

Merged into master

Tested this issue on Windows and Linux environment, and it works as expected. Need to test on Mac OS.

Tested on MAC as well. Works as expected.