Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.1 Minor Release
-
Labels:None
-
Story Points:3
-
Sprint:B - Summer 2018
Description
In an annotation track you can add filters.
(see IGBF-1204 for instructions)
With a score filter, you can choose to edit the filter. This is not working. The current values are not reflected in the edit window and the values from the edit window are not reflected in the filter.
Attachments
Issue Links
Activity
I have submitted a pull request to main master.
After testing the changes.
I noticed that Edit filter is working. It doesn't have any issues.
I have tried Add/Remove/Edit functionalities in FliterBy option
This issue about "not updating the list of filters in Add/Remove/Edit Filters window" has been added as:
IGBF-1233
Sneha had some minor comments which we have address:
--removed unused import statement that I introduced
--clarified comments
--used
!(cp instanceof ColorProvider)
instead of
cp instanceof ScoreFilter
so the code is as similar as possible to what it was before issue IGBF-1229, with changes that should address the needs of that issue while minimizing other effects.
I have verified by inserting different score values. I did not encounter any bug in this functionality. Also checked the functioning of Remove and Add filter.
One bug was identified which deals with not updating the list of filters in Add/Remove/Edit Filters window.
New jira issue has been created for this new bug. Verified that code in this branch did not introduce the new bug.
This bug was also found in IGB 9.0.
Reviewing result:
Values of the edited scores are reflected in Edit Filter window but not in the list of added filters.
We believe this was introduced during the this issue.
https://jira.transvar.org/browse/IGBF-1129
In that, an if statement was removed so the code for the edit panel would always create a new instance of the incoming object.
By restoring the if statement, we fix this bug. IGBF-1129 made changes for the heat map case. So we added a condition to the if statement for that the heatmap case is always directed to make a new instance. But other cases are still directed by the if-statement as they previously were.
See branch
https://bitbucket.org/IvoryBlak/integrated-genome-browser/branch/IGBF-1232
This feature is working correctly in the current release of IGB: 9.0.0
After testing this story, I can confirm that this issue is functioning as it does in IGB 9.0.0. While testing this story I noticed another bug so I created
IGBF-1247(Combining strands causes data to disappear when using the "Filter By" feature). This bug is present in the current version of IGB, so it was not introduced by the code change for this story. We will need to determine the severity of this issue to see if it should make it into the 9.0.1 release or if it should be worked on for a future release. Since this story is resolved and there seem to be no side effects related to this change, it will now be closed.