Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Epic Link:
-
Sprint:Spring 10, Summer 1
Description
While testing IGBF-1232, I noticed this issue. It seems that data can disappear when using the "Filter By" feature on a track. Follow the steps below to reproduce:
1. Load a track and view it as separate strands.
2. Select one strand (one track) and filter by score so that the data models disappear from the track (the default value will probably make them disappear)
3. Combined the strands, then uncombine the strands (OBSERVE: Data models will be present in a track before you combine the strands, but missing from the track when you uncombine them.)
4. Remove the "Filter By" filter from your track. Data models will be missing from one of the tracks (to get them back you must combine the strands and then uncombine them)
Attachments
Issue Links
Activity
While testing, we found another issue with the combine and uncombine feature, that is when the user combines the two strands, gives a filter to the combined strand, uncombine them, and removes filter from one strand then the remove filter applies only to that strand and the other strand data won't be displayed and the user won't see the filter again in the filter list to remove it as it's already removed. Currently working on fixing this.
Fixed the issue, and testing is done working as expected. Updated code is available at branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3752. Please review and let me know if there any issues.
Tested using Sravani's branch on Mac.
The new logic is that if a track is separated into + and - strands, if a filter is applied to one strand and the strands are combined, no filter is applied to the combined strands. When the strands are separated, any filters applied to individual strands reappear. Previously, any filter applied to one strand would be applied to both strands when combined. Now, if a user wishes to apply a filter to both strands combined they must first combine the strands, then apply the filter. If the strands are then separated, both strands will have the same filter on them, which can then be removed individually.
This ticket will be included as part of the pull request in IGBF-3747.
Tested using early-access installer on Mac.
Combining strands no longer applies one strands filter to the other strand.
Closing ticket.
Investigated and fixed the issue, this is happening because whenever the user combines and uncombines the tracks every time it refreshes the sequence map and redraws all the tiers, in that workflow filter is being called directly without going through the FilterAction class, so the condition added in the FilterAction in the issues https://jira.bioviz.org/browse/IGBF-3698 didn't resolve it. Updated code is available at the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3747. Tested the code, working as expected. Please review and let me know if there are any issues.