Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.6 Major Release
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20
Description
If you right click a track label and choose clear data, the pop-up indicates that the visible data will be removed. This implies that the current view region is all that will be removed. But it clears the entire chromosome. It looks like it does not clear all the data for that track, just that chromosome.
I think we should either modify the message so it is not misleading, or modify the method so it matches the message.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Workflow | Loraine Lab Workflow [ 18002 ] | Fall 2019 Workflow Update [ 18868 ] |
| Workflow | Fall 2019 Workflow Update [ 18868 ] | Revised Fall 2019 Workflow Update [ 20993 ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Summary | Clear Data deletes by chromosome | Improve Clear Data message to user |
| Assignee | Ann Loraine [ aloraine ] |
| Attachment | ClearDataMessage.png [ 14928 ] |
| Summary | Improve Clear Data message to user | Improve Clear Data feature |
| Assignee | Ann Loraine [ aloraine ] |
| Summary | Improve Clear Data feature | Improve Clear Data message |
| Assignee | Ann Loraine [ aloraine ] |
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
| Epic Link | IGBF-1765 [ 17855 ] |
| Story Points | 0.5 | |
| Sprint | Fall 4 Oct 26 - Nov 6 [ 107 ] | |
| Labels | Beginner |
| Assignee | Irvin Naylor [ inaylor ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Irvin Naylor Please submit the link for the code change.
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Please un-assign your issue when you move to a "needs review" or "needs testing" column. Otherwise, no-one will pick it up.
| Assignee | Irvin Naylor [ inaylor ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested Irvin's 1311 branch installer for Mac.
The 2nd and 3rd sentence changes appear correctly.
I do not see the 1st line change according to Dr. Loraine's comment.
Irvin Naylor - please change the first sentence to "This will remove all data from the current sequence for the selected track(s)."
| Assignee | Nowlan Freese [ nfreese ] | Irvin Naylor [ inaylor ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Branch link - https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1311/
Fixed the issue with the first line's changes not showing up properly
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Irvin Naylor [ inaylor ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Everything looks fine but there are 3 commits for the change d3ddc03, 8c94a43, 93439b4. Remove all commits and make the change in 1 commit.
cc: Irvin Naylor
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] | Irvin Naylor [ inaylor ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Fixed link - https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-1311/
Squashed the three commits into one and fixed the commit message to reflect the change
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Irvin Naylor [ inaylor ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested branch installer for Mac. Everything looks good to me.
Irvin Naylor Go ahead and submit a pull request.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] | Irvin Naylor [ inaylor ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Irvin Naylor [ inaylor ] |
| Sprint | Fall 4 Oct 26 - Nov 6 [ 107 ] | Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20 [ 107, 108 ] |
| Rank | Ranked higher |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Working as expected.
| Assignee | Noor Zahara [ noor91zahara ] | Irvin Naylor [ inaylor ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 9.1.6 Major Release [ 10604 ] |
Suggestion for new wording:
"This will remove all data from the current sequence for the selected track(s).
This will NOT affect other sequences not currently shown.
Do you wish to continue?"