Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Sprint:Winter 2018 Sprint 3, Spring 2019 Sprint 1
Description
If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
So the Load Sequence option probably shouldn't be enabled.
As it is, you can click the Load Sequence button, and you get an error that says:
"Couldn't locate the partial sequence. Try loading the full sequence."
This error message does not make sense given the context. (In other contexts it does make sense.)
The error message for this particular workflow should be more informative. Or, the button "Load Sequence" should not be active when no sequence file is available.
The task:
- Investigate and identify files/code involved.
- Determine: is there any way for IGB to determine if the reference genome sequence is available to load before showing that message?
- Design a solution that improves user experience.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Ann Loraine [ aloraine ] |
| Rank | Ranked higher |
| Summary | poor error message | Improve error message shown upon opening a file before selecting a genome version |
| Story Points | 0.5 | |
| Sprint | Winter 2018 Sprint 3 [ 58 ] | |
| Labels | Beginner |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Description |
If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
So the Load Sequence option probably shouldn't be enabled. As it is, you can click the Load Sequence button, and you get an error that says: "Couldn't locate the partial sequence. Try loading the full sequence." Which makes not sense. The button should be disabled. Or it should produce a window that informs the user about why that action is not possible. |
If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
So the Load Sequence option probably shouldn't be enabled. As it is, you can click the Load Sequence button, and you get an error that says: "Couldn't locate the partial sequence. Try loading the full sequence." This error message does not make sense given the context. (In other contexts it *does* make sense.) The error message for this particular workflow should be more informative. Or, the button "Load Sequence" should not be active when no sequence file is available. The task: * Investigate and identify files/code involved. * Determine: is there any way for IGB to determine if a sequence file is available before showing that message? * Design a solution that improves user experience. |
| Story Points | 0.5 | 1 |
| Labels | Beginner | Intermediate |
| Issue Type | Improvement [ 4 ] | Task [ 3 ] |
This class may be important: com.affymetrix.igb.view.load.GeneralLoadView
| Description |
If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
So the Load Sequence option probably shouldn't be enabled. As it is, you can click the Load Sequence button, and you get an error that says: "Couldn't locate the partial sequence. Try loading the full sequence." This error message does not make sense given the context. (In other contexts it *does* make sense.) The error message for this particular workflow should be more informative. Or, the button "Load Sequence" should not be active when no sequence file is available. The task: * Investigate and identify files/code involved. * Determine: is there any way for IGB to determine if a sequence file is available before showing that message? * Design a solution that improves user experience. |
If you open a file in IGB without selecting a genome, you can view the file but there is no genome sequence.
So the Load Sequence option probably shouldn't be enabled. As it is, you can click the Load Sequence button, and you get an error that says: "Couldn't locate the partial sequence. Try loading the full sequence." This error message does not make sense given the context. (In other contexts it *does* make sense.) The error message for this particular workflow should be more informative. Or, the button "Load Sequence" should not be active when no sequence file is available. The task: * Investigate and identify files/code involved. * Determine: is there any way for IGB to determine if the reference genome sequence is available to load before showing that message? * Design a solution that improves user experience. |
Better error message?
"A genome sequence has not been selected. Loading sequence data is not possible."
Issue:- To improve the error message in case of loading sequence data from a file which doesn't have the genome data.
Files changed:-
core/igb/src/main/java/com/affymetrix/igb/view/load/GeneralLoadView.java
Testing scenarios:-
Drag and drop file in IGB application -
If no genome is selected, on clicking Load Sequence button you will get an error message "A genome sequence has not been selected.Loading sequence data is not possible."
Testing results:-
Please check the attached test result for each test scenario.
Code changes:-
https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-1312#diff
| Attachment | 1_a.PNG [ 14225 ] | |
| Attachment | 1_b_i.PNG [ 14226 ] | |
| Attachment | 1_b_ii.PNG [ 14227 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Assignee | Nowlan Freese [ nfreese ] | Ann Loraine [ aloraine ] |
| Status | Reviewing [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Comment |
[ The 1st level review looks good, however I would like Dr. Loraine to take a look, as there is a change to the default IGB behavior.
If a user drags and drops a sequence file (.2bit, .fasta, etc) into the IGB home screen, IGB now assumes the user meant to load that file as the genome. I think this works very well. If a user is dragging and dropping (instead of using File > Open File.../Open Genome from File...) then they are expecting IGB to make smart assumptions. Before, if a user dragged and dropped a sequence file into the IGB home screen it would load the file within the data track. ] |
| Attachment | 1_b_ii.PNG [ 14227 ] |
| Attachment | 1_a.PNG [ 14225 ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
1st level review:
Functions correctly, if no genome has been selected, clicking the Load Sequence button brings up the error message "A genome sequence has not been selected.Loading sequence data is not possible."
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Nowlan Freese [ nfreese ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Rank | Ranked higher |
| Sprint | Winter 2018 Sprint 3 [ 58 ] | Winter 2018 Sprint 3, Spring 2019 Sprint 1 [ 58, 59 ] |
| Rank | Ranked higher |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
Windows testing successful
MacOS testing successful.
| Rank | Ranked lower |
Linux testing successful.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Workflow | Loraine Lab Workflow [ 18003 ] | Fall 2019 Workflow Update [ 19898 ] |
| Workflow | Fall 2019 Workflow Update [ 19898 ] | Revised Fall 2019 Workflow Update [ 22017 ] |
Test file - download and load without 1st selecting a genome: