Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1348

Identify hard-coded URLs in IGB code base

        Details

        • Story Points:
          1
        • Sprint:
          B - Summer 2018, Summer 2018 Part 2, Summer 2018 Part 3, Fall 2018 1, Fall 2018 Sprint 2

          Description

          IGB appears hard-coded to request resources from BioViz.org and a few other sites.

          This makes testing and developing IGB challenging for developers because they need access to the access_logs of BioViz to add new features or fix bugs. It also makes updating URLs difficult and may slow down startup if IGB tries to access resources that no longer exist.

          Task is:

          Identify all places in IGB code base with URLs. Document these:

          • Report name of file with hard-coded URL (.java or other resources)
          • Report URL

          Request BioViz.org access_log from Dr. Loraine. Do not attach here to respect users' privacy.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Tip:

              • Configure your laptop to send all requests for bioviz.org or wiki.transvar.org Web pages to your testing site
              • On Unix, you would edit /etc/hosts

              IGB already is designed to request specific files from Quickload hosts (these are "baked in" and less likely to be optimizable). For example, IGB will try to retrieve a file called synonyms.txt from a Quickload site. This file is optional. If it not there, it's not considered an error.

              Show
              ann.loraine Ann Loraine added a comment - Tip: Configure your laptop to send all requests for bioviz.org or wiki.transvar.org Web pages to your testing site On Unix, you would edit /etc/hosts IGB already is designed to request specific files from Quickload hosts (these are "baked in" and less likely to be optimizable). For example, IGB will try to retrieve a file called synonyms.txt from a Quickload site. This file is optional. If it not there, it's not considered an error.
              Hide
              Permalink
              kkorey Kiran Korey (Inactive) added a comment -

              Please find the attached hard_coded_urls_formatted.txt file which contains references to the hardcoded URLs which are relevant and hard_coded_urls_original.txt which contains all references to the string "http://".

              Show
              kkorey Kiran Korey (Inactive) added a comment - Please find the attached hard_coded_urls_formatted.txt file which contains references to the hardcoded URLs which are relevant and hard_coded_urls_original.txt which contains all references to the string "http://".
              Hide
              Permalink
              sneha Sneha Ramesh Watharkar (Inactive) added a comment -

              Followed the recommendations provided by Professor [~aloraine] and made changes to the files which contains hard coded URLs.
              Moving it to 1st Level review column.

              Show
              sneha Sneha Ramesh Watharkar (Inactive) added a comment - Followed the recommendations provided by Professor [~aloraine] and made changes to the files which contains hard coded URLs. Moving it to 1st Level review column.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Add link to branch.

              Show
              ann.loraine Ann Loraine added a comment - Add link to branch.
              Hide
              Permalink
              sneha Sneha Ramesh Watharkar (Inactive) added a comment -

              You can find the work in this branch : https://bitbucket.org/swathark/integrated-genome-browser/branch/IGBF-1348#diff

              Show
              sneha Sneha Ramesh Watharkar (Inactive) added a comment - You can find the work in this branch : https://bitbucket.org/swathark/integrated-genome-browser/branch/IGBF-1348#diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Following change is needed before pull request can be merged:

              Show
              ann.loraine Ann Loraine added a comment - Following change is needed before pull request can be merged: Change: "updates= http://bioviz.org/igb/releases/igb-9.0.1/updates.xml " to "updates= http://bioviz.org/igb/releases/current/updates.xml " in plugins/Update/src/main/resources/updates.properties
              Hide
              Permalink
              sneha Sneha Ramesh Watharkar (Inactive) added a comment -

              Done with the above fix.

              Show
              sneha Sneha Ramesh Watharkar (Inactive) added a comment - Done with the above fix.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Ready for pull request.

              Show
              ann.loraine Ann Loraine added a comment - Ready for pull request.
              Hide
              Permalink
              sneha Sneha Ramesh Watharkar (Inactive) added a comment -

              PR submitted.

              Show
              sneha Sneha Ramesh Watharkar (Inactive) added a comment - PR submitted.
              Hide
              Permalink
              ieclabau Ivory Blakley (Inactive) added a comment - - edited

              I don't know how to test this issue.
              In the changes that were made for this issue, we removed things that we were sure were not used.
              So I am moving it to done.
              Reassigning to Sneha because she did the work.

              Show
              ieclabau Ivory Blakley (Inactive) added a comment - - edited I don't know how to test this issue. In the changes that were made for this issue, we removed things that we were sure were not used. So I am moving it to done. Reassigning to Sneha because she did the work.

                People

                • Assignee:
                  sneha Sneha Ramesh Watharkar (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: