git review:
single commit with appropriate message.
Needs to be rebased on master.
Code review:
Changes are simple and intuitive.
Need to check: is line 239 the only time that the loadData method is called? --> yes, it is a private method, called exactly once in this class.
Functional review:
This has been challenging. Just in testing with 9.0.1, IGB is not responding to links the way I think it should.
With my example link in the last comment and with the example given with the issue, IGB 9.0.1 gave me a message saying that I should zoom in a load data. On Sneha's branch, I did not get that message using those links. However I do get the message using the Galaxy View link which makes sense because it does not contain start and end values.
____________________________
Overall, this looks good. Before merging, I think Ann should consider weather or not this is a good idea.
This removes an inconvenience for advanced users. We already have a preferences option, so if you find the box annoying you can check the box to never see it again.
However, the general scenario of a track appearing, and being tiny and users not knowing that they need to load data (or zoom in and load data), is why we have that message in the first place. Many new users will be in exactly that position when they use BAR or Galaxy and are directed to use IGB for the first time. Even if the coordinates (start and stop) are specified, they may still specify a wide region. If the data is not loaded automatically, then the track will be tiny, and easy to not notice. See the image I attached.
Fixed the issue of "Zoom in " dialogue box appearing even when start and end positions are given in the request URL from bar site.
Now when there are start and end parameters in the URL, the dialogue doesn't appear.
Work is in the branch : https://bitbucket.org/swathark/integrated-genome-browser/branch/IGBF-1364#diff
How to test?
1) Click the link present in the html file attached to this issue. (BarLinksExample.html) . The URL contains start and end parameters so the user should not get dialogue box to "Zoom in and load data".
2) URL can be modified to delete start and end parameters and try hitting the link. Now we should be able to see the dialogue box.
Needs reviewing and first level testing.
Keeping the issue unassigned.