Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1372

Remember Filled Bar style for graphs between sessions

        Details

        • Story Points:
          1
        • Sprint:
          Winter 2018 Sprint 1, Winter 2018 Sprint 2

          Description

          If a user sets the style for a graph track, de-selects the graph track, and then re-selects it, the setting within the Graph tabbed panel is not properly re-set.

          To reproduce:

          • Open and load data for a graph track (see A. thaliana genome for examples you can load from the RNA-Seq Quickload data source)
          • Select the graph track
          • Select Graph tabbed panel
          • Select style Filled Bar
          • Deselect the track (the graph panel becomes inactive and doesn’t show any settings)
          • Re-select the same graph track
          • Notice: The graph is still drawn as Filled Bar, the but none of the radio buttons are selected.

          If you do the same thing and select any other style, the radio button is still selected when you re-select the graph track.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              ieclabau Ivory Blakley (Inactive) added a comment -

              This might be the file that needs to be fixed:

              integrated-genome-browser/plugins/GraphTab/src/main/java/com/affymetrix/igb/tabs/graph/GraphPanel.java

              Show
              ieclabau Ivory Blakley (Inactive) added a comment - This might be the file that needs to be fixed: integrated-genome-browser/plugins/GraphTab/src/main/java/com/affymetrix/igb/tabs/graph/GraphPanel.java
              Hide
              Permalink
              srishteeM Srishtee Marotkar (Inactive) added a comment -

              Note may help a reviewer : In GraphPanelImpl.java class there is a method 'buttonGroup1Reset()' which checks radio buttons based on graphStyle in 'graphState' variable which maintains graph style in previous session using switch case, there condition for Filled bar graph type was missing. It has been added as a fix

              Please review Changes:
              https://bitbucket.org/SrishteeM/integrated-genome-browser/commits/41160f3a84c0ae9261f0c2371f8936ddf98a211d

              Show
              srishteeM Srishtee Marotkar (Inactive) added a comment - Note may help a reviewer : In GraphPanelImpl.java class there is a method 'buttonGroup1Reset()' which checks radio buttons based on graphStyle in 'graphState' variable which maintains graph style in previous session using switch case, there condition for Filled bar graph type was missing. It has been added as a fix Please review Changes: https://bitbucket.org/SrishteeM/integrated-genome-browser/commits/41160f3a84c0ae9261f0c2371f8936ddf98a211d
              Hide
              Permalink
              pbole Pawan Bole (Inactive) added a comment -

              Tested on Dr.Loraine's IGB master branch.
              After toggling of selection and deselection of filled bar graph type the previous selection is persisted.
              Hence closing this and assigning it to the original developer.

              Show
              pbole Pawan Bole (Inactive) added a comment - Tested on Dr.Loraine's IGB master branch. After toggling of selection and deselection of filled bar graph type the previous selection is persisted. Hence closing this and assigning it to the original developer.

                People

                • Assignee:
                  Srishtee Srishtee Marotkar (Inactive)
                  Reporter:
                  ieclabau Ivory Blakley (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: