Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1389

Saving document with file extension on Mac system in Export bookmark feature throws error.

    Details

      Description

      When user tries to export bookmarks and saves the file with extension like html or txt then we get the following "You cannot save this document with extension “.html” at the end of the name. The required extension is “.”."

      This issue is not seen in Windows or Linux. Its specific to Mac Systems only.
      Need to investigate the issue particularly on Mac.

        Attachments

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment -

            This was reported back in Aug 2018. Check to see if this problem still exists. If yes, investigate why this is happening and report back here. Cross-platform problems are often complex to fix, so do not try to fix it without first assessing and reporting on the problem here.

            Show
            ann.loraine Ann Loraine added a comment - This was reported back in Aug 2018. Check to see if this problem still exists. If yes, investigate why this is happening and report back here. Cross-platform problems are often complex to fix, so do not try to fix it without first assessing and reporting on the problem here.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited

            The issues seems to be something to do with MacOS specifically where in the filename with extension is not allowed while saving a file using FileChooser API.

            Code changes has been done accordingly to avoid the above

            https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1389#diff

            Testing Steps

            1. Open IGB and add a bookmark
            2. Choose Export Bookmarks from the Bookmarks menu.
            3. Try saving html/txt file with and without extension in the filename.
            4. Repeat the above steps for all platforms - Windows, Mac, Linux.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited The issues seems to be something to do with MacOS specifically where in the filename with extension is not allowed while saving a file using FileChooser API. Code changes has been done accordingly to avoid the above https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1389#diff Testing Steps 1. Open IGB and add a bookmark 2. Choose Export Bookmarks from the Bookmarks menu. 3. Try saving html/txt file with and without extension in the filename. 4. Repeat the above steps for all platforms - Windows, Mac, Linux.
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            I have reviewed the code and tested on macOS. Exporting a bookmark without specifying an extension defaults to saving it with an html extension, as expected with the new changes. Moving forward, however, testing on windows and mac will still be needed.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - I have reviewed the code and tested on macOS. Exporting a bookmark without specifying an extension defaults to saving it with an html extension, as expected with the new changes. Moving forward, however, testing on windows and mac will still be needed.
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - PR Submitted - https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/821/igbf-1389/diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged. Master branch installers have built and are ready for testing.

            To test:

            • Check functionality on all platforms
            Show
            ann.loraine Ann Loraine added a comment - Merged. Master branch installers have built and are ready for testing. To test: Check functionality on all platforms
            Hide
            cdias1 Chester Dias (Inactive) added a comment -

            Tested on macOS, Windows, ubuntu for both scenarios involving each txt and html using the latest built master executables.

            Show
            cdias1 Chester Dias (Inactive) added a comment - Tested on macOS, Windows, ubuntu for both scenarios involving each txt and html using the latest built master executables.
            Hide
            ann.loraine Ann Loraine added a comment -
            Show
            ann.loraine Ann Loraine added a comment - For reference, here is the commit: https://bitbucket.org/lorainelab/integrated-genome-browser/commits/a2c464f76f56

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                sneha Sneha Ramesh Watharkar (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: