Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.6 Major Release
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep
Description
When user tries to export bookmarks and saves the file with extension like html or txt then we get the following "You cannot save this document with extension “.html” at the end of the name. The required extension is “.”."
This issue is not seen in Windows or Linux. Its specific to Mac Systems only.
Need to investigate the issue particularly on Mac.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Workflow | Loraine Lab Workflow [ 18093 ] | Fall 2019 Workflow Update [ 18899 ] |
| Workflow | Fall 2019 Workflow Update [ 18899 ] | Revised Fall 2019 Workflow Update [ 21026 ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Epic Link | IGBF-1765 [ 17855 ] |
| Story Points | 1 | |
| Labels | beginner |
| Sprint | Summer 6: 17 Aug - 28 Aug [ 101 ] |
| Labels | beginner | beginner intermediate |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
The issues seems to be something to do with MacOS specifically where in the filename with extension is not allowed while saving a file using FileChooser API.
Code changes has been done accordingly to avoid the above
https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1389#diff
Testing Steps
1. Open IGB and add a bookmark
2. Choose Export Bookmarks from the Bookmarks menu.
3. Try saving html/txt file with and without extension in the filename.
4. Repeat the above steps for all platforms - Windows, Mac, Linux.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
I have reviewed the code and tested on macOS. Exporting a bookmark without specifying an extension defaults to saving it with an html extension, as expected with the new changes. Moving forward, however, testing on windows and mac will still be needed.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged. Master branch installers have built and are ready for testing.
To test:
- Check functionality on all platforms
| Sprint | Summer 6: 17 Aug - 28 Aug [ 101 ] | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ] |
| Rank | Ranked higher |
| Assignee | Chester Dias [ cdias1 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested on macOS, Windows, ubuntu for both scenarios involving each txt and html using the latest built master executables.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Chester Dias [ cdias1 ] | Noor Zahara [ noor91zahara ] |
For reference, here is the commit:
| Fix Version/s | 9.1.6 Major Release [ 10604 ] |
This was reported back in Aug 2018. Check to see if this problem still exists. If yes, investigate why this is happening and report back here. Cross-platform problems are often complex to fix, so do not try to fix it without first assessing and reporting on the problem here.