Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1410

Improve file name and file existence checking logic when saving track data

    Details

      Description

      Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
      If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file.
      If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place).
      This seems very closely related to issue IGBF-1128.

      The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists.

      We should also add a check to see if the given name already ends in the desired file extension.

      To see the Save Track As... option, right click on a track label.
      This is true for both annotation tracks and graph tracks.

      I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated.

        Attachments

          Issue Links

            Activity

            ieclabau Ivory Blakley (Inactive) created issue -
            ieclabau Ivory Blakley (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to IGBF-1128 [ IGBF-1128 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ieclabau Ivory Blakley (Inactive) made changes -
            Description Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
            If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file.
            This seems very closely related to issue IGBF-1128.
            Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
            If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file.
            If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place).
            This seems very closely related to issue IGBF-1128.

            The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists.

            We should also add a check to see if the given name already ends in the desired file extension.

            To see the Save Track As... option, right click on a track label.

            I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated.
            ieclabau Ivory Blakley (Inactive) made changes -
            Summary File extension is added even if it is already present Check if file is present AFTER adding the file extension, only add extension if it is not already there
            ieclabau Ivory Blakley (Inactive) made changes -
            Labels Beginner
            ieclabau Ivory Blakley (Inactive) made changes -
            Description Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
            If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file.
            If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place).
            This seems very closely related to issue IGBF-1128.

            The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists.

            We should also add a check to see if the given name already ends in the desired file extension.

            To see the Save Track As... option, right click on a track label.

            I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated.
            Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
            If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file.
            If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place).
            This seems very closely related to issue IGBF-1128.

            The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists.

            We should also add a check to see if the given name already ends in the desired file extension.

            To see the Save Track As... option, right click on a track label.
            This is true for both annotation tracks and graph tracks.

            I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated.
            ieclabau Ivory Blakley (Inactive) made changes -
            Labels Beginner intermediate
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18115 ] Fall 2019 Workflow Update [ 18907 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 18907 ] Revised Fall 2019 Workflow Update [ 21034 ]
            Status Open [ 1 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Summary Check if file is present AFTER adding the file extension, only add extension if it is not already there Improve file name and file existence checking logic when saving track data
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Story Points 2
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Link This issue is cloned by IGBF-2654 [ IGBF-2654 ]
            nfreese Nowlan Freese made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            nfreese Nowlan Freese made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            nfreese Nowlan Freese made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            nfreese Nowlan Freese made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            nfreese Nowlan Freese made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            nfreese Nowlan Freese made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            nfreese Nowlan Freese made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            nfreese Nowlan Freese made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            nfreese Nowlan Freese made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            nfreese Nowlan Freese made changes -
            Fix Version/s 9.1.10 Major Release [ 10700 ]
            ann.loraine Ann Loraine made changes -
            Assignee Nowlan Freese [ nfreese ]

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                ieclabau Ivory Blakley (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: