Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2654

Fix: 'replace' action while saving file

        Details

          Description

          *Problem persists 9.1.10. See comment.
          Testing is not yet finished. Something Rachel noticed is that the "Verify that a pop-up appears asking you to confirm if you would like to replace the file." test only works for file names with a file type in the name, not for just the name alone. The file will overwrite and save, but there will be no pop-up.

          *below is fixed*
          For example, saving a track as SaveFile, then saving another track as SaveFile in the same location does not produce a pop-up. It will replace the existing file.
          If I save a track as SaveFile.bed, then save another track as SaveFile.bed in the same location it will produce a pop-up.

            Attachments

              Issue Links

              clones

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1410 Improve file name and file existence checking logic when saving track data

              • Major - Major loss of function.
              • Closed
              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1128 Save As... feature appends extra text that can cause the file name to be invalid

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-3203 Fix save track file extension dropdown selection

              • Major - Major loss of function.
              • To-Do

              Task - A task that needs to be done. IGBF-2608 Test FileChooser subsystem - Windows

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-3208 Fix: Linux save file not adding file extension to saved tracks or sessions

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                12 older comments
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                I have fixed the ExportDialog.java file extension.

                Commit: https://bitbucket.org/nfreese/nowlanfork-igb/commits/7a6a8d907c3cc0be92114b93f51baf88d0c64462

                Show
                nfreese Nowlan Freese added a comment - I have fixed the ExportDialog.java file extension. Commit: https://bitbucket.org/nfreese/nowlanfork-igb/commits/7a6a8d907c3cc0be92114b93f51baf88d0c64462
                Hide
                Permalink
                rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

                Commits reviewed.

                I tested on Windows saving images of all 3 file types as all 4 different views both with an without file extensions. All of them saved with the appropriate extensions, no files were created without extensions, and no files were created with double extensions.

                Recommending Pull Request.

                Show
                rweidenh Logan Weidenhammer (Inactive) added a comment - - edited Commits reviewed. I tested on Windows saving images of all 3 file types as all 4 different views both with an without file extensions. All of them saved with the appropriate extensions, no files were created without extensions, and no files were created with double extensions. Recommending Pull Request.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/917/igbf-2654

                Show
                nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/917/igbf-2654
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                PR is merged and new master branch installers are built. Apple installer is notarized and uploaded to Downloads section of the IGB team repository. New installers are deployed to the "early access" section of the BioViz.org Web site.

                Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - PR is merged and new master branch installers are built. Apple installer is notarized and uploaded to Downloads section of the IGB team repository. New installers are deployed to the "early access" section of the BioViz.org Web site. Ready for testing.
                Hide
                Permalink
                rweidenh Logan Weidenhammer (Inactive) added a comment -

                Post-merge testing is complete. I tested the same functions as my previous comment as well as ran through the Image Export subsystem tests. Everything is working as intended.
                Moving to done.

                Show
                rweidenh Logan Weidenhammer (Inactive) added a comment - Post-merge testing is complete. I tested the same functions as my previous comment as well as ran through the Image Export subsystem tests. Everything is working as intended. Moving to done.

                  People

                  • Assignee:
                    nfreese Nowlan Freese
                    Reporter:
                    ssegu Sai Supreeth Segu (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: