Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Trivial
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul
Description
See Cache testing module:
https://wiki.transvar.org/display/ITD/Cache
See Perferences > Cache
The button to Reset Cache Preferences does seem to be working, but the new Max Cache Size is not reflected in the window.
To reproduce this:
Clear the cache using the Clear All button.
Set the Max Cache Size to 15 MB
Go to A thaliana, and select Load Sequence.
A window will ask if you want to cache the sequence, say yes.
A window will ask if you want to increase the max cache size, say no.
Go to the Cache preferences, notice that there is no new entry, because there was not enough room to cache the A thaliana sequence.
Click Reset Cache Preferences.
Notice that the value in the text box for Max Cache Size does not change.
Go to the A thaliana genome again, and select Load Sequence.
If a window appears asking if you would like to cache it, say yes.
Notice there is NO window saying that you should increase the Max Cache Size.
Notice that now, the Max Cache Size displays its original value, 2048.
If you change the Max Cache Size, then Reset it, then hit refresh, the value is updated.
The value in the text box should be updated when the Reset button is pushed.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Workflow | Loraine Lab Workflow [ 18118 ] | Fall 2019 Workflow Update [ 18909 ] |
| Workflow | Fall 2019 Workflow Update [ 18909 ] | Revised Fall 2019 Workflow Update [ 21036 ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Epic Link | IGBF-1765 [ 17855 ] |
| Story Points | 0.5 | |
| Sprint | Summer 4: 14 Jul - 28 Jul [ 99 ] | |
| Labels | Intermediate |
| Rank | Ranked higher |
| Assignee | Prutha Kulkarni [ prutha ] |
| Sprint | Summer 4: 14 Jul - 28 Jul [ 99 ] | Summer 3: 6 Jul - 17 Jul [ 98 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Code looks fine!
Chirag Chandrahas Shetty - could you do the functional review? Also, if you need any clarification on the testing steps, please feel free to get help from Prutha Kulkarni!
Sure [~aloraine], I will work on this.
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Functional review is done. Reset Cache Preferences Button on Windows system is working fine now. Followed the following steps for functional testing:
1) Checked main branch executable to understand the bug.
2) Tested the branch executable by setting a random Max value cache and clicking on the Reset Cache Preference Button. The value is reset to 2048.
Prutha Kulkarni please submit a PR.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] | Prutha Kulkarni [ prutha ] |
PR has been submitted for the same:
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/806/igbf-1413-change-max-cache-size-when-user/diff
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Summer 3: 6 Jul - 17 Jul [ 98 ] | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] |
| Rank | Ranked higher |
PR is merged. Please used master branch installer from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/ for testing.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested this ticket. The Max cache size reflects default value when Reset Button is clicked, after changing to a random value of Max cache size. Moving to closed.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Prutha Kulkarni [ prutha ] |
The code changes are at:
https://bitbucket.org/pkulka10/igb_prutha/src/IGBF-1413/
Please follow the steps mentioned in the previous comment to test it.