Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1413

Max Cache Size should reflect change when user Resets Cache Preferences

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      See Cache testing module:
      https://wiki.transvar.org/display/ITD/Cache

      See Perferences > Cache

      The button to Reset Cache Preferences does seem to be working, but the new Max Cache Size is not reflected in the window.

      To reproduce this:
      Clear the cache using the Clear All button.
      Set the Max Cache Size to 15 MB
      Go to A thaliana, and select Load Sequence.
      A window will ask if you want to cache the sequence, say yes.
      A window will ask if you want to increase the max cache size, say no.
      Go to the Cache preferences, notice that there is no new entry, because there was not enough room to cache the A thaliana sequence.
      Click Reset Cache Preferences.
      Notice that the value in the text box for Max Cache Size does not change.
      Go to the A thaliana genome again, and select Load Sequence.
      If a window appears asking if you would like to cache it, say yes.
      Notice there is NO window saying that you should increase the Max Cache Size.
      Notice that now, the Max Cache Size displays its original value, 2048.

      If you change the Max Cache Size, then Reset it, then hit refresh, the value is updated.

      The value in the text box should be updated when the Reset button is pushed.

        Attachments

          Activity

          Hide
          prutha Prutha Kulkarni (Inactive) added a comment -

          The code changes are at:
          https://bitbucket.org/pkulka10/igb_prutha/src/IGBF-1413/

          Please follow the steps mentioned in the previous comment to test it.

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - The code changes are at: https://bitbucket.org/pkulka10/igb_prutha/src/IGBF-1413/ Please follow the steps mentioned in the previous comment to test it.
          Hide
          ann.loraine Ann Loraine added a comment -

          Code looks fine!
          Chirag Chandrahas Shetty - could you do the functional review? Also, if you need any clarification on the testing steps, please feel free to get help from Prutha Kulkarni!

          Show
          ann.loraine Ann Loraine added a comment - Code looks fine! Chirag Chandrahas Shetty - could you do the functional review? Also, if you need any clarification on the testing steps, please feel free to get help from Prutha Kulkarni !
          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          Sure [~aloraine], I will work on this.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Sure [~aloraine] , I will work on this.
          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          Functional review is done. Reset Cache Preferences Button on Windows system is working fine now. Followed the following steps for functional testing:
          1) Checked main branch executable to understand the bug.
          2) Tested the branch executable by setting a random Max value cache and clicking on the Reset Cache Preference Button. The value is reset to 2048.

          Prutha Kulkarni please submit a PR.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Functional review is done. Reset Cache Preferences Button on Windows system is working fine now. Followed the following steps for functional testing: 1) Checked main branch executable to understand the bug. 2) Tested the branch executable by setting a random Max value cache and clicking on the Reset Cache Preference Button. The value is reset to 2048. Prutha Kulkarni please submit a PR.
          Show
          prutha Prutha Kulkarni (Inactive) added a comment - PR has been submitted for the same: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/806/igbf-1413-change-max-cache-size-when-user/diff
          Hide
          ann.loraine Ann Loraine added a comment -

          PR is merged. Please used master branch installer from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/ for testing.

          Show
          ann.loraine Ann Loraine added a comment - PR is merged. Please used master branch installer from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/ for testing.
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

          Tested this ticket. The Max cache size reflects default value when Reset Button is clicked, after changing to a random value of Max cache size. Moving to closed.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket. The Max cache size reflects default value when Reset Button is clicked, after changing to a random value of Max cache size. Moving to closed.

            People

            • Assignee:
              prutha Prutha Kulkarni (Inactive)
              Reporter:
              ieclabau Ivory Blakley (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: