Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1477

Improve galaxy bridge code - first draft

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      3
    • Sprint:
      Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep

      Description

      Previously, [~aloraine] re-factored the BAR-to-IGB bridge code - bar.js and bar.html, deployed on Bioviz.org

      The refactored code works well and so far we have not had any problems.

      We also have code used to link the Galaxy system to IGB - galaxy.html and galaxy.js.

      For this task, re-factor the code and the structure of the page to match changes made to bar.js and bar.html.

      The code repository and instructions on how to deploy BioViz.org are here: https://bitbucket.org/lorainelab/bioviz

        Attachments

        1. ErrorPageMockup.png
          ErrorPageMockup.png
          383 kB
        2. Flowchart.jpg
          Flowchart.jpg
          87 kB
        3. Success page.JPG
          Success page.JPG
          101 kB
        4. SuccessPageMockup.png
          SuccessPageMockup.png
          287 kB
        5. Updated1.JPG
          Updated1.JPG
          82 kB
        6. VersionNotPresentError.JPG
          VersionNotPresentError.JPG
          116 kB

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18192 ] Fall 2019 Workflow Update [ 18926 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 18926 ] Revised Fall 2019 Workflow Update [ 21052 ]
            Status Open [ 1 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Epic Link IGBF-1880 [ 17970 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-1218 [ IGBF-1218 ]
            ann.loraine Ann Loraine made changes -
            Link This issue is blocked by IGBF-1487 [ IGBF-1487 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Story Points 2 3
            ann.loraine Ann Loraine made changes -
            Description Previously, Dr. Loraine re-factored the BAR-to-IGB bridge code - bar.js and bar.html, deployed on Bioviz.org

            The refactored code works well and so far we have not had any problems.

            We also have code used to link the Galaxy system to IGB - galaxy.html and galaxy.js.

            For this task, re-factor the code and the structure of the page to match changes made to bar.js and bar.html.

            The code repository and instructions on how to deploy BioViz.org are here: https://bitbucket.org/lorainelab/bioviz
            Previously, [~aloraine] re-factored the BAR-to-IGB bridge code - bar.js and bar.html, deployed on Bioviz.org

            The refactored code works well and so far we have not had any problems.

            We also have code used to link the Galaxy system to IGB - galaxy.html and galaxy.js.

            For this task, re-factor the code and the structure of the page to match changes made to bar.js and bar.html.

            The code repository and instructions on how to deploy BioViz.org are here: https://bitbucket.org/lorainelab/bioviz
            ann.loraine Ann Loraine made changes -
            Sprint Summer 6: 17 Aug - 28 Aug [ 101 ]
            Labels Intermediate
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 6: 17 Aug - 28 Aug [ 101 ] Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

            The code changes are present below:

            https://bitbucket.org/skulka2710/bioviz/branch/IGBF-1477#diff

            cc: Prof. [~aloraine]

            Please let me know if any changes are required.

            If possible, could you please help me set-up the test.bioviz.org to test the changes?

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited The code changes are present below: https://bitbucket.org/skulka2710/bioviz/branch/IGBF-1477#diff cc: Prof. [~aloraine] Please let me know if any changes are required. If possible, could you please help me set-up the test.bioviz.org to test the changes?
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            New EC2 set up for use by Shamika Gajanan Kulkarni. Login details to be sent via separate email.

            Show
            ann.loraine Ann Loraine added a comment - New EC2 set up for use by Shamika Gajanan Kulkarni . Login details to be sent via separate email.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Thank you Prof. [~aloraine]

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Thank you Prof. [~aloraine]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Deployed Shamika's fork and branch on new EC2 using https://bitbucket.org/lorainelab/bioviz-playbooks with the following settings:

            bioviz_repo: https://bitbucket.org/skulka2710/bioviz.git
            bioviz_version: IGBF-1477
            ec2_name: ShamikaBioviz
            server_name: shamika.bioviz.org
            igb_version: 9.1.4
            genoviz_version: 1.1.9
            

            Added a new "a name" record linking shamika.bioviz.org to new EC2's IP address. This will take a few hours to propagate.

            To test:

            • Modify your localhost to use above bioviz site in place of the main BioViz site so that when you click "View in IGB" links in Galaxy main, the links will resolve to the test site above.
            • View release testing site (wiki.transvar.org.) for details on how to test that Galaxy connectivity is working.
            Show
            ann.loraine Ann Loraine added a comment - - edited Deployed Shamika's fork and branch on new EC2 using https://bitbucket.org/lorainelab/bioviz-playbooks with the following settings: bioviz_repo: https: //bitbucket.org/skulka2710/bioviz.git bioviz_version: IGBF-1477 ec2_name: ShamikaBioviz server_name: shamika.bioviz.org igb_version: 9.1.4 genoviz_version: 1.1.9 Added a new "a name" record linking shamika.bioviz.org to new EC2's IP address. This will take a few hours to propagate. To test: Modify your localhost to use above bioviz site in place of the main BioViz site so that when you click "View in IGB" links in Galaxy main, the links will resolve to the test site above. View release testing site (wiki.transvar.org.) for details on how to test that Galaxy connectivity is working.
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Shamika Gajanan Kulkarni [ shamika ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Shamika Gajanan Kulkarni - please check your new branch using the above site.

            Show
            ann.loraine Ann Loraine added a comment - Shamika Gajanan Kulkarni - please check your new branch using the above site.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Thank you so much! I shall comment on the ticket after testing

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Thank you so much! I shall comment on the ticket after testing
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            I have tested the code changes based on instructions above.
            After modifying the localhost to redirect main bioviz site to shamika.bioviz.org, the code changes are visible and Galaxy connectivity is working properly.

            Prof. [~aloraine], I have attached a screenshot for the page displayed when version is null in URL. Please let me know if the font size and style is okay as it is or should we modify that too for consistency?

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - I have tested the code changes based on instructions above. After modifying the localhost to redirect main bioviz site to shamika.bioviz.org, the code changes are visible and Galaxy connectivity is working properly. Prof. [~aloraine] , I have attached a screenshot for the page displayed when version is null in URL. Please let me know if the font size and style is okay as it is or should we modify that too for consistency?
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment VersionNotPresentError.JPG [ 14855 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Good question!

            Could you make an appointment with Logan Weidenhammer to show her the UI, walk her through the functionality, and get some feedback?

            attn: Logan Weidenhammer and Shamika Gajanan Kulkarni

            Show
            ann.loraine Ann Loraine added a comment - Good question! Could you make an appointment with Logan Weidenhammer to show her the UI, walk her through the functionality, and get some feedback? attn: Logan Weidenhammer and Shamika Gajanan Kulkarni
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Shamika Gajanan Kulkarni [ shamika ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Yes sure! Thank you

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Yes sure! Thank you
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Me and Logan Weidenhammer met online today to discuss the UI and get her feedback. The suggestions were as follows:
            The block can be red and smaller in size to look consistent.
            I worked on it and will attach screenshots soon for Logan Weidenhammer and Prof. [~aloraine] to check.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Me and Logan Weidenhammer met online today to discuss the UI and get her feedback. The suggestions were as follows: The block can be red and smaller in size to look consistent. I worked on it and will attach screenshots soon for Logan Weidenhammer and Prof. [~aloraine] to check.
            Hide
            ann.loraine Ann Loraine added a comment -

            Quick question:

            • Is it going to be red to signal a problem or error? If yes, does the UI let the user know how they can recover from the error?
            Show
            ann.loraine Ann Loraine added a comment - Quick question: Is it going to be red to signal a problem or error? If yes, does the UI let the user know how they can recover from the error?
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment Updated1.JPG [ 14856 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            It will suggest that the version of genome is not present or is null in URL. The UI suggests the user to go back to Galaxy page and try again. The message displayed on the UI is as follows.
            "The file you are trying to view does not have a genome version associated with it. Please return to Galaxy and associate a genome version with the file and try again."
            I have attached an updated UI sample to this ticket. If this looks fine, I shall make the changes in the code and submit it for first level review.

            cc: Prof. [~aloraine], Logan Weidenhammer

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - It will suggest that the version of genome is not present or is null in URL. The UI suggests the user to go back to Galaxy page and try again. The message displayed on the UI is as follows. "The file you are trying to view does not have a genome version associated with it. Please return to Galaxy and associate a genome version with the file and try again." I have attached an updated UI sample to this ticket. If this looks fine, I shall make the changes in the code and submit it for first level review. cc: Prof. [~aloraine] , Logan Weidenhammer
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Suggestion for change to UI shown when there is no genome version associated with the file the user has clicked in Galaxy:

            • Let's shorten the message somehow. Can we communicate the idea in fewer words?
            • Can we change the Salutation to make it friendly and not use the term "user" (it's a little jargony.) How about: "Welcome from [referrer domain]" We could use javascript to detect this. It would be good to somehow give the user some feedback letting them know how they arrived at this page.
            • Instead of just telling the user to go back and attach a genome version to their file, we should tell them how to do this. We ought to make a super-short video (30 sec?) that the user could click on to see how this works.

            Logan Weidenhammer & Shamika Gajanan Kulkarni - please read the above and let us know what you think about it

            Show
            ann.loraine Ann Loraine added a comment - - edited Suggestion for change to UI shown when there is no genome version associated with the file the user has clicked in Galaxy: Let's shorten the message somehow. Can we communicate the idea in fewer words? Can we change the Salutation to make it friendly and not use the term "user" (it's a little jargony.) How about: "Welcome from [referrer domain] " We could use javascript to detect this. It would be good to somehow give the user some feedback letting them know how they arrived at this page. Instead of just telling the user to go back and attach a genome version to their file, we should tell them how to do this. We ought to make a super-short video (30 sec?) that the user could click on to see how this works. Logan Weidenhammer & Shamika Gajanan Kulkarni - please read the above and let us know what you think about it
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment Success page.JPG [ 14858 ]
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Based on the flowchart created by Shamika Gajanan Kulkarni, it looks like we have 2 main scenarios. The user will take actions which will land them on either the IGB Error Page (where the data cannot be launched by IGB), or the Success Page (where the genome loads in IGB but may or may not be associated with the correct genome version). We drafted a rough outline of what each of these pages might say to the user, giving them steps for troubleshooting their error.

            UI wording for the Error Page
            Error. Genome failed to launch in IGB. Check file attributes for correct genome version.
            Steps:
            Go to usegalaxy.org/datasets/edit
            Select "edit attributes" icon for the file
            Go to the "Database/Build" dropdown
            Select the correct genome version (similar to species name)
            Click save at the top
            Now the uploaded file with update in the history section on the right of the page
            Now click View in IGB
            (See the Success Page)

            UI Wording in the Success Page
            (current) "Thank You. Your data will appear in IGB..."
            (below)
            Warning: If your genome appears as “Custom Genome” in the Species window and Genome Version at the top right, the genome version you selected in Galaxy may not be correct, or may not be supported by IGB.
            Please go back to usegalaxy.org/datasets/edit and edit the attributes of the file so that the Database/Build is the correct genome version (usually similar to the species name)
            Steps:
            Go to usegalaxy.org/datasets/edit
            Select "edit attributes" icon for the file
            Go to the "Database/Build" dropdown
            Select the correct genome version (similar to species name)
            Click save at the top
            Now the uploaded file with update in the history section on the right of the page
            Now click View in IGB
            (See the Success Page)

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Based on the flowchart created by Shamika Gajanan Kulkarni , it looks like we have 2 main scenarios. The user will take actions which will land them on either the IGB Error Page (where the data cannot be launched by IGB), or the Success Page (where the genome loads in IGB but may or may not be associated with the correct genome version). We drafted a rough outline of what each of these pages might say to the user, giving them steps for troubleshooting their error. UI wording for the Error Page Error. Genome failed to launch in IGB. Check file attributes for correct genome version. Steps: Go to usegalaxy.org/datasets/edit Select "edit attributes" icon for the file Go to the "Database/Build" dropdown Select the correct genome version (similar to species name) Click save at the top Now the uploaded file with update in the history section on the right of the page Now click View in IGB (See the Success Page) UI Wording in the Success Page (current) "Thank You. Your data will appear in IGB..." (below) Warning: If your genome appears as “Custom Genome” in the Species window and Genome Version at the top right, the genome version you selected in Galaxy may not be correct, or may not be supported by IGB. Please go back to usegalaxy.org/datasets/edit and edit the attributes of the file so that the Database/Build is the correct genome version (usually similar to the species name) Steps: Go to usegalaxy.org/datasets/edit Select "edit attributes" icon for the file Go to the "Database/Build" dropdown Select the correct genome version (similar to species name) Click save at the top Now the uploaded file with update in the history section on the right of the page Now click View in IGB (See the Success Page)
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            I have created 2 rough drafts of the possible user view of the Error and Success Pages.
            From these we can critique the layout, color shading, as well as text content.

            Error Page Draft Mockup https://www.figma.com/file/PWYmiX9Ikl4czuAJm3XhdR/Error?node-id=1%3A2
            Success Page Draft Mockup https://www.figma.com/file/INUfHNqM1zcvOatw7xjcGC/Success?node-id=0%3A1

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - I have created 2 rough drafts of the possible user view of the Error and Success Pages. From these we can critique the layout, color shading, as well as text content. Error Page Draft Mockup https://www.figma.com/file/PWYmiX9Ikl4czuAJm3XhdR/Error?node-id=1%3A2 Success Page Draft Mockup https://www.figma.com/file/INUfHNqM1zcvOatw7xjcGC/Success?node-id=0%3A1
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Attachment SuccessPageMockup.png [ 14859 ]
            Attachment ErrorPageMockup.png [ 14860 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment Flowchart.jpg [ 14861 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Added the flowchart giving a rough idea about our plan of action.
            Please let me know if something needs to be corrected.

            cc: Prof. [~aloraine], Logan Weidenhammer

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Added the flowchart giving a rough idea about our plan of action. Please let me know if something needs to be corrected. cc: Prof. [~aloraine] , Logan Weidenhammer
            ann.loraine Ann Loraine made changes -
            Sprint Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ] Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 101, 102, 103 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -

            Please edit wording in Error page proposed re-wording:

            • "Now the uploaded file with update in the history section on the right of the page

            attn: Logan Weidenhammer

            Show
            ann.loraine Ann Loraine added a comment - Please edit wording in Error page proposed re-wording: "Now the uploaded file with update in the history section on the right of the page attn: Logan Weidenhammer
            Hide
            ann.loraine Ann Loraine added a comment -

            Error page mockup: The usegalaxy link shown will not be correct for Galaxy users visiting from any site other than usegalaxy.org. Logan Weidenhammer could you please comment?

            Show
            ann.loraine Ann Loraine added a comment - Error page mockup: The usegalaxy link shown will not be correct for Galaxy users visiting from any site other than usegalaxy.org. Logan Weidenhammer could you please comment?
            Hide
            ann.loraine Ann Loraine added a comment -

            Shamika Gajanan Kulkarni - notes on the code:

            • Some of the same functionality exists in bar.js as well. Please compare the two .js files. Can you take a careful look and move functionality into a new file that will be imported by both.

            The two files bar.js and galaxy.js ought to be mainly concerned with translating the links coming from the external sites into REST calls for IGB itself running on the localhost.

            In addition, we need some new code that will deal with Safari users. Specifically, the user needs to become aware that they cannot use Safari to send data to IGB.

            Show
            ann.loraine Ann Loraine added a comment - Shamika Gajanan Kulkarni - notes on the code: Some of the same functionality exists in bar.js as well. Please compare the two .js files. Can you take a careful look and move functionality into a new file that will be imported by both. The two files bar.js and galaxy.js ought to be mainly concerned with translating the links coming from the external sites into REST calls for IGB itself running on the localhost. In addition, we need some new code that will deal with Safari users. Specifically, the user needs to become aware that they cannot use Safari to send data to IGB.
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Shamika Gajanan Kulkarni [ shamika ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Yes Prof. [~aloraine] I shall do it.
            Question:
            So should we display some message for Safari users to use some other browser?

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Yes Prof. [~aloraine] I shall do it. Question: So should we display some message for Safari users to use some other browser?
            Hide
            ann.loraine Ann Loraine added a comment -

            Yes. Pleaes make it generic - "to open data in IGB, you need to use Firefox or Chrome browser."

            Show
            ann.loraine Ann Loraine added a comment - Yes. Pleaes make it generic - "to open data in IGB, you need to use Firefox or Chrome browser."
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            [~aloraine], Are we able to determine from the site where the user is coming from? In the interest of giving the user as much help as possible it would be nice if we could give them all instructions. Alternatively we could make it generic like above and tell all users to check that they have the correct genome version selected in their file upload.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - [~aloraine] , Are we able to determine from the site where the user is coming from? In the interest of giving the user as much help as possible it would be nice if we could give them all instructions. Alternatively we could make it generic like above and tell all users to check that they have the correct genome version selected in their file upload.
            Hide
            ann.loraine Ann Loraine added a comment -

            Sure! Javascript code can get the referrer from the HTTP header.
            Check out this example:

            https://stackoverflow.com/questions/2031362/checking-the-referrer

            Show
            ann.loraine Ann Loraine added a comment - Sure! Javascript code can get the referrer from the HTTP header. Check out this example: https://stackoverflow.com/questions/2031362/checking-the-referrer
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Mockup for the Generic Error Page for all non-galaxy users: https://www.figma.com/file/wjOlGpiKVF7YXUMb96bkk1/Error-Generic?node-id=0%3A1

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Mockup for the Generic Error Page for all non-galaxy users: https://www.figma.com/file/wjOlGpiKVF7YXUMb96bkk1/Error-Generic?node-id=0%3A1
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Mockup for the Generic Success Page for all non-galaxy users: https://www.figma.com/file/d5GK4S686WJOqgZ7PCtvXH/Success-Generic?node-id=0%3A1

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Mockup for the Generic Success Page for all non-galaxy users: https://www.figma.com/file/d5GK4S686WJOqgZ7PCtvXH/Success-Generic?node-id=0%3A1
            Hide
            ann.loraine Ann Loraine added a comment -

            Shamika Gajanan Kulkarni - please finalize your branch and post the link here. Then please move to Done.

            Show
            ann.loraine Ann Loraine added a comment - Shamika Gajanan Kulkarni - please finalize your branch and post the link here. Then please move to Done.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Yes. Thank you.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Yes. Thank you.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

            The code changes are present here:
            https://bitbucket.org/skulka2710/bioviz/branch/IGBF-1477#diff

            The changes implemented are as follows:
            1) Added utils.js file to contain common code snippets for bar.js and galaxy.js
            2) Changed the success page and error page appearances as per the mockups provided by Logan Weidenhammer
            3) Added a message page for Galaxy users on Safari to use Chrome or Firefox instead.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited The code changes are present here: https://bitbucket.org/skulka2710/bioviz/branch/IGBF-1477#diff The changes implemented are as follows: 1) Added utils.js file to contain common code snippets for bar.js and galaxy.js 2) Changed the success page and error page appearances as per the mockups provided by Logan Weidenhammer 3) Added a message page for Galaxy users on Safari to use Chrome or Firefox instead.
            ann.loraine Ann Loraine made changes -
            Summary Improve galaxy bridge code Improve galaxy bridge code - first draft
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                shamika Shamika Gajanan Kulkarni (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: