Details

    • Story Points:
      0.25
    • Sprint:
      Spring 2019 Sprint 1

      Description

      There are at least two places in the code where IGB creates and displays JFrames to users:

      • User selects Help > About
      • User tries to open an incorrectly formatted file

      Currently, some type of serif font is being shown (looks like Times). However, everywhere else in the UI we are using a san-serif font (looks like Arial.)

      Change this so that the JFrames mentioned above are using Arial, not Times.

        Attachments

        1. about_after.PNG
          about_after.PNG
          44 kB
        2. about_before.PNG
          about_before.PNG
          44 kB
        3. broken_after.PNG
          broken_after.PNG
          53 kB
        4. broken_before.PNG
          broken_before.PNG
          33 kB
        5. brokenBed.bed
          0.2 kB

          Issue Links

            Activity

            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

            Issue:- The font used for About page and error message when user tries to open an incorrectly formatted file is not aligned with rest of the application.

            Solution:- Changed the font for the places to "Arial, Helvetica, sans-serif"

            Files changed:-
            core/genometry/src/main/java/com/affymetrix/genometry/util/ModalUtils.java
            core/igb/src/main/resources/help/org.lorainelab.igb.AboutIGB.html

            Testing steps:-
            Scenario 1 - Click Help -> About Integrated Genome Browser
            Scenario 2 - Drag and drop broken bed file (sample broken file attached to the ticket) in the application to receive the error pop-up

            Testing results:-
            Please find the attached test results

            Code changes:-
            https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-1518#diff

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Issue:- The font used for About page and error message when user tries to open an incorrectly formatted file is not aligned with rest of the application. Solution:- Changed the font for the places to "Arial, Helvetica, sans-serif" Files changed:- core/genometry/src/main/java/com/affymetrix/genometry/util/ModalUtils.java core/igb/src/main/resources/help/org.lorainelab.igb.AboutIGB.html Testing steps:- Scenario 1 - Click Help -> About Integrated Genome Browser Scenario 2 - Drag and drop broken bed file (sample broken file attached to the ticket) in the application to receive the error pop-up Testing results:- Please find the attached test results Code changes:- https://bitbucket.org/rpatil14/riddhifork-igb/branch/IGBF-1518#diff
            Hide
            svallapu Sai Charan Reddy Vallapureddy added a comment -

            I have downloaded the .exe file and installed IGB in my system

            Verified all the changes and fonts are changed in both the below locations.
            Scenario 1 - Click Help -> About Integrated Genome Browser
            Scenario 2 - Drag and drop broken bed file (sample broken file attached to the ticket) in the application to receive the error pop-up

            Show
            svallapu Sai Charan Reddy Vallapureddy added a comment - I have downloaded the .exe file and installed IGB in my system Verified all the changes and fonts are changed in both the below locations. Scenario 1 - Click Help -> About Integrated Genome Browser Scenario 2 - Drag and drop broken bed file (sample broken file attached to the ticket) in the application to receive the error pop-up
            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted, https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/664/igbf-1518-change-font-of-about-page-and/diff
            Hide
            aloraine Ann Loraine added a comment -

            Merged to master.

            Show
            aloraine Ann Loraine added a comment - Merged to master.
            Hide
            Jill Jill Jenkins (Inactive) added a comment -

            MacOS successful

            Show
            Jill Jill Jenkins (Inactive) added a comment - MacOS successful
            Hide
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

            Windows testing successful

            Show
            rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Windows testing successful
            Hide
            svallapu Sai Charan Reddy Vallapureddy added a comment -

            Linux testing successful

            Show
            svallapu Sai Charan Reddy Vallapureddy added a comment - Linux testing successful

              People

              • Assignee:
                rpatil14 Riddhi Jagdish Patil (Inactive)
                Reporter:
                aloraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: